loop through a recordset

scrupul0us

for some reason this only returning the first record and not all:

<?php
while ($row = mysql_fetch_assoc($rs))
	{
		?>
		<table class="news_header" cellspacing="0" cellpadding="0">
		<tr>
		<td class="news_table_corners"><img src="../images/news_header.gif"/></td>
		<td class="news_title"><?php echo $row["newsTITLE"]; ?></td>
		<td class="news_date">&nbsp;<?php echo $row["newsDATE"]; ?>&nbsp;</td>
		</tr>
		</table>
		<table class="news_content" cellspacing="0" cellpadding="0">
		<tr valign="top">
		<td class="news_avatar"><img src="../images/news_avatars/<?php echo $row["newsAVATAR"]; ?>"></td>
		<td class="news_desc"><?php echo stripslashes($row["newsDESC"]); ?></td>
		</tr>							
		</table>
		<table class="news_footer">
		<tr>
		<td></td>
		</tr>
		</table>
		<br  />
		<!-- /News Block-->
		<?php 
	} 

?>

Help please

rehfeld

are you sure your query is returning more than 1 row?

you could use mysql_num_rows() to find out.

scrupul0us

Nope there are three

heres my call to my function:

$result = SELECT($items,$table_name,$where_condition,$group_by,$having,$order_by,$limit,$database_pcmedic,$pcmedic);

$rs = $result[0];
$query = $result[1];
$row = mysql_fetch_assoc($rs);
$totalrows = mysql_num_rows($rs);

my function:

//SELECT FUNCTION
function SELECT($items,$table_name,$where_condition,$group_by,$having,$order_by,$limit,$database_pcmedic,$pcmedic)
{
	mysql_select_db($database_pcmedic, $pcmedic);		

$query  ="SELECT $items FROM $table_name"; 

if ($where_condition !== "")
{
$query .=" WHERE $where_condition";
}
if ($group_by !== "")
{
$query .=" GROUP BY $group_by";
}
if ($having !== "")
{
$query .=" HAVING $having";
}
if ($order_by !== "")
{
$query .=" ORDER BY $order_by";
}
if ($limit !== "")
{
$query .=" LIMIT $limit";
}
$rs = mysql_query($query, $pcmedic) or die(mysql_error());
$row = mysql_fetch_assoc($rs);
$totalRows = mysql_num_rows($rs);

return array($rs,$query);
}

$query output:

SELECT * FROM news_table WHERE newsactive=1 ORDER BY newsid DESC

$totalrows output:

before I had done:

do
{
looped code
}
while ($row = mysql_fetch_assoc($rs))

that gave me only two of my results...

when i do the way as aforementioned I get just one result, the one missing from the two

hope that helps

scrupul0us

well I found that if i remove:

$row = mysql_fetch_assoc($rs);
$totalRows = mysql_num_rows($rs);

from my function, I get the two results this time... but still missing the third... when I apply this query in phpmydmin I get three results back

laserlight

Dont call functions unless you're going to use them.

Here both mysql_fetch_assoc() and mysql_num_rows() within SELECT() are redundant.
Let SELECT() return the resource, then manipulate this resource outside of the function.
If not, then let SELECT() extract the data from the resource, and return the result set as an array.
In that case, you dont need to call mysql_fetch_assoc() outside of SELECT().

When you do extract data from the resource, use a while loop, not a do while loop, which can be unnecessarily unconfusing.

Here's an example of the former method

//SELECT() funcion
function SELECT(/* arguments */) {
	/* query initialisation */
	//run query and return resource result
	return mysql_query($query, $pcmedic)
		OR die(mysql_error());
}

//main code
$result = SELECT(/* arguments */);
if (($totalrows = mysql_num_rows($result)) > 0) {
	while ($row = mysql_fetch_assoc($result)) {
		//do something with $row array
	}
} else {
	//no rows returned
}

scrupul0us

for some reason i could just return that query, i had to set it equal to $result and return $result... then it worked....I had a similar decision struct as your but didnt include it... thank you sir