Mysql Image rotator

[duny]

I am trying to develop a rotating images that selects the images from a database and can't seem to get it to work.

<? 
MySQL_connect("$host","$user","$pass");  

MySQL_select_db("$database") or die("Could not select database"); 
$q = mysql_query("SELECT * FROM ".$prefix."search"); 
$num = mysql_num_rows($q);
$rand = rand(1,$num); 
$q = mysql_query("SELECT * FROM ".$prefix."search WHERE url = '$rand' and type IN ('jpg','jpe','jpeg','png','gif')"); 
$r = mysql_fetch_array($q); 
$r1 = $r['url']; 
echo "<center><img src=\"$r1\" width=90 height=90></center>"; 
?>

[ScubaKing22]

A few things:

• The initial query is returning 0 results

• Prefix may not have been defined but is required

• I threw in the mysql_error() just in case there is anything happening that may be giving you 'unseen' errors

<? 
mysql_connect($host,$user,$pass);  

mysql_select_db($database) or die("Could not select database"); 
$q = mysql_query("SELECT * FROM ".$prefix."search");
echo mysql_error(); 
$num = mysql_num_rows($q);
echo mysql_error();
if($q > 0)
{
    $rand = rand(1,$num);
    $q = mysql_query("SELECT * FROM ".$prefix."search WHERE url = '$rand' and type IN ('jpg','jpe','jpeg','png','gif')");
    echo mysql_error(); 
    $r = mysql_fetch_array($q);
    echo mysql_error(); 
    $r1 = $r['url']; 
    echo "<center><img src=\"$r1\" width=\"90\" height=\"90\"></center>";
}
else
{
    echo "No images found.";
} 
?>

If you still can't seem to get this, maybe post the exact errors; or, if this is a snippet/stripped down version of your code post the full thing 😉

[duny]

get nothing

[Weedpacket]

Originally posted by duny
get nothing

Really? You mean you don't even get "No images found."? I'm guessing (though maybe I shouldn't) that you understood the code and noticed the typo in ScubaKing22's post ("$q > 0" instead of "$num > 0") and fixed that for yourself.

Try some of the suggestions given in the Debugging 101 thread; and try and be a bit more informative when you reply: "get nothing" tells us nothing, and unless you're wanting us to come around to your place and look at it on your computer, then we can do nothing with it.

[ScubaKing22]

Sorry about that; was really tired last night when I posted that :bemused: It's not really surprising that you didn't get the error message since the query probably succeeded and thus returned a non-0 value.

[Weedpacket]

Originally posted by ScubaKing22
Sorry about that; was really tired last night when I posted that :bemused:.

Not to worry - I do it often enough myself without that excuse. I consider finding them exercises in reading comprehension.

[duny]

Thanks, maybe i can come your house. And maybe sit and watch a little tv.

but after your dumb remarks the code still dosent work, but my little brain kicked in and this is what i came up with. Nice and simple the way i like it.

mysql_connect($host,$user,$pass); 
mysql_select_db($database) or die("Could not select database"); 
$q = "SELECT * FROM ".$prefix."search WHERE type IN ('jpg','jpe','jpeg','png','gif') ORDER BY RAND() LIMIT 1"; 
$result = MySQL_query($q); 
$r = MySQL_fetch_array($result); 
$r1 = $r['url']; 
echo "<center><img src=\"$r1\" width=\"90\" height=\"90\"></center>";