bad pratctice??

owaring

i have written a script that uses tick boxes on a form to get data from a user.

Ticking a box give the variable the value if 1, unchecked value is is 0.

When i pass this to processing page, with

error_reporting(E_ALL);

it notifies me that there is no value for the varables that arent checked.

however the script executes fine and data passed to db is fine also.

i wondered if there was a better way of doing this, or is it considered fine to leave the notices so long as not visible

planetsim

With checkboxes if you don check it, it doesnt get posted from the form to the processing page. You should use isset to check if the checkbox has been ticked.

bretticus

I'm sorry, "tick boxes"? Is that the term in the UK or something? Sorry couldn't resist. I was scratching my head thinking, what's a "tick box"? until I read Sim's post 😃

planetsim

Well basically take a look what happens when you use a checkbox you get a tick normally. But checkbox is the proper name for it.

owaring

so how should i process the data using isset then??

currently the variables are taken striaght from $_POST and put in to SQL statement, because i thought the form would pass a 0 if unchecked.

bubblocity

Might be easier if you post your code...

owaring

values for
$sound, $video, $lighting, $data, $projection, $racks, $vision, $camera, $set, $rigger, $driver, $graphics

are set to 1 if checked or no value if not

foreach ($_POST as $key => $value)
			{ 
  			$$key=$value; 
			}

$fieldquery = "INSERT INTO field 				$id','$sound','$video','$lighting','$data','$projection','$racks','$vision','$camera','$set','$rigger','$driver','$graphics'	
				 VALUES (')";

mysql_query($fieldquery)
or die ("Writing to field table failed");

bubblocity

I wasn't sure if you had one of those situations with multiple checkboxes with the same name , that's why I asked about the code:

In your situation, to explicitly check for a tick, all you need is:

if(isset ($_POST["sound")){ //ticked

$sound = 1;

}else{ //not ticked

$sound = 0;

}

.... and so forth...

owaring

do i need to do this for each var or can i use a for each?

bubblocity

Sorry, I thought you were only asking about isset();

Keeping you for each loop, you would already get "1" if checked,
below would give you "0" if not checked.

$checkboxarray= array("sound", "video", "lighting" ....);
for ($i=0;$i< count($checkboxarray);$i++){
$val = $checkboxarray[$i];
if(!isset($_POST[$val])){
$$val = 0;
}
}

I kind of think this is more trouble than it is worth. I personally like the "1" for checked, "" for not checked, that you already had working.

I do check more explicitly with the multiple checkbox scenaio...

sapoxgn

bubblocity, try using the [php ][/php ] tag (without spaces)

like this:

echo "not using php tag";

echo "using php tag";

bubblocity

like this?

Cool!

Thanks!