[Resolved] conditional problem¬

owaring

the user is greeted with the following statement.

A freelancer with the name blah blah already exists in the willow crew database.
You can either edit the existing blah blah, add a new blah blah, or cancel this process.

and the form buttons

the form processes dupe.php

which is coded...... (nothing before or after this)

<?

if ($_POST['choice'] == "Cancel")
{header("Location: add_int.php");}

elseif ($_POST['choice'] == "Edit Existing")
{header("Location: edit.php");}

elseif ($_POST['choice'] == "Add New")
{
//MAIN CODE HERE TO INSERT DATA IN DB
//UNTIL EVENTUALLY

}

?>

the if statements all work correctly. In the instance of "Cancel" and "Edit" they relocate the user nicely.
However they also execute the "Add New" code and insert user into db.

I cannot see why this happens as the conditions of the "Add" statement have not been met.

Ideas??

Advance thanks.

tsinka

Hi,

please post the form. Additionally, add an exit; line after each header function call to make sure that the script ends after sending the header.

Thomas

Mordecai

What would work best here is [man]switch[/man]:

if (!empty($_POST['choice']))
{
  switch($_POST['choice'])
  {
    case 'cancel':
    {
      // do whatever
      break;
    }
  }
}

The break; means that it will exit the current control structure. In this case, the switch. The cases you would use are 'Cance', 'Edit Existing', and 'Add New'.

You should also note that your headers (header('Location: add_int.php'), etc.) are incorrect. The 'Location' header requires a full URI. You can read more about this in section 14.30 of the HTTP RFC.

Hope that can help.

owaring

the form is simply

  <input type="submit" name="choice" value="Edit Existing">    

	<input type="submit" name="choice" value="Add New">
    <input type="submit" name="choice" value="Cancel">
  </p>
</form>

no input, i just use the buttons

owaring

have spotted the problem.

the conditional statement here is fine, it only executes when condition is met. (how did i ever doubt php!)

The problem was that the form which directs here was in a conditional statement itself, which had no exit; after form was output.

Therefore the db entries were being generated before the form was even displayed!!!

D'oh