Help - Guestbook Function...

[undershot]

Hi, I have a guestbook function that I'm trying to get to work, it all works, except when trying to submit a post. I use 1 table on my database for all my guestbooks, mainly band guestbooks, so artist is the column to defferenciate between different bands.

Any help would be much appreciated.

function guestbook($sitename) {

if ($btnSubmit) {
if (($name == '') or ($email == '') or ($comment == ''))
{
echo '
	<center>
		<b>Sorry, not all fields were filled in!</b>
	</center>
<hr>';
}else{
$time = date("G\:i j\/n\/Y");
$comment2 = nl2br("$comment");
mysql_query ("INSERT INTO guestbook (artist, time, name, email, message, ip) 
                VALUES ('$sitename', '$time', '$name', '$email', '$comment2', '$ip')"); 
echo '
	<center>
		<b>Thankyou, your comment has now been posted!</b>
	</center>
<hr>';
}}

$query = "SELECT id, time, name, email, message, ip FROM guestbook WHERE artist = '$sitename' ORDER BY id desc LIMIT 15";
$result = mysql_query($query);
while(list($id, $time, $name, $email, $comment, $ip) = mysql_fetch_row($result)) 

echo '
	<div class="article">
		<div class="article_title">Posted by <a href="mailto:'. $email .'">'. $name .'</a> - '. $time .'</div>
		<div class="article_content">
		'. $comment .'
		</div>
	</div>';

echo '
<hr>
	<form action="" method ="POST">
		<table align="center">
          <tr valign="top">
            <td>Name:</td>
            <td><input type="text" name="name"></td>
          </tr>
          <tr valign="top">
            <td>E-Mail: </td>
            <td><input type="text" name="email"></td>
          </tr>
          <tr valign="top">
            <td>Message: </td>
            <td><textarea name="comment"></textarea></td>
          </tr>
          <tr valign="top">
            <td>&nbsp;</td>
            <td><input type="submit" name="btnSubmit" value="Submit"></td>
          </tr>
        </table>
	</form>';}

Ryan x

[devinemke]

$btnSubmit, $name, $email and $comment are never defined in the local variable scope of your function. you should read up on Variable scope.

[ScubaKing22]

*EDIT: Just noticed another problem. When you're making the form, you say <form action="" method ="POST">. Without any page to be submitted to, not much is going to happen.

It looks like your problem lies in the fact that the variables you're trying to access haven't been declared. Try putting

global $btnSubmit,$name,$email,$comment;

at the top of your function. Alternatively, these are probably in the $POST array so try accessing them as such:

if ($_POST['btnSubmit']) {
if (($_POST['name'] == '') or ($_POST['email'] == '') or ($_POST['comment'] == ''))
{

If neither of these work, place

error_reporting(E_ALL);

at the very top of your script and see what it has to say.

Hope this helps 😉

[undershot]

Thankyou, the post global thingy worked beautifully, I know have a working guestbook script...

Thankyou, Ryan x