Deleting rows with checkbox. Almost got it but have an error.

[mlsbraves]

I'm creating a script that allows a user to delete users in their buddylist. I'm displaying all the users next to a checkbox where when checked and submitted the user will be deleted. But I keep getting this error:

Notice: Undefined index: profile_name

Notice: Undefined index: profile_name

Notice: Undefined index: profile_name

username

Displays this error three times then list the username.

Heres the line thats giving me the error:

print "\t<td><input type=\"checkbox\" name=\"delete[]\" value=\'" . $row['profile_name'] . "\' /></td>\n";

And heres the whole code:

$sql = mysql_query("SELECT * FROM profiles WHERE user='username'") or die(mysql_error());
while ($row = mysql_fetch_row($sql)) {
print "<tr>\n";
foreach ($row as $field)
print "\t<td><input type=\"checkbox\" name=\"delete[]\" value=\'" . $row['profile_name'] . "\' /></td>\n";
print "\t<td>$field</td>\n";
print "</tr>\n";

Thank you for your time.

[tsinka]

Hi,

that means that the table doesn't contain a column named profile_name. Check if a column with that name exists at all and if it is all lowercase (PHP handles array keys case sensitive).

Thomas

[mlsbraves]

It does contain a column name profile_name. It even displays the error three time then echos out the result. So it found the column. I can't understand whats wrong here :bemused:

[tsinka]

Ooops.

I oversaw the line

foreach ($row as $field)

That line doesn't make sense at that line. Shouldn't it be just above the line

print "\t<td>$field</td>\n";

or something like that ? How should the data be displayed ?

How does the row array look like if you add

print_r($row);

below the line

while ($row = ....)

Thomas

[mlsbraves]

I have everything displaying correctly and it should be right now but I keep getting these two errors when I post the delete.

Warning: Invalid argument supplied for foreach()
Notice: Undefined variable: del

<form action="<?=$_SERVER["PHP_SELF"]?>" method="POST">
<?php
// Make Connection
mysql_connect("localhost", "user", "pass") or die(mysql_error());
mysql_select_db("database") or die(mysql_error());
$loginuser = ($_SESSION["user_login"]);
// Get my result from the "profiles" table
$sql = mysql_query("SELECT profile_name FROM profiles WHERE user='$loginuser'") or die(mysql_error());
while ($row = mysql_fetch_assoc($sql)) {
print "<tr>\n";
print "\t<td><input type=\"checkbox\" name=\"delete\" value=\'" . $row['profile_name'] . "\' /></td>\n";
foreach ($row as $field)
print "\t<td>$field</td>\n";
print "</tr><br />\n";
}
?>
<tr><td>&nbsp;</td><td><input name="delete" type="submit" value="Delete"></td></tr>
</form>
<?php
if (isset($HTTP_POST_VARS['delete'])) { 
foreach ($HTTP_POST_VARS['delete'] as $field)
$del = "DELETE FROM profiles WHERE user = '$loginuser'AND profile_name = '$_POST[delete]'";
mysql_query($del);
}
else
echo "No items selected"; 
?>

Could someone tell me what I'm doing wrong now? Thanks so much for your time.

[Weedpacket]

On an incidental note, you might as well use $_POST instead of $HTTP_POST_VARS

An "invalid argument supplied for foreach()" error usually means that the array you're trying to loop over isn't an array. Check that (you seem to be calling the checkboxes "delete" in the form, instead of "delete[]" as you had earlier). Also, I think you want to use $field inside the SQL query, not $_POST[delete]. (All the queries in that loop could be combined and done at once, but let's not worry about that until we get this working).

[mlsbraves]

Thanks, $field did fixed the undefined vairable, but I still have problems with the foreach statement.

Current code is now:

<form action="<?=$_SERVER["PHP_SELF"]?>" method="POST">
<?php
// Make Connection
mysql_connect("localhost", "user", "pass") or die(mysql_error());
mysql_select_db("database") or die(mysql_error());
$loginuser = ($_SESSION["user_login"]);
// Get my result from the "profiles" table
$sql = mysql_query("SELECT profile_name FROM profiles WHERE user='$loginuser'") or die(mysql_error());
while ($row = mysql_fetch_assoc($sql)) {
print "<tr>\n";
print "\t<td><input type=\"checkbox\" name=\"delete[]\" value=\'" . $row['profile_name'] . "\' /></td>\n";
foreach ($row as $field)
print "\t<td>$field</td>\n";
print "</tr><br />\n";
}
?>
<tr><td>&nbsp;</td><td><input name="delete" type="submit" value="Delete"></td></tr>
</form>
<?php
$del = "DELETE FROM profiles WHERE user = '$loginuser'AND profile_name = '$field'";
?>
<?php
if (isset($_POST ['delete'])) { 
foreach ($_POST ['delete'] as $field)
mysql_query($del);
}
else
echo "No items selected"; 
?>

I changed the name of the checkboxes back to delete[] hoping that it would now read as an array but same error. :bemused:

[tsinka]

Try this one

    <form action="<?PHP echo $_SERVER["PHP_SELF"]; ?>" method="POST">
<?php
    // Make Connection
    mysql_connect("localhost", "user", "pass") or die(mysql_error());
    mysql_select_db("database") or die(mysql_error());
    $loginuser = $_SESSION["user_login"];
    // Get my result from the "profiles" table
    $sql = mysql_query("SELECT profile_name FROM profiles WHERE user='$loginuser'") or die(mysql_error());
    while ($row = mysql_fetch_assoc($sql)) {
    print "<tr>\n";
    print "\t<td><input type=\"checkbox\" name=\"delete[]\" value='" . $row['profile_name'] . "' /></td>\n";
    foreach ($row as $field)
    print "\t<td>$field</td>\n";
    print "</tr><br />\n";
}
?>
    <tr><td>&nbsp;</td><td><input name="deleteit" type="submit" value="Delete"></td></tr>
    </form>
<?php
    if (isset($_POST ['deleteit'])) { 
        if (is_array($_POST['delete'])) {
            foreach ($_POST ['delete'] as $value) {
                $del = "DELETE FROM profiles WHERE user = '$loginuser' AND profile_name = '".$value."'";
                mysql_query($del) or die('SQL error: '.mysql_error());
            }
        } else {
            echo "invalid data";
        }
    } else {
        echo "No items selected"; 
    }
?> 

You need to move the delete query inside the foreach loop.
Second, the submit button and the checkbox input had the same name.

Thomas