[Resolved] OO PHP Architecture Problem

ppowell

I can't possibly reproduce the code for this as the 2 classes in question are about 1500 lines each and condensing is in this case impossible due to algorithmic logic dependencies.

Let's say you have a Class A and a Class B. Let's say Class A is like this:

class A {

  var $b;

  function A() {
   $this->b =& new B();
  }

  function getOtherUniqueStuff() {
   return "this is other unique stuff";
  }

  function displayStuffFromB() {
   $html = $this->b->displayStuff('isFromA');
  }

}

-----------------------------------------------------------------

Basically, Class A will display stuff from a locally instantiated B object property.

Here is class B:

class B {

  function B() {}

  function displayStuff($isFromA = false) {
   $html = "blah blah blah blah";
   if ($isFromA) {
    $html .= A::getOtherUniqueStuff();
   }
   return $html;
  }

}

------------------------------------------------------------------

Everything is fine and dandy, except in PHP 4.3.2 I get the following error:

Fatal error use of undefined function getotheruniquestuff

The line that produces that error is:

$html .= A::getOtherUniqueStuff();

This is why I need to get a better grip on OO PHP, I can't get past this problem and have no solution, can someone please help?

Thanx
Phil

bubblenut

There is no reason why that should not work. How have you defined that function in Class A? (just need the function line)
I have checked the bug search on php.net and can find nothing related for the version you mention.

ppowell

I gave up and had each class method call the other method statically, preserving the identity of $this everytime.

Phil

bubblenut

YAY! My sentiments exactly. If at first it doesn't work, slap it with a dirty hack 😃

On the other hand, I think I know where the problem may be. Using A::method() will call the method on the uninstantiated class rather than the object. I get the impression you want a method of the particular object which is calling this method to be called. If this is the case you could pass a reference to the original object to the method and then call the methon on that passed reference. Understand?:queasy: I think this is going to be better explained with a bit of code.

class A {

  var $b;

  function A() {
   $this->b =& new B();
  }

  function getOtherUniqueStuff() {
   return "this is other unique stuff";
  }

  function displayStuffFromB() {
   $html = $this->b->displayStuff($this);
  }

}


class B {

  function B() {}

  function displayStuff(&$ref = false) {
   $html = "blah blah blah blah";
   if ($ref && is_a($ref, 'A')) {
    $html .= $ref->getOtherUniqueStuff();
   }
   return $html;
  }

}

You're passing a reference to the object of class A which is calling the display method of B, and then using that reference to call the method of the particular instance of A which was originally calling this method.

ppowell

Yep something like that. I wound up calling them both unsubstantiated and that so far solved everything, although your architecture appears more OO than mine and I will have to look into it.

Phil