Parse Error

jeaniem

Hi,

I'm new to PHP and have no experience whatsoever with it. I'm using OSCommerce as my shopping cart and I get this error in index.php

Parse error: parse error, unexpected T_ELSEIF in /home/muzicbar/public_html/ecommerce/os/catalog/includes/languages/english/index.php on line 22

This is the Code in index.php

<?php

define('TEXT_MAIN', 'MUSIC BARN');
define('TABLE_HEADING_NEW_PRODUCTS', 'New Products For %s');
define('TABLE_HEADING_UPCOMING_PRODUCTS', 'Upcoming Products');
define('TABLE_HEADING_DATE_EXPECTED', 'Date Expected'); if ( ($category_depth == 'products') || (isset($HTTP_GET_VARS['manufacturers_id'])))
define('HEADING_TITLE', 'Lets See What We Have Here');
define('TABLE_HEADING_IMAGE', '');
define('TABLE_HEADING_MODEL', 'Model');
define('TABLE_HEADING_PRODUCTS', 'Product Name');
define('TABLE_HEADING_MANUFACTURER', 'Manufacturer');
define('TABLE_HEADING_QUANTITY', 'Quantity');
define('TABLE_HEADING_PRICE', 'Price');
define('TABLE_HEADING_WEIGHT', 'Weight');
define('TABLE_HEADING_BUY_NOW', 'Buy Now');
define('TEXT_NO_PRODUCTS', 'There are no products to list in this category.');
define('TEXT_NO_PRODUCTS2', 'There is no product available from this manufacturer.'); define('TEXT_NUMBER_OF_PRODUCTS', 'Number of Products: ');
define('TEXT_SHOW', '<B>Show:</B>');
define('TEXT_BUY', 'Buy 1');
define('TEXT_NOW', 'Now');
define('TEXT_ALL_CATEGORIES', 'All Categories');
define('TEXT_ALL_MANUFACTURERS', 'All Manufacturers'); } elseif ($category_depth == 'top'){
define('HEADING_TITLE', 'What\'s New Here?'); } elseif ($category_depth == 'nested'){
define('HEADING_TITLE', 'Categories');
?>

Line 22 is:

define('TEXT_ALL_MANUFACTURERS', 'All Manufacturers'); } elseif ($category_depth == 'top'){

Any help will be greatly appreciated.

Thanks,
Jeanie

tsinka

Hi,

maybe a missing curly brace after

if ( ($category_depth == 'products') || (isset($HTTP_GET_VARS['manufacturers_id'])))

Add one so that it looks like

if ( ($category_depth == 'products') || (isset($HTTP_GET_VARS['manufacturers_id']))) {

Thomas

jeaniem

Thanks tsinka,

That seemed to have fixed that error, but now I have a new error:

Parse error: parse error, unexpected T_ELSEIF in /home/muzicbar/public_html/ecommerce/os/catalog/includes/languages/english/index.php on line 22

TheDefender

You posted the same error... Did Thomas's suggestion fix the original error or are we dealing with a different error?

tsinka

Ok,

there was another error. You need to escape single quotes inside strings that are enclosed by single quotes (or use double quotes).

<?php

define('TEXT_MAIN', 'MUSIC BARN');
define('TABLE_HEADING_NEW_PRODUCTS', 'New Products For %s');
define('TABLE_HEADING_UPCOMING_PRODUCTS', 'Upcoming Products');
define('TABLE_HEADING_DATE_EXPECTED', 'Date Expected'); 

if (($category_depth == 'products') || isset($HTTP_GET_VARS['manufacturers_id'])) {
    define('HEADING_TITLE', 'Lets See What We Have Here');
    define('TABLE_HEADING_IMAGE', '');
    define('TABLE_HEADING_MODEL', 'Model');
    define('TABLE_HEADING_PRODUCTS', 'Product Name');
    define('TABLE_HEADING_MANUFACTURER', 'Manufacturer');
    define('TABLE_HEADING_QUANTITY', 'Quantity');
    define('TABLE_HEADING_PRICE', 'Price');
    define('TABLE_HEADING_WEIGHT', 'Weight');
    define('TABLE_HEADING_BUY_NOW', 'Buy Now');
    define('TEXT_NO_PRODUCTS', 'There are no products to list in this category.');
    define('TEXT_NO_PRODUCTS2', 'There is no product available from this manufacturer.'); 
    define('TEXT_NUMBER_OF_PRODUCTS', 'Number of Products: ');
    define('TEXT_SHOW', '<B>Show:</B>');
    define('TEXT_BUY', 'Buy 1');
    define('TEXT_NOW', 'Now');
    define('TEXT_ALL_CATEGORIES', 'All Categories');
    define('TEXT_ALL_MANUFACTURERS', 'All Manufacturers'); 
} else if ($category_depth == 'top') {
    // Hint: you need to escape the single quote inside the value or 
    // use double quotes
    define('HEADING_TITLE', "What's New Here?"); 
} else if ($category_depth == 'nested') {
    define('HEADING_TITLE', 'Categories');
}
?>

Do you use an editor that supports syntax highlighting ? That will help alot.

Thomas

jeaniem

Thanks again! I'm really grateful for the time and energy you have put into helping me with this little problem. It's also nice when you come to a forum for help, without someone belittling you.

Defender, you're right, I posted the same error, which I thought was a different error initially. Good eye.

Jeanie.

P.S. What editor can I use, besides notepad?

TheDefender

Search these threads... I think there is a sticky somewhere. This topic has been covered exhaustively. I personally use Dev-PHP which has good syntax highlighting. (And as Thomas pointed out, it makes a world of difference. You will cut your debugging time in half or more, just by scanning docs for syntax color changes.)

tsinka

I think this thread with over 250 replies covers the most important editors.

I just started to test eclipse with the PHPEclipse plug-in (and the subclipse/subversion plug-in).

It has some nice features that I only saw in the commercial Maguma Workbench so far.

The 'downside' is that Eclipse is a Java based application so you need a rather well equipped workstation.

Besides that PHPEclipse has some really nice features. The one thing I'm missing a little bit is phpdoc functionality but that's not a really big problem.

Thomas