Simple? Select Query Question And OR

rr1024

Hello,

In one table row called Profiles_Shoppers I plan to have up to 5 IP address fields.
What I'm wondering is if I can make a query like this or if this would be proper to do this way.

$p_arr = db_arr( "SELECT ID, NickName, Password From Profiles_shoppers WHERE IPAddress1 = $IP OR IPAddress2 = $IP OR IPAddress3 = $IP OR IPAddress4 = $IP OR IPAddress5 = $IP" );

Basically I'm sending them a cookie as soon as they hit my shopping page, I'll create a temporary ID nickname etc for the cookie but if the user doesn't by something I don't want to force them to login if all they want to do is look around and if they have come back say within a week or two I don't want to create a new table row for them, so I want to check to see if their IP has been here before.

I just want to know if using the OR in the WHERE part of a select statement would work? of if it's poper to do?

bretticus

well, it looked okay at a fast glance.

However, I woudl recommend that you have a seperate table just for visits (Profiles_shoppers_ips or something.) since Profiles_shoppers has an ID field, you can create a table with a foriegn key corresponding to ID and the ip address. Then you will never be limited to five ips. In most instances, you will probably never even get 5 ips so this actually will save space on your harddrive and it's a much sounder (more normalized) approach to database design.

TheDefender

Another thought to the IP thing is what happens if a user is behind a firewall like at a library or a company like mine. If one person entered the site, then the next person (even if at a different computer) would start where the other left off, because it's the firewall's IP that is broadcast and not the internal IP Address.

Cookies and Sessions are a better way to go all around.

rr1024

I am using a cookie, basically my issue is the software wasn't designed to do this. It's dating software that's being turned in to Ecommerce softare...lol

So, what I'm doing is detecting bots or visitors, if it's a visitor I log thier IP and issue a cookie with their ID which then will allow them to browse and search. If it's a bot I do not issue a cookie.

I think I'll be doing something like what you mentioned above....Very good idea.

I hope one day I'll get good enough to offer advice on php like you guys do....It's soooo great to have a place like phpbuilder.

SumitGupta

Hi,

I would like to suggest you on emore thing in this....

Since you are using the IP address you better make a SessionId as you can see the ine in your browser for PHPbuilder has s=xxxx this is session id ...and store that in data base and just create set the cookie in user computer for particular Time say for 1 hr..and do check it with database session id...It also help you in firewall case...and only one login to one user at a time...One login name is not use by two user and help you in your earning....

🙂