[Resolved] Unset array key and delete image. 95% works

Kudose

Hello all. In this code below, a string is exploded into an array, a specified key is unset, the related image is deleted, the array is imploded, finally, the database is updated.

Now, this works for EVERY id but 0.

Could someone explain why? 0 is the first key in the array, but I don't see why that would affect it.

$id = $_GET['id'];
		$del_img = $_GET['del'];
		$images = $myDb->dbFetch("SELECT img1 FROM ".$prefix."inventory WHERE uid='".$id."'");
		$images = explode(",", $images[0]['img1']);
		$image_del = $images[$del_img];
		unset($images[$del_img]);
		$images = implode(",", $images);
		if(($myDb->dbQuery("UPDATE ".$prefix."inventory SET img1='".$images."' WHERE uid='".$id."'")) !== FALSE){
			if(file_exists($tb_config[0]['dir']."imgs/".$image_del)){
				@unlink($tb_config[0]['dir']."imgs/".$image_del);
				@unlink($tb_config[0]['dir']."imgs/thumb_".$image_del);
				echo 'Image removed.';
			} else {
				echo 'Could not find file to delete.';
			}
		} else {
			echo 'Could not remove image from database.';
		}

No errors, no ouput if id = 0, if id > 0 then everything works with output.

TIA.

devinemke

is there in fact an ID of "0" in your table? if so that would pretty unusual (i'm assuming that ID in this case is an auto incrementing integer).

Kudose

Sorry, I think I typed something wrong in the explaination, $del_img is the variable holding the array key to delete. $id is the unique id of the row.

So in essence, it is pulling row 26, then trying to delete array key 0 of the img1 column.

If the $del_img (array Key number) is not 0, it all goes as planned. Otherwise I dont get any output at all.

Weedpacket

Do you check that $GET['del'] is empty or not before you use it? $GET['del'] would be considered empty if it contained the value 0. If that is the case, then using isset() might be the better choice.

I'd also suggest looking at your database design. Instead of using a single field to store a whole list of values, have another table to store each value in a single record. A record would have two fields: one for the value itself, and one recording the uid of the record it's associated with in the inventory table.

Selection is straightforward enough:
"Select image from images_table where uid=$id"

Deletion is then not that much more complicated:
"Delete from images_table where uid=$id and image=$del_img"

Kudose

Weedpacket was right, it was reading 0 as false/null instead of an integer. I added an if isset($_GET['del']) and it works now.

Thanks Weedpacket.