File upload problem.

micglu

I'm trying to upload a file to an ftp server. I am able to connect to the ftp site but when I try to use the 'ftp_put()' function it fails and I don't know why because the error message doesn't give me any info. The code looks something like this:

##########################

<?php
// login with username and password
$login_result = ftp_login($conn_id, $ftp_user_name, $ftp_user_pass);

// check connection
if ((!$conn_id) || (!$login_result)) {
echo "FTP connection has failed!";
echo "Attempted to connect to $ftp_server for user $ftp_user_name";
exit;
} else {
echo "Connected to $ftp_server, for user $ftp_user_name <br />";
}

$destination_file='smiley_pic.gif';
$source_file = 'C:\myWeb\pics\smiley2.gif';

if (ftp_chdir($conn_id, "pictures")) {
echo "Current directory is now: " . ftp_pwd($conn_id) . "\n";
} else {
echo "Couldn't change directory\n";
}

echo "<hr />";
echo "Current directory: " . ftp_pwd($conn_id) . "<br />\n";
echo "destfile = $destination_file <br />";
echo "srcfile = $source_file";
echo "<hr />";

// upload the file
$upload = ftp_put($conn_id, $destination_file, $source_file, FTP_BINARY);

// check upload status
if (!$upload)
{
echo "FTP upload has failed!";
}
else
{
echo "Uploaded $source_file to $ftp_server as $destination_file";
}

// close the FTP stream
ftp_close($conn_id);
?>

#########################

The output my code generates is:

Connected to ftp.servername.com, for user myusername

Current directory is now: /picture

Current directory: /picture
destfile = smiley_pic.gif

srcfile = C:\myWeb\pics\smiley2.gif

FTP upload has failed!

#########################

Please help me. Why is my FTP upload failing?

Yamakazi

Are you sure your webserver can read your smile.gif on your local machine?

Check the rights of the file:
C:\myWeb\pics\smiley2.gif

micglu

Other than verifying the file is on my machine I am not sure what to do (I am running Windows XP). I want people to be able to upload pictures from any computer so there shouldn't be any fancy settings required on the client side.

Yamakazi

Well in that case your script will never work unless everybody is running a webserver and php at home.

What your script does is the following. it takes a file that is on the webserver and FTP's it to another server.

What you want is transfer a file from ANY client to your webserver?

Do this:

<form action="Upload.php" method="post" ENCTYPE="multipart/form-data">
  <input type="file" name="datafile">
  <input type="submit">
</form>

This will create a page with a file selecter and a submit button.

Now a simple parse script Upload.php:

if(is_uploaded_file($_FILES['datafile']['tmp_name'])){
move_uploaded_file($_FILES['datafile']['tmp_name'],"Images/{$_FILES['datafile']['name']}");
}

(Forums places carriage returns on the wrong place. Sort this out yourself)

Et voila.

File uploaded.

micglu

Okay, I get it now.

That worked, thanks so much!