[Resolved] Link to WHERE

MichaelHe

Hi again

I have a database site where i list some songs... like this

<table width="500" border="0">
<tr>
<td width='200'><?echo $row["Title"]."</td>
<td width='200'>".$row["Composer"]."</td>
<td width='100'>".$row["Style"]."</td>
</tr>
</table>";

Now I have made another site with additional infomation on the Songs...
So I need to be able to click on a Title, and then it should go to the other
site and list the additional information on the song i clicked..

So I guess the other site should have a
$sql = "SELECT * FROM Music WHERE Title=??????????? ";

How do I get the clicked title name in my WHERE line on the other site..

best
Michael

hmemnon

heheh, good to see you again

You can try something like this:

<?
$title=$row['Title'];
?>
<table width="500" border="0"> 
<tr> 
<td width='200'><?echo "<a href=\"yoursitehere?title=$title\">$title</a>";?></td> 
<td width='200'><? echo $row['Composer'];?></td> 
<td width='100'><? echo $row['Style'];?></td> 
</tr> 
</table>

Then in your other site just check it with this:

if($_GET['title']){
  $title=$_GET['title']; //use some validation in $title to prevent injection attacks (an array with all your titles for ex, used then with in_array() to check if present
  $qry=mysql_query("SELECT * FROM table WHERE title='$title'");
}

Alternatly you can use forms and $_POST to submit the songs title transparently...

Cheers

MichaelHe

Thank you once again..

You are a little more awake today i see.. :o)
It worked the first time 😃 😃

What did you mean by
validation in $title to prevent injection attacks ??

MichaelHe

OK.. now I'm getting really annoying.. :o))

If it was the composer I needed a link to...

Then I would do like this..

$comp=$row['Composer'];
<?echo "<a href=\"Composer.php?Composer=$comp\">$comp</a>";

and then

if($GET['Composer']){
$comp=$GET['Composer'];
$result = mysql_query("select * from Music WHERE Composer='$comp'");

But what if...
I have 2 diffent composer fields.. Composer1 and Composer2..
This is if a song is written by 2 different composers..
But I still need to be able to click on both the first and the second composer seperatelly..

Is it then:

$comp1=$row['Composer1'];
$comp2=$row['Composer2'];
<?echo "<a href=\"Composer.php?Composer1=$comp1\">$comp1</a>";
echo "<a href=\"Composer.php?Composer2=$comp2\">$comp2</a>";

And then

if($GET['Composer1']){
$comp1=$GET['Composer1'];
$result = mysql_query("select * from Music WHERE Composer1='$comp1'");

if($GET['Composer2']){
$comp2=$GET['Composer2'];
$result = mysql_query("select * from Music WHERE Composer2='$comp2'");

Will it then automaticly go to the next IF line if it's the second composer I have clicked.. ???

hmemnon

<?
$comp1=$row['Composer1']; 
$comp2=$row['Composer2']; 
<?echo "<a href=\"Composer.php?Composer=$comp1\">$comp1</a>"; 
echo "<a href=\"Composer.php?Composer=$comp2\">$comp2</a>"; 



if($_GET['Composer']){ 
$comp=$_GET['Composer']; 
$result = mysql_query("select * from Music WHERE Composer='$comp'"); 

}
?>

This way should do it

Cheers mate, feel free to ask whatever you like

MichaelHe

No..

It still won't find it..
Because if I click on the second composer it will in the lines

if($GET['Composer']){

$comp=$GET['Composer'];

look for that name in the first composer row, and that name isn't there if the composer is only listed in the second row...

hmemnon

Ops, misread your post, didnt' noticed you had 2 composer fields 😃 .
That way, the option you gave is completly functional (as you may already know :p )

Cheers

MichaelHe

The thing is that it doesn't work. 😕

If I write
$comp1=$row['Composer1'];
$comp2=$row['Composer2'];
<?echo "<a href=\"Composer.php?Composer1=$comp1\">$comp1</a>";
echo "<a href=\"Composer.php?Composer2=$comp2\">$comp2</a>";

and

if($GET['Composer1']){
$comp1=$GET['Composer1'];
$result = mysql_query("select * from Music WHERE Composer1='$comp1'");

if($GET['Composer2']){
$comp2=$GET['Composer2'];
$result = mysql_query("select * from Music WHERE Composer2='$comp2'");

it works a little funny..
Either I press the first composer or the second it doesn't write anything..
If I write an echo $comp1; echo $comp2; line between the 2 if lines it writes the first composer if clicked, pu not the second, and if I write the echo line after the second IF line it doesn't write anything..

hmemnon

wow, im getting confused here...
If you click in composer1, the composer2 $_GET var isn't available, so it wont appear anywhere (goes both ways)...
Now what i find strange is when you echo $composer1 after the IFs and it wont show nothing.
Or i am missing something terribly obviously here or there's something else wrong with your code,

Can you post full code for your scripts and a link to page if you may?
Cheers

MichaelHe

Sure thing..

In the first file i write
echo "<br>Composer1: <a href=\"Composer.php?Composer1=$comp1\">$comp1</a>";
echo "<br>Composer2: <a href=\"Composer.php?Composer2=$comp2\">$comp2</a>";

So if I click the name in the Composer1 field it should transfor the data in $comp1 to the other page..
And if I click the name in the Composer2 field it should transfor the name in $comp2...

On the other page i then write

if($GET['Composer1']){
$comp1=$GET['Composer1'];
$result = mysql_query("select * from Titler WHERE Composer1='$comp1'");

if($GET['Composer2']){
$comp2=$GET['Composer2'];
$result = mysql_query("select * from Titler WHERE Composer2='$comp2'");

while ($row = mysql_fetch_array($result)) {

Then my table with <? echo $row['Title'];?> and so on
;
}}}
mysql_close($conn);
?>

neerav

I think the problem lies in your nesting of the if and the while. When reformatted, you have:

if($_GET['Composer1']) { 
	$comp1=$_GET['Composer1']; 
	$result = mysql_query("select * from Titler WHERE Composer1='$comp1'"); 

if($_GET['Composer2']){ 
	$comp2=$_GET['Composer2']; 
	$result = mysql_query("select * from Titler WHERE Composer2='$comp2'"); 

	while ($row = mysql_fetch_array($result)) { 

	}
}
}

when I think you really want:

if($_GET['Composer1']) { 
	$comp1=$_GET['Composer1']; 
	$result = mysql_query("select * from Titler WHERE Composer1='$comp1'"); 
} 

if($_GET['Composer2']){ 
	$comp2=$_GET['Composer2']; 
	$result = mysql_query("select * from Titler WHERE Composer2='$comp2'"); 
}

while ($row = mysql_fetch_array($result)) { 

}

Cailean

You may have found your solution but I thought I'd make a suggestion to make your life a little easier, maybe.

In composer.php, you're only displaying one compser at a time, right? So you only need one composer in the query string: ?composer=$composer

On the first page, the URLs would look like:

$comp1=$row['Composer1'];
$comp2=$row['Composer2'];
echo "<a href=\"Composer.php?composer=$comp1\">$comp1</a>";
echo "<a href=\"Composer.php?composer=$comp2\">$comp2</a>";

in compser.php you just need to pull $_GET['composer'] from the query string and pull the composer's info from the DB.

MichaelHe

OK..

But in the WHERE statement, it have ti searche both in Composer1 and Composer2...

If my name if written on a song in the field Composer1
And my name on another song is written in the field Composer2
it should list both songs... ??

So when I have the name transfered to the Composer.php file how can I get the WHERE line to look in both Composer1 and Composer2..???

Cailean

the query would looke like:

$composer=$_GET['Composer']; 
    $result = mysql_query("select * from Titler WHERE Composer1='$composer' OR Composer2='$composer' ");

MichaelHe

SUPER.. It works.. Finally... what would I do without your help...

Thank you both of you...
Now I think I have all the codes I need to finish the site..