switch, include

[10010]

Hi

Can someone check if there is any errors in this PHP-code?

<?

$sSida=$_GET["sida"];

$sBild=$GET["bild"];
$sFilm=$GET["film"];

switch ($sSida)

{

case 1: include("start.php"); break;

case 2: include("skiv-samlingen.php"); break;

case 3: include("dvd-samlingen.php"); break;

case 4:

if ($sBild=="1")
{

include("birgitta.php");

}

else

if ($sBild=="2")
{

include("ingela.php");

}

else

if ($sBild=="3")
{

include("ingela2.php");

}

else

if ($sFilm=="1")
{

include("michel-mov.php");

}

else

{

include("nagra_bilder.php");

}

break;

case 5: include("kontakta_mig.php"); break;

case 6: include("info.php"); break;
case 7: include("gb.php"); break;

}

?>

Kind regards: The Newbie 🙂

[laserlight]

You should check the incoming variables with isset() or empty() before using them.

<?php
//check that $_GET["sida"] exists
if (isset($_GET["sida"])) {
	//initialise $sSida
	$sSida = $_GET["sida"];
	//initialise $sBild
	if (isset($_GET["bild"]))
		$sBild = $_GET["bild"];
	else
		$sBild = '';
	//initialise $sFilm
	if (isset($_GET["film"]))
		$sFilm = $_GET["film"];
	else
		$sFilm = '';

switch ($sSida)
{
case 1: include "start.php";
	break;
case 2: include "skiv-samlingen.php";
	break;
case 3: include "dvd-samlingen.php";
	break;
case 4:
	switch ($sBild)
	{
	case 1: include "birgitta.php";
		break;
	case 2: include "ingela.php";
		break;
	case 3: include "ingela2.php";
		break;
	default:
		if ($sFilm == 1)
		{
			include "michel-mov.php";
		}
		else
		{
			include "nagra_bilder.php";
		}
	}
	break;
case 5: include "kontakta_mig.php";
	break;
case 6: include "info.php";
	break;
case 7: include "gb.php";
	break;
}
}
?>

[10010]

OK. Thanks a lot "laserlight"!

What is the difference between the 2 code examples?

It seems to work exactly the same.

[laserlight]

What is the difference between the 2 code examples?

Testing for incoming variables ensures that variables are only used when they exist.

[10010]

Ok. But I think I need your help again 🙂

Tried to extend case 5, but I get an error.

(unexpected T_ELSE)

<?php

if (isset($_GET["sida"])) {

$sSida = $_GET["sida"];

if (isset($_GET["bild"]))
    $sBild = $_GET["bild"];
else
    $sBild = '';

if (isset($_GET["film"]))
    $sFilm = $_GET["film"];
else
    $sFilm = '';

if (isset($_GET["mail"]))
    $sMail = $_GET["mail"];
else
    $sMail = '';

switch ($sSida)
{
case 1: include "start.php";
    break;
case 2: include "skiv-samlingen.php";
    break;
case 3: include "dvd-samlingen.php";
    break;
case 4:
    switch ($sBild)
    {
    case 1: include "birgitta.php";
        break;
    case 2: include "ingela.php";
        break;
    case 3: include "ingela2.php";
        break;
    default:
        if ($sFilm == 1)
        {
            include "michel-mov.php";
        }
        else
        {
            include "nagra_bilder.php";
        }
    }
    break;
case 5:
    switch ($sMail)
    {
    case skickat: include "tack.php";
        break;
    default:
        }
        else
        {
            include "kontakta_mig.php";
        }
    }
    break;
case 6: include "info.php";
    break;
case 7: include "gb.php";
    break;
}

}
?>

[10010]

Please 🙂