Thumbnail & Image Manipulation?

[bpat1434]

Hi guys, having a bit of trouble here.

Here's what I'm trying to do:
User uploads a photo
PHP script takes it and resizes it twice (once to a thumbnail [75xXX or XXx75] and once to a larger image [500x?? or ??x500])
PHP Script stores it binarily in database Blob field

Trouble I'm having is that the script doesn't resize the image. I'm using exif_thumbnail but it outputs that it's not a valid resource. Any ideas as to the best way to resize an uploaded image twice?

Here's my code:

$tempname = $_FILES[$photoi]['tmp_name'];
if(is_uploaded_file($tempname)){
		$year = $_REQUEST[$yeari];
		$cat = $_REQUEST[$cati];
		$event = $_REQUEST[$eventi];

	$photo = exif_thumbnail($tempname, 500, $type2);
	if(!$photo){
		error('4');
	}
	else{
		error('5');
	}
	$thumb = exif_thumbnail($tempname, 75, 75, $type);
	if(!$thumb){
		error('6');
	}
	else{
		error('7');
	}

	$q1 = "INSERT INTO `Photos` (pyid, pcid, peid, Thumbnail, Photograph) VALUES ('$year', '$cat', '$event', '$thumb', '$photo')";
	$r1 = mysql_query($q1);
	if(!$r1 || $r1 === FALSE){
		error('3');
	}
	else{
		echo "Query Error: ".mysql_error()."<br />";
	}
}

[Weedpacket]

[man]exif_thumbnail[/man]
exif_thumbnail -- Retrieve the embedded thumbnail of a TIFF or JPEG image

Nothing in that page says anything about resizing. You're probably after [man]imagecopyresampled[/man].

P.S. Love your error messages.

[bpat1434]

Great. That helps. But now I can't insert into the database. Here's what I have so far:

$twidth = 75;
$lwidth = 500;
if(is_uploaded_file($tempname)){
		$year = $_REQUEST[$yeari];
		$cat = $_REQUEST[$cati];
		$event = $_REQUEST[$eventi];

	list($orig_width, $orig_height) = getimagesize($tempname);
	$theight = (int) (($twidth/$orig_width)*$orig_height);
	$lheight = (int) (($lwidth/$orig_width)*$orig_height);

	$photo_p1 = imagecreatetruecolor($lwidth, $lheight);
	$photo_p = imagecreatefromjpeg($tempname);
	if(imagecopyresampled($photo_p1, $photo_p, 0, 0, 0, 0, $lwidth, $lheight, $orig_width, $orig_height) === FALSE){
		error('4');
	}
	else{
		$photo = imagejpeg($photo_p1, $tempname, 100);
		error('5');
	}
	$thumb_p1 = imagecreatetruecolor($twidth, $theight);
	$thumb_p = imagecreatefromjpeg($tempname);
	if(imagecopyresampled($thumb_p1, $thumb_p, 0, 0, 0, 0, $twidth, $theight, $orig_width, $orig_height) === FALSE){
		error('6');
	}
	else{
		$thumb = imagejpeg($thumb_p1, $tempname, 100);
		error('7');
	}

	// Prep images for insertion
	$thumb2 = mysql_escape_string(file_get_contents($thumb));
	$photo2 = mysql_escape_string(file_get_contents($photo));

	$q1 = "INSERT INTO `Photos` (pyid, pcid, peid, Thumbnail, Photograph) VALUES ('$year', '$cat', '$event', '$thumb2', '$photo2')";
	$r1 = mysql_query($q1);
	if(!$r1 || $r1 === FALSE){
		// Adding image to the database Failed.
		error('3');
	}
	else{
		echo "Success!!";
	}

It says that it can't get the file contents of (1)

get_file_contents(1) failed

Am I calling it wrong? I'm trying to use the images I create after the copy to be inserted into the databse.

~Brett

[Skull]

file_get_contents is not needed, as there is no file to get contents from. Just remove file_get_contents on both lines and it should work fine.

[bpat1434]

Okay, so after running into problems with the database insertion of images, I'm using a work around to actually host them as images on the site (in a folder) and call them as regular images. So far I've got the creation of the directories down (easy enough...).

Now my problem is renaming and MOVING the files.

Here's what I'm using:

<?php
#####################
## Manipulate the image
#####################
if(is_uploaded_file($tempname)){
		$year = $_REQUEST[$yeari];
		$cat = $_REQUEST[$cati];
		$event = $_REQUEST[$eventi];

	list($orig_width, $orig_height) = getimagesize($tempname);
	$theight = (int) (($twidth/$orig_width)*$orig_height);
	$lheight = (int) (($lwidth/$orig_width)*$orig_height);

	$photo_p1 = imagecreatetruecolor($lwidth, $lheight);
	$photo_p = imagecreatefromjpeg($tempname);
	if(imagecopyresampled($photo_p1, $photo_p, 0, 0, 0, 0, $lwidth, $lheight, $orig_width, $orig_height) === FALSE){
		error('4');
	}
	else{
		$photo = imagejpeg($photo_p1, $tempname, 100);
		error('5');
	}
	$thumb_p1 = imagecreatetruecolor($twidth, $theight);
	$thumb_p = imagecreatefromjpeg($tempname);
	if(imagecopyresampled($thumb_p1, $thumb_p, 0, 0, 0, 0, $twidth, $theight, $orig_width, $orig_height) === FALSE){
		error('6');
	}
	else{
		$thumb = imagejpeg($thumb_p1, $tempname, 100);
		error('7');
	}

/*
** Cut from here is code to use an FTP
** function to create the folders so I 
** am the owner, and not "nobody"
*/

/* 153 */ if(is_dir($tdir)){
/* 154 */    if(rename($thumb, $tdir."/".$nxtfile.".jpg") === FALSE){
/* 155 */        error('8');
                   }
/* 157 */    else{
/* 158 */        $thumb2 = "http://www.ridgeswimclub.org/".$dir."/".$nxtfile.".jpg";
/* 159 */        error('9');
			}
		}
		else{
			$create_thumb_dir = FtpMkdir($dir, $tdir);
			if($create_thumb_dir === false){
				echo $_dir['Event']." thumbnail folder creation failed.";
			}
			else{
				echo $_dir['Event']." thumbnail folder created.";
			}
			if(rename($thumb, $dir."/".$nxtfile) === FALSE){
				error('8');
			}
			else{
				error('9');
			}
		}

	if(is_dir($dir)){
		if(rename($photo, $dir."/".$nxtfile.".jpg") === FALSE){
			error('8');
		}
		else{
			$photo2 = "http://www.ridgeswimclub.org/".$dir."/".$nxtfile.".jpg";
			error('9');
		}
	}
	else{
		$create_event_dir = FtpMkdir($cdir, $dir);
		if($create_event_dir === false){
			echo $_dir['Event']." folder Creation failed.<br />";
		}
		else{
			echo $_dir['Event']." folder Created.<br />";
		}
		if(rename($photo, $dir."/".$nxtfile.".jpg") === FALSE){
			error('8');
		}
		else{
			error('9');
		}
	}

The only trouble is the actual manipulation of the images. What am I missing?

Output during testing:
Warning: rename(1,/home/ridgeswi/public_html/photographs/2004/Lifeguards/Catie_Easterday/thumbs/0001.jpg): No such file or directory in /home/ridgeswi/public_html/main/scripts/photos/upload.php on line 154
Renaming the file failed!!

Warning: rename(1,/home/ridgeswi/public_html/photographs/2004/Lifeguards/Catie_Easterday/0001.jpg): No such file or directory in /home/ridgeswi/public_html/main/scripts/photos/upload.php on line 173
Renaming the file failed!!

Any help is appreciated.

Also, should this be in a new thread? I dont' think so, but just let me know....

~Brett

[Weedpacket]

Okay, so after running into problems with the database insertion of images, I'm using a work around to actually host them as images on the site (in a folder) and call them as regular images. So far I've got the creation of the directories down (easy enough...).

That's actually the method most people use anyway for simplicity.

Now my problem is renaming and MOVING the files.

Well, I still have very little idea what's going on (and your error messages are not helping), but I do note that you call [man]imagejpeg[/man], saving $thumb_p1 to the file named $tempfile and putting the return value (a boolean stating whether the call succeeded or not) into $thumb. Then you error('7'). A couple of lines later, you try and rename the file named $thumb - but $thumb isn't a file name.

Really, you're making this hugely more complicated than it needs to be.

if(is_uploaded_file($tempname))
{
	$original_dimensions = getimagesize($tempname);
	if($original_dimensions==false || $original_dimensions[2]!=2)
	{
		// the file wasn't recognised as a JPEG.
		die(); // Depending on your program architecture, you want to do
		       //something more elegant than this.
	}
	$original_width = $original_dimensions[0];
	$original_height = $original_dimensions[1];
	$image_is_tall = ($original_height>=$original_width);
	$original_image = imagecreatefromjpeg($tempname);
	$small_image_height = 75;
	$small_image_width = ceil($original_image_width*75/$original_image_height);
	$large_image_height = 500;
	$large_image_width = ceil($large_image_width*500/$large_image_height);
	if($image_is_tall)
	{
		$t = $small_image_height;
		$small_image_height = $small_image_width;
		$small_image_width = $t;
		$t = $large_image_height;
		$large_image_height = $large_image_width;
		$large_image_width = $t;
	}
	$small_image = imagecreatetruecolor($small_image_width, $small_image_height);
	$large_image = imagecreatetruecolor($large_image_width, $large_image_height);
	imagecopyresampled($small_image, $original_image,0,0,0,0,
		$small_image_width, $small_image_height, $original_image_width, $original_image_height);
	imagecopyresampled($large_image, $original_image,0,0,0,0,
		$large_image_width, $large_image_height, $original_image_width, $original_image_height);
	// Now somewhere in there you're presumably making names for the new image files.
	// Put the code for making those names here. Add path information, noting
	// that http URLs are unacceptable substitutes for file paths.
	imagejpeg($small_image, $small_image_name, 100);
	imagejpeg($large_image, $large_image_name, 100);
	// Who needs rename()?
}

I skipped most of the error checking because I don't know what you would be
doing in each case, or what those numbers meant (suggestion: look up [man]define[/man]).

[bpat1434]

Thanks for the help.

I used your suggestions and changed the following:

-- Error codes to define()'s
-- Modified the Path Names
-- Used your code you supplied

Perhaps it was my understanding of the functions that mislead me. Thanks for your help. It works now. Thanks a lot!!

~Brett