Simple MySQL Insert Problem

[alcibar]

Hello, I have a mysql insert query that will insert multiple row in one submit. My problem is that it only insert the last value. Here's my current code:

<?php
if(isset($_POST['add'])) 
{ 
    $unique = $_POST['unique'];
    $name = $_POST['name'];

// child table
$childname1 = $_POST['childname1'];
$childname2 = $_POST['childname2'];
$childname3 = $_POST['childname3'];
$childname4 = $_POST['childname4'];

$parent = "INSERT INTO `parent` (`Unique` , `Name` )VALUES '$unique', '$name')";
mysql_query($parent, $ServerConnect) or die (mysql_error());

$child = "INSERT INTO `child` (`ParentId` , `ChildName` )";
if($childname1 <> '') 
{
    $child .= "VALUES ('$unique', '$childname1')";
}
if($childname2 <> '') 
{
    $child .= ", VALUES ('$unique', '$childname2')";
}
if($childname3 <> '') 
{
    $child = ", VALUES ('$unique', '$childname3')";
}
if($childname4 <> '') 
{
    $child = ", VALUES ('$unique', '$childname4')";
} 

if($parent)
{

    mysql_query($child);

}
}
?>
<form method="POST" action="page1.php"> 
Unique: <input type="text" name="unique"><br/> 
Name: <input type="text" name="name"><br/> 
Child:<br>
name: <input type="text" name="childname1"><br/> 
name: <input type="text" name="childname2"><br/> 
name: <input type="text" name="childname3"><br/> 
name: <input type="text" name="childname4"><br/> 
</form>

[Drakla]

Well you've forgotten the dots when adding to the child string on the last two, and even if that worked the syntax of the mysql statment would be incorrect.

Multiple inserts are like this

INSERT INTO table (field1, field2) VALUES (value1, value2), (value3, value4)

So the best thing to do would be to tidy it all up with something like this:

$numKids = 4;

$values = array();

for ($i = 1; $i <= $numKids; $i++)
{
	// create a variable to refer to the appropriate child

$childRef = 'childname'.$i;

if (!empty($_POST[$childRef]))
	$values[] = "('$unique', '$_POST[$childRef]')";
}

// make sure at least one child has been filled out and string all the values together with commas

if ( count($values) )
{
	$query = "INSERT INTO `child` (`ParentId` , `ChildName` ) VALUES ";

$values = implode(',', $values);

$query .= $values;

mysql_query($query);
}

You should maybe check if the insert values need escaping, too, as if somebody has name their child O'Brianna you'll get a right pain happening if you haven't got magic quotes enabled.