[Resolved] HTML coding issue...

masood131

I tried to fix my code to comply, and I screwed it all up. Now it doesn't even work right. I tried fixing the HTML part, but I keep getting the same result. This code is from the book, and I checked the syntex quite a few times. If you see an error please let me know and I will check it again.

Here is my code:

<?php
//create short variable name
$DOCUMENT_ROOT = $HTTP_SERVER_VARS['DOCUMENT_ROOT'];
?>
<html>
<head>
<title>Bob's auto Parts - Customer Orders</title>
</head>

<body>
<h1>Bob's Auto Parts</h1>
<h2>Customer Order</h2>

<?php
@ $fp = $fopen("$DOCUMENT_ROOT/../orders/orders.txt", 'r');

if(!$fp)
{
echo '<p><strong>No orders pending.'
.'Please try again later.</strong></p></body></html>';
exit;
}
while(!feof($fp))
{
$order = fgets($fp, 999);
echo $order.'<br>';
}

fclose($fp);
?>
</body>
</html>

here is what I get on the browser:

Bob's Auto Parts
Customer Order

'; exit; } while(!feof($fp)) { $order = fgets($fp, 999); echo $order.'
'; } fclose($fp); ?>

Any ideas,

Installer

Is the code you posted the same as what you're using? 'Cause if I change this line:

@ $fp = $fopen("$DOCUMENT_ROOT/../orders/orders.txt", 'r');

to the way it should be, i.e:

$fp = @fopen('./index.php', 'r');

the script works correctly for me. Otherwise it displays nothing.

SumitGupta

Hi,

well I see an Extra Uncle Sam in your code

@ $fp = $fopen("$DOCUMENT_ROOT/../orders/orders.txt", 'r');

The fopen is function and not an variable

so your line should be something like

@ $fp = fopen("$DOCUMENT_ROOT/../orders/orders.txt", 'r');

Or the one "Installer" has given to you...

Have a nice day

Installer

Yes, my code corrected that problem, thank you, as well as the misplacement of the "@" sign, but they don't cause his alleged problem. I think copy and paste was not used to post the code.

masood131

Instaler,

You are absolutely right. I did change the ($feof) to (feof), but I have the above HTML problem now.

I did copy my code directely from the notepad, which I am using to write my code, to here if that is what you are wondering. I will copy and paste this code again, the most recent version of it that is.

Thanks you guys

Here is my copied code:

<?php
//create short variable name
$DOCUMENT_ROOT = $HTTP_SERVER_VARS['DOCUMENT_ROOT'];
?>
<html>
<head>
<title>Bob's auto Parts - Customer Orders</title>
</head>

<body>
<h1>Bob's Auto Parts</h1>
<h2>Customer Order</h2>

<?php
$fp = @fopen("$DOCUMENT_ROOT/../orders/orders.txt", 'r');

if(!$fp)
{
echo '<p><strong>No orders pending.'
.'Please try again later.</strong></p></body></html>';
exit;
}
while(!feof($fp))
{
$order = fgets($fp, 999);
echo $order.'<br>';
}

fclose($fp);
?>
</body>
</html>

and here is my output:

Bob's Auto Parts
Customer Order

'; exit; } while(!feof($fp)) { $order = fgets($fp, 999); echo $order.'
'; } fclose($fp); ?>

masood131

For those of you inteested in tackling this one with me, I found a something interesting as I was trying to fix the above code.

I took the concatenation operator(.) inside the only if statement I have in my code from the beginning second line to the end of the first line. Like this:

if(!$fp)
{
echo '<p><strong>No orders pending.'.
'Please try again later.</strong></p></body></html>';
exit;
}

and then ran the entire code and here is what I got:

Bob's Auto Parts
Customer Order
'; } fclose($fp); ?>

yes, different from my original output. What can a little dot(.) do in here. Geeeeeeeeeeeeez

thanks

masood131

I am closing this thread because I found some very disturbing findings.

I will open a new thread based on the original issue, which was not being able to see my text file on the browser.
If you like to know my findings, just post a reply and I will post it for you.

Weird, very weird this coding stuff is to me

thorpe

this line here;

 'Please try again later.</strong></p></body></html>';

has a closing </html> and </body> tags, and then you have another at the bottom of your script.

nothing wierd going on here.

masood131

thrope

Since you asked, I can't help telling you what I discovered.

Copy my original code to a text editor. However, make one change to it while in the editor:

take the only Concatenation operator (.) inside the if statement and move the dot to the end of next line. Try running the program before you move the (.) and after. You should see some really interesting results.

Best Wishes
Masood

Installer

The only thing I get from moving the dot is the expected parse error.

Is the "orders" directory an immediate subdirectory of the document root, and is your script in doc root? If not, where are they relative to each other?

masood131

Installer,

When I run:

echo $_SERVER['DOCUMENT_ROOT'];

I get:

c:/program files/apache group/apache/htdocs

My documents are in "htdocs" folder. I have "vieworder.php", "orders/orders.txt" in "htdocs" as well.

masood

Installer

Then keep using

$fp = fopen("./orders.txt", 'r');

🙂

masood131

Installer,

Thank you for being patient. I will use what you gave me. The other one is not working.

masood

Huuggee

how many threads have you got going on this?

i think the answer you are looking for is

 $fp = @fopen("$DOCUMENT_ROOT/orders/orders.txt", 'r');

you doc root send you to c:...\htdocs

from there all your scrips are accessible and the orders.txt file is in the orders folder ./orders

an understanding of how file systems might help you better, so google on *nix file system help, unless you course you fully understand . and .. syntax

masood131

Huuggee

I tried $fp = fopen("$DOCUMENT_ROOT/orders/orders.txt", 'r'); already, but what I get is:

Bob's Auto Parts
Customer Order
No orders pending.Please try again later.

I tried $fp = fopen("./orders/orders.txt", 'r'); and what I get is:

Bob's Auto Parts
Customer Order
16:58, 10th March 1 tires 2 oil 3 spark plugs $132.00 142 Clark St. Apt#6 San Rafael, CA 94901

Any ideas?

masood

Huuggee

better syntax may be

$fp = fopen($DOCUMENT_ROOT . '/orders/orders.txt', 'r');

masood131

Huuggee

It should make sense that your code

$fp = fopen($DOCUMENT_ROOT . '/orders/orders.txt', 'r');

is correct and works, but it doesn't. I am thinking about posting the entire code again for everyone to look at and perhaps run it with their suggestions.

<?php
//create short variable name
$DOCUMENT_ROOT = $HTTP_SERVER_VARS['DOCUMENT_ROOT'];
?>
<html>
<head>
<title>Bob's auto Parts - Customer Orders</title>
</head>

<body>
<h1>Bob's Auto Parts</h1>
<h2>Customer Order</h2>

<?php
$fp = fopen($DOCUMENT_ROOT.'/orders/orders.txt', 'r'); //this is the one I am having problems with
//$fp = fopen("./orders.txt", 'r'); //this one works just fine thanks to installer

if(!$fp)
{

 echo '<p><strong>No orders pending.'
     .'Please try again later.</strong></p></body></html>';
 exit;

}

while(!feof($fp))
{
$order= fgets($fp, 999);
echo $order.'<br>';
}

fclose($fp);

?>
</body>
</html>

Huuggee

another possibility, rather than using document root is to try directory($_SERVER['php_self'])
as the relation in any installation of your used files would be the same

 $fp = fopen(directory($_SERVER['php_self']).'/orders/orders.txt', 'r');

masood131

Huuggee, installer, thorpe, and the rest of you guys that showed interest, I thank you. YOu guys are the best.

I am moving on. I think I and the rest of you guys put enough time into this. If nothing else I have resolved the issues, and learned a whole bunch.

Thanks a million
masood