[Resolved] using the ternary operator with "this"

[BigBadKev]

Hi All,

how do I use the following in a ternary operator?

if($this->sql->rows > 0) {
  $this->sql->tran_commit();
}
else {
  $this->sql->tran_rollback();
}

I basically want something like the following

$this-> = $this->sql->rows > 0 ? tran_commit() : tran_rollback();

Does anyone have any ideas for me?, thanks in advance guys

BBK 🙂

[Drakla]

$this->sql->rows > 0 ? $this->sql->tran_commit() : $this->sql->tran_rollback();

[BigBadKev]

Hi Drakla,

thanks...I missed it, looking at it way to long

BBK 🙂

[Weedpacket]

Personally I think the first code looks better 😉

[kburger]

Me too. I'm not a big fan of ternary operators. Why not make the code easier to read? But then again, unnecessary complexity leads to job security.

[Drakla]

Yeah, they can get a bit ugly - even if staggered like

$this->sql->rows > 0 ?
    $this->sql->tran_commit() 
    : 
    $this->sql->tran_rollback();

to make them look a bit 'iffy'

[Weedpacket]

Oh, I use the ternary operator on a regular basis - but as an operator, not a substitute for the if statement. Instead of

if($test)
	do_something('foo','bar',1);
else
	do_something('foo','bar',2);

I'd rather write

do_something('foo', 'bar', $test ? 1 : 2);

because among other things it localises the test with the reason the test is being made.

But there is no significant difference to be made by writing

$this->sql->rows > 0
    ? $this->sql->tran_commit() 
    : $this->sql->tran_rollback();

over the if statement.