Help with php script !!

russellbcv

I am trying to create a simple customer registration page which is linked to a MySQL database but I am having problems running the thing! The problem you will see from the error log below "Line 26"???

Error Log>
[Sat Mar 12 10:55:49 2005] [error] PHP Parse error: syntax error, unexpected T_STRING in c:\Apache\htdocs\adduser.php on line 26

Any ideas??

<html><head><title?Adding a User</title>
<style type="text/css">

</style>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"></head><body>
<div align="justify"><span class="style2"></span>
<?php $self = $SERVER['PHP_SELF'];
$telephoneno = $POST['telephoneno'];
$firstname = $POST['firstname'];
$lastname = $POST['lastname'];
$address = $POST['address'];
$email = $POST['email'];
$paytype = $POST['paytype'];
$cc no = $POST['cc no'];
$cc expiry = $POST['cc expiry'];
$cc start = $POST['cc start'];
$cc issue = $POST['cc issue'];
$a/c holder = $POST['a/c holder'];
$a/c no = $POST['a/c no'];
$s/code = $POST['s/code'];
$username = $POST['username'];
$password = $POST['password'];

if( ( !$telephoneno ) or ( !$firstname )
or ( !$lastname ) or ( !$address )
or ( !$email ) or ( !$paytpe )
or ( !$cc no ) or ( !$cc expiry )
or ( !$cc start ) or ( !$cc issue )
or ( !$a/c holder ) or ( !$a/c no )
or ( !$s/code ) or ( !$username )
or ( !$password) )
{
$form ="Please enter all new user details...";
$form.="<form action=\"$self\"";
$form.=" method=\"post\"text\">Telephone No: ";
$form.="<input type=\"text\" name=\"telephoneno\"";
$form.=" value=\"$telephoneno\"><br>First Name: ";
$form.="<input type=\"text\" name=\"firstname\"";
$form.=" value=\"$firstname\"><br>Last Name: ";
$form.="<input type=\"text\" name=\"lastname\"";
$form.=" value=\"$lastname\"><br>Address: ";
$form.="<input type=\"text\" name=\"address\"";
$form.=" value=\"$address\"><br>Email: ";
$form.="<input type=\"text\" name=\"email\"";
$form.=" value=\"$email\" ><br>Pay Type: ";
$form.="<input type=\"text\" name=\"paytype\"";
$form.=" value=\"$paytype\"><br>CC No: ";
$form.="<input type=\"text\" name=\"cc no\"";
$form.=" value=\"$cc no\"><br>CC Expiry: ";
$form.="<input type=\"text\" name=\"cc expiry\"";
$form.=" value=\"$cc expiry\" ><br>CC Start: ";
$form.="<input type=\"text\" name=\"cc start\"";
$form.=" value=\"$cc start\" ><br>CC Issue: ";
$form.="<input type=\"$cc issue\" name=\"cc issue\"";
$form.=" value=\"$cc issue\" ><br>A/c Holder: ";
$form.="<input type=\"text\" name=\"A/c Holder\"";
$form.=" value=\"$a/c holder\" ><br>A/c No: ";
$form.="<input type=\"text\" name=\"a/c no\"";
$form.=" value=\"$a/c no\" ><br>S/Code: ";
$form.="<input type=\"text\" name=\"s/code\"";
$form.=" value=\"$s/code\" ><br>Username: ";
$form.="<input type=\"text\" name=\"username\"";
$form.=" value=\"$username\" ><br>Password: ";
$form.="<input type=\"text\" name=\"password\"";
$form.=" value=\"$password\"><br>";
$form.="<input type=\"submit\" value=\"Submit\">";
$form.="</form>";
echo( $form );
}

else
{ $conn = @mysql_connect( "localhost", "rcox","joshua" )
or die("Could not connect to MySQL");
$db = mysql_select_db( "template", $conn )
or die("Could not select database");
$sql = "insert into users
(telephoneno,firstname,lastname,address,email,paytype,cc no,cc expiry,cc start,cc issue,a/c holder,a/c no,s/code,username,password) values
(\"$telephoneno\",\"$firstname\",\"$lastname\",\"$address\",\"$email\",\"$paytype\",\"$cc no\",\"$cc expiry\",\"$cc start\",\"$a/c holder\",\"$a/c no\",\"$s/code\",\"$username\",password(\"$password\") )";
$result = mysql_query( $sql, $conn )
or die("Could not execute query");
if( $result ) { echo( "New User $username added" ); }
}
?>
</div>
</body></html>

BooRadLey

I'm pretty sure variable names eg: $cc no cannot have spaces in them. I recommend using something like underscores cc_no

Brad

russellbcv

Excellent that worked !!

However, I could not execute query!

Any ideas?

(Error Logs)>
[Sat Mar 12 11:57:37 2005] [error] PHP Notice: Undefined index: telephoneno in c:\Apache\htdocs\adduser.php on line 20
[Sat Mar 12 11:57:37 2005] [error] PHP Notice: Undefined index: firstname in c:\Apache\htdocs\adduser.php on line 21
[Sat Mar 12 11:57:37 2005] [error] PHP Notice: Undefined index: lastname in c:\Apache\htdocs\adduser.php on line 22
[Sat Mar 12 11:57:37 2005] [error] PHP Notice: Undefined index: address in c:\Apache\htdocs\adduser.php on line 23
[Sat Mar 12 11:57:37 2005] [error] PHP Notice: Undefined index: email in c:\Apache\htdocs\adduser.php on line 24
[Sat Mar 12 11:57:37 2005] [error] PHP Notice: Undefined index: paytype in c:\Apache\htdocs\adduser.php on line 25
[Sat Mar 12 11:57:37 2005] [error] PHP Notice: Undefined index: cc_no in c:\Apache\htdocs\adduser.php on line 26
[Sat Mar 12 11:57:37 2005] [error] PHP Notice: Undefined index: cc_expiry in c:\Apache\htdocs\adduser.php on line 27
[Sat Mar 12 11:57:37 2005] [error] PHP Notice: Undefined index: cc_start in c:\Apache\htdocs\adduser.php on line 28
[Sat Mar 12 11:57:37 2005] [error] PHP Notice: Undefined index: cc_issue in c:\Apache\htdocs\adduser.php on line 29
[Sat Mar 12 11:57:37 2005] [error] PHP Notice: Undefined index: ac_holder in c:\Apache\htdocs\adduser.php on line 30
[Sat Mar 12 11:57:37 2005] [error] PHP Notice: Undefined index: ac_no in c:\Apache\htdocs\adduser.php on line 31
[Sat Mar 12 11:57:37 2005] [error] PHP Notice: Undefined index: scode in c:\Apache\htdocs\adduser.php on line 32
[Sat Mar 12 11:57:37 2005] [error] PHP Notice: Undefined index: username in c:\Apache\htdocs\adduser.php on line 33
[Sat Mar 12 11:57:37 2005] [error] PHP Notice: Undefined index: password in c:\Apache\htdocs\adduser.php on line 34
[Sat Mar 12 11:57:54 2005] [error] PHP Notice: Undefined index: telephoneno in c:\Apache\htdocs\adduser.php on line 20
[Sat Mar 12 11:57:54 2005] [error] PHP Notice: Undefined index: firstname in c:\Apache\htdocs\adduser.php on line 21
[Sat Mar 12 11:57:54 2005] [error] PHP Notice: Undefined index: lastname in c:\Apache\htdocs\adduser.php on line 22
[Sat Mar 12 11:57:54 2005] [error] PHP Notice: Undefined index: address in c:\Apache\htdocs\adduser.php on line 23
[Sat Mar 12 11:57:54 2005] [error] PHP Notice: Undefined index: email in c:\Apache\htdocs\adduser.php on line 24
[Sat Mar 12 11:57:54 2005] [error] PHP Notice: Undefined index: paytype in c:\Apache\htdocs\adduser.php on line 25
[Sat Mar 12 11:57:54 2005] [error] PHP Notice: Undefined index: cc_no in c:\Apache\htdocs\adduser.php on line 26
[Sat Mar 12 11:57:54 2005] [error] PHP Notice: Undefined index: cc_expiry in c:\Apache\htdocs\adduser.php on line 27
[Sat Mar 12 11:57:54 2005] [error] PHP Notice: Undefined index: cc_start in c:\Apache\htdocs\adduser.php on line 28
[Sat Mar 12 11:57:54 2005] [error] PHP Notice: Undefined index: cc_issue in c:\Apache\htdocs\adduser.php on line 29
[Sat Mar 12 11:57:54 2005] [error] PHP Notice: Undefined index: ac_holder in c:\Apache\htdocs\adduser.php on line 30
[Sat Mar 12 11:57:54 2005] [error] PHP Notice: Undefined index: ac_no in c:\Apache\htdocs\adduser.php on line 31
[Sat Mar 12 11:57:54 2005] [error] PHP Notice: Undefined index: scode in c:\Apache\htdocs\adduser.php on line 32
[Sat Mar 12 11:57:54 2005] [error] PHP Notice: Undefined index: username in c:\Apache\htdocs\adduser.php on line 33
[Sat Mar 12 11:57:54 2005] [error] PHP Notice: Undefined index: password in c:\Apache\htdocs\adduser.php on line 34

<html><head><title?Adding a User</title>
<style type="text/css">

</style>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"></head><body>
<div align="justify"><span class="style2"></span>
<?php $self = $SERVER['PHP_SELF'];
$telephoneno = $POST['telephoneno'];
$firstname = $POST['firstname'];
$lastname = $POST['lastname'];
$address = $POST['address'];
$email = $POST['email'];
$paytype = $POST['paytype'];
$cc_no = $POST['cc_no'];
$cc_expiry = $POST['cc_expiry'];
$cc_start = $POST['cc_start'];
$cc_issue = $POST['cc_issue'];
$ac_holder = $POST['ac_holder'];
$ac_no = $POST['ac_no'];
$scode = $POST['scode'];
$username = $POST['username'];
$password = $POST['password'];

if( ( !$telephoneno ) or ( !$firstname )
or ( !$lastname ) or ( !$address )
or ( !$email ) or ( !$paytype )
or ( !$cc_no ) or ( !$cc_expiry )
or ( !$cc_start ) or ( !$cc_issue )
or ( !$ac_holder ) or ( !$ac_no )
or ( !$scode ) or ( !$username )
or ( !$password) )
{
$form ="Please enter all new user details...";
$form.="<form action=\"$self\"";
$form.=" method=\"post\"text\">Telephone No: ";
$form.="<input type=\"text\" name=\"telephoneno\"";
$form.=" value=\"$telephoneno\"><br>First Name: ";
$form.="<input type=\"text\" name=\"firstname\"";
$form.=" value=\"$firstname\"><br>Last Name: ";
$form.="<input type=\"text\" name=\"lastname\"";
$form.=" value=\"$lastname\"><br>Address: ";
$form.="<input type=\"text\" name=\"address\"";
$form.=" value=\"$address\"><br>Email: ";
$form.="<input type=\"text\" name=\"email\"";
$form.=" value=\"$email\" ><br>Pay Type: ";
$form.="<input type=\"text\" name=\"paytype\"";
$form.=" value=\"$paytype\"><br>CC No: ";
$form.="<input type=\"text\" name=\"cc_no\"";
$form.=" value=\"$cc_no\"><br>CC Expiry: ";
$form.="<input type=\"text\" name=\"cc_expiry\"";
$form.=" value=\"$cc_expiry\" ><br>CC Start: ";
$form.="<input type=\"text\" name=\"cc_start\"";
$form.=" value=\"$cc_start\" ><br>CC Issue: ";
$form.="<input type=\"$cc_issue\" name=\"cc_issue\"";
$form.=" value=\"$cc_issue\" ><br>A/c Holder: ";
$form.="<input type=\"text\" name=\"ac_holder\"";
$form.=" value=\"$ac_holder\" ><br>A/c No: ";
$form.="<input type=\"text\" name=\"ac_no\"";
$form.=" value=\"$ac_no\" ><br>S/Code: ";
$form.="<input type=\"text\" name=\"scode\"";
$form.=" value=\"$scode\" ><br>Username: ";
$form.="<input type=\"text\" name=\"username\"";
$form.=" value=\"$username\" ><br>Password: ";
$form.="<input type=\"text\" name=\"password\"";
$form.=" value=\"$password\"><br>";
$form.="<input type=\"submit\" value=\"Submit\">";
$form.="</form>";
echo( $form );
}

else
{ $conn = @mysql_connect( "localhost", "rcox","joshua" )
or die("Could not connect to MySQL");
$db = mysql_select_db( "template", $conn )
or die("Could not select database");
$sql = "insert into users
(telephoneno,firstname,lastname,address,email,paytype,cc_no,cc_expiry,cc_start,cc_issue,ac_holder,ac_no,scode,username,password) values
(\"$telephoneno\",\"$firstname\",\"$lastname\",\"$address\",\"$email\",\"$paytype\",\"$cc_no\",\"$cc_expiry\",\"$cc_start\",\"$ac_holder\",\"$ac_no\",\"$scode\",\"$username\",password(\"$password\") )";
$result = mysql_query( $sql, $conn )
or die("Could not execute query");
if( $result ) { echo( "New User $username added" ); }
}
?>
</div>
</body></html>

Huuggee

$form ="Please enter all new user details...";
$form.="<form action=\"$self\"";
$form.=" method=\"post\"text\">Telephone No: ";

your form method is messed up


// your says in html (you have an extra 'text'
<form action="page.php" method="post"text">

// should be 
$form.=" method=\"post\"">