[Resolved] in_array($string, $this->MyArray) fails

[BigBadKev]

Hi All

I am having real problems finding a key in a array, here is the exact code

//$this->fields has data (I debugged it)
//$addField is a string containing a basic name like 'food'

****** This fails ******
if(in_array($addField, $this->fields)) {
  return false;  

}


****** This works ******
foreach($this->fields as $key => $value) {
  if($key === $addField) {
    return false; 
  }
}

****** This is how the $this->fields[] is set ******
//basically its a sql table column grab and puts all the columns
//in the array
$i = 1 (field [0] is the primary key column which I dont need)
while ($i < mysql_num_fields($this->sql->result)) {
  $obj = mysql_fetch_field($this->sql->result, $i);
  $this->fields[$obj->name] = $row[$i];
  $i++;
}

Can anyone help me? I am lost as to why it fails, thanks as I feel like a noob

BBK 🙂

[laserlight]

if($key === $addField)

Clearly you are comparing with the keys of the array.
But $this->fields is the array, and hence the values of the array.

You should then use:
in_array($addField, array_keys($this->fields))

[BigBadKev]

Hey LaserLight,

thanks so much it worked great.

BBK 🙂

[laserlight]

Oops, I just realised:

You might as well use [man]array_key_exists/man instead.

if (array_key_exists($addField, $this->fields))

[BigBadKev]

Hi LaserLight,

can I be so bold as to ask what the real diff is?

BBK 🙂

[laserlight]

Instead of having to use both in_array() and array_keys(), you just use one array_key_exists(), which is much faster.

[BigBadKev]

Thanks LaserLight,

you along with all the others are a great help to us all.

BBK 🙂