Registered Globals and me...

AreOh

What's up, PHP peoples. I'm still a novice when it comes to php/mySQL (only been using it for about a year), but I pretty much know my way around it. Anyway, one of the things I am current struggling with is updating code so that it is not reliant upon the registered globals option being turned off. As such I have begun using the new super global arrays variable ($GET, $POST, etc), but apparently the don't seem to be working. I can get the data from the db to spit to a form, but when it comes to updating and inserting new data, no can do. Any help (and code) would be much appreciated. Currently I am running Mac OS 10.3.8, PHP4.3 and MySQL 4.1 if I'm not mistaken, without registered globals currently turned off. Thanks in advance...

__
Ro

tekky

putting forth some initiative will generally promote others to be more likely to help you out....

AreOh

if you meant post some code, it's not a problem..

<?php

//connect to db


mysql_select_db($db , $connect) or die ("Couldn't open $db: ".mysql_error());

$id=$_GET['id'];
$db="rickety";
//mysql_connect(localhost,$_POST['username'],$_POST['pass']);
$link = mysql_connect("#","#","#") or die ("unable to select database");
if (! $link)
die("Couldn't connect to MySQL");

mysql_select_db($db , $link)
or die("Couldn't open $db: ".mysql_error());

$self = $_SERVER['PHP_SELF'];

$query="SELECT * FROM content WHERE id='$id'";
$result=mysql_query($query);
$num=mysql_num_rows($result);

$i=0;
while ($i < $num) {
$siteText=mysql_result($result,$i,"siteText");
$img=mysql_result($result,$i,"img");

//echo ="fuuuuck you";


if ($_POST['submit'] == 'Submit') {
$id=$_POST['id'];
$siteText=$_POST['siteText'];
$img=$_POST['img'];

$query ="UPDATE content SET siteText='$siteText' img='$img' WHERE id=$id ";
$result = mysql_query($query);

//mysql_query("UPDATE content SET siteText='$siteText' img='$img' WHERE id='$id' ");

$success = 'updated dude!!';

}	

?>
<html>
<head>

<title>RicketyContraption CMS</title>
</head>
<body>	
Edit Form
<? echo $success; ?>
<form method="post" action="<? echo $self; ?>">

<input type="text" name="id" value="<? echo $id; ?>" >
<br>

<textarea rows="15" cols="50" name="siteText"><? echo $siteText; ?>
</textarea>
<br>

<input type="text" name="img" value="<? echo $img; ?>" size="50">
<br>

<input type="submit" value="Submit">

</form>

<?
++$i;
}
?>

</body>
</html>

it's a little rough around the edges, but this is the basic gist...

AreOh

Hmm, apparently some other cats are having the same problem. I believe I have found what I am doing wrong, but if anyone has any other helpful nuggets, feel free. Any help is greatly appreciated...

AreOh

What's up, lovely people. So I re-wrote the monstronsity above to the code below. Everything seems to be passing to where it needs to be but for some reason, it does not update. The $_POST is getting the content, so I know it's not trying to post an empty set, so I'm kind of at a loss. Does anyone see an errors as to why it would not post to the DB?

<?php

//connect to db


$db="rickety";
$connect = mysql_connect("localhost","user","password") or die ("unable to select database");

mysql_select_db($db , $connect) or die ("Couldn't open $db: ".mysql_error());

$id=$_GET['id'];

$self = $_SERVER['PHP_SELF'];

$query = "SELECT * FROM content WHERE id = $id";
$result = mysql_query($query, $connect);

while ($row = mysql_fetch_array($result))
{
 echo("The image for section " . $id . " is " . $row['img']);
 echo("<br>");
 $siteText = $row['siteText'];
 $img = $row['img'];

 }

echo("Page = " . $self . "<br> <br>");

if ($_POST['submit'] == 'Submit') {


	//form variables for posting
	$id = $_POST['id'];
	$siteText = stripslashes($_POST['siteText']);
	$img = $_POST['img'];
	$update_query = "UPDATE content SET siteText = '$siteText', img = '$img' WHERE ID=$id";

	//runs the query against the table
	$update_result = mysql_query($update_query);
		if(mysql_affected_rows() == 1) {
		$success = 'It fuqqin worked!!';
		}else {
		error_log(mysql_error());
		$success = 'FUUUUUUUQQQQQQ';
		}


}



?>
<html>
<head>

<title>RicketyContraption CMS</title>
</head>
<body>	
Edit Form<br>
<? echo $success; ?>
<form method="post" action="<? echo $self . "?id=" . $id; ?>">

<input type="text" name="id" value="<? echo $id; ?>" >
<br>

<textarea rows="15" cols="50" name="siteText"><? echo $siteText; ?>
</textarea>
<br>

<input type="text" name="img" value="<? echo $img; ?>" size="50">
<br>

<input type="submit" name="submit" value="Submit">

</form>

</body>
</html>

tekky

what results is your code outputting?

FUQQQQQQQQQQQQQQ, Success or nothing?

AreOh

it's givin me the 'fuuuqqqqqqqqq' error.

tekky

[man]mysql_affected_rows/man

read that and tell me what you see with your script 😉

AreOh

haha, good drop dude. I changed it to this...

if ($_POST['submit'] == 'Submit') {


	//form variables for posting
	$id = $_POST['id'];
	$siteText = stripslashes($_POST['siteText']);
	$img = $_POST['img'];
	$update_query = "UPDATE content SET siteText = '$siteText', img = '$img' WHERE ID=$id";
	echo(mysql_affected_rows() . "<br>");

	//runs the query against the table
	#$update_result = mysql_query($update_query);
		if(mysql_affected_rows() == 1) {
		$success = 'It fuqqin worked!!';
		}else {
		error_log(mysql_error());
		$success = 'FUUUUUUUQQQQQQ';
		}


}

and it returned a 1, which made me happy. But check this out. so it's tellng me that a row in the db is updated, but the content in the db itself still isn't updating? isn't that strange? it's some ole resident evil stuff going on today with my code...

tekky

hmmm

echo out your $update_query then paste that line into phpMyAdmin and see what it does....

AreOh

what's phpMyAdmin?? hahaha, i keed, i keed...

Genius. I didn't even consider running by query through phpMyAdmin. And it showed me what the problem was. I had some escape charecters in my db content that was telling the string to end before it was ready and it wasn't getting the rest of the query after it saw ' so i just wrapped the variable in add Slashes and it works like a charm now. Thanks for your insight man. It would have been another week before I thought about trying that...

tekky

ahhh goood then glad its fixed 😉