str_replace

[mrdave]

i have a field 'home_features' im returning to my page which returns the following

Dishwasher||Microwave||Washer/Dryer||Carpeted Floors||Cable/Satellite TV||Fireplace||Hi Fi system||

using the following

<?php if ($listingID >0 ) {renderSingleListingItemRaw($listingID, "home_features") ;} else {echo "";} ?>

how do i remove the || seperator and replace it with a ,

so it looks like

Dishwasher,Microwave,Washer/Dryer,....etc

im trying to use this as a dynamic meta tag keyword generator for each page i have. each listing id has its own list. Ive tried

<?php $featuresfixed = str_replace('||', ',', renderSingleListingItemRaw($listingID, "home_features")) ?>

but i just get the same results, what am i doing wrong?

[laserlight]

what does renderSingleListingItemRaw() do and return?

It looks like it prints something, you should make it return the string instead.

[mrdave]

thanks laswerlight, sorry im a bit new at php so excuse me for sounding a bit thick here...

what do you mean by return the string instead? i though that str_replace returned the string and replaced what you specified.?

thanks.

[mrhappiness]

that's correct

but what laserlight meant was:
The function you're calling (renderSingleListingItemRaw) seems to output text via echo or print.

You have to change this function from

function renderSingleListingItemRaw($something) {
  echo 'This is '.$something;
}

to

function renderSingleListingItemRaw($something) {
  return 'This is '.$something;
}

atm you're trying to do a search&replace and use an empty string (since renderSingleListingItemRaw does not return anything) to search in...