PHP Problem I can't understand

IRON_FART

I wrote some code today that will:
A. Check if a text file is readable and writable.
B. Will open and read that text file and print everything that is in the file on a page.
Here's the code:

<?php
$ips = "adresses.txt";
if (file_exists($ips) == FALSE) {
	exit;
	} else {
	if (is_readable($ips) == TRUE) {
		if (is_writable($ips) == TRUE) {
            print("You may edit the file.");
			$handle = fopen($ips, "r");
				while (!feof($handle)) {
   					$buffer = fgets($handle, 4096);
				}
                print("<br>$buffer"); // <-- Pay special attention to this line
				fclose($handle);
		} else {
		exit;
		}
	} else {
	exit;
	}
}
?>

Now if My adresses.txt is:
Test
abcd
efgh

Then the script will output:

You may edit the file.
Test
abcd
efgh

And that is correct.

Now look at the line that has the comment next to it. If I move that anywhere else, it will only output:

You may edit the file.
<br>efgh

I want it to output the first quote.

I think it has something to do with feof(), but I don't know what help that is.

TIA for help. 😃

planetsim

The only thing that hit me so far was this line

$buffer = fgets($handle, 4096);

Since its a loop and EOF my not be found for a while you need to make sure buffer isnt getting overwritten with other data.

$buffer .= fgets($handle, 4096);

.= is string concatenation. Also you may find that declaring an empty buffer variable before the loop like this

$buffer = '';

As it wont give an error when in the loop trying to concatenate on first loop the error where $buffer hasnt been defined.

IRON_FART

:queasy:
I added those changes. They didn't take any effect.

I did some thinking now, and I am pretty sure I know why it's happening, but I don't know how to fix it code-wise.

There are 3 lines in the text file.
Test
abcd
efgh

print("<br>$buffer");

Works in the first position because it is part of a loop. As the page is loading the value of $buffer is changed 3 times.

First it is set to "Test"
Then "Test" is printed, then the loop starts over.
$buffer is set to "abcd" and then "abcd" is printed, then $buffer is set to "efgh" and "efgh" is printed.

When I try and use
print("<br>$buffer");
Outside of the loop, the value of $buffer is still "efgh" and that is why only the last line is printed outside of the loop.

EDIT: I fixed the problem by pasting the loop into another .php file and putting it where I wanted with the include() function.

Thanks for the help!