Problem holding value in select box

ali_p

Hello,

I am trying to pass values from a select box to my mysql database . The values are coming from a table which i'm using to populate my select box. All this is fine, however it will only pass the value of the last entry in the table ( the table that is populating the select box ). So in my select i have Group A , Group B , Group C only the last entry Group C is being passed.

Below is my code its a bit rough and ready coz i am doing a bit of experimenting.

Any help would be greatly appreciated.

Thanks

//create the sql statement
$sql = "SELECT *
FROM dcass_groups
GROUP BY 'dcass_group'";
//execute the sql statement
$result = mysql_query($sql, $conn)or die(mysql_error());
//will go through each row in the result set and display data
while($row=mysql_fetch_array($result)) {
//give a name to the fields
$team_id = $row['team_id'];
$dcass_group = $row['dcass_group'];
$team_name=$row['team_name'];

if (isset($_POST['dcass_group']))
{
$group_options .="
<option value=\"$dcass_group\" selected>$dcass_group</option>\n";
}

$group_options .="

<option value=\"$dcass_group\">$dcass_group</option>\n";
}

//to get the teams relevant to the group

//
if (isset($POST['finalsubmit'])) {
do something here
}
else
{
if (isset($POST['dcass_group']))
{
$sql = "SELECT *
FROM dcass_groups
WHERE dcass_group = '$_POST[dcass_group]'";
//execute the sql statement
$result = mysql_query($sql, $conn)or die(mysql_error());
$teams='<select name="team1">';
while($row=mysql_fetch_array($result))
{
// RETURN DETAILS OF THE COUNTRY CHOSEN
$teams.='<option value="'.$row[team_name].'">'.$row[team_name].'</option>';
}
$teams.='</select>';
}

if (isset($POST['dcass_group']))
{
$sql = "SELECT *
FROM dcass_groups
WHERE dcass_group = '$POST[dcass_group]'";
//execute the sql statement
$result = mysql_query($sql, $conn)or die(mysql_error());
$teams2='<select name="team2">';
while($row=mysql_fetch_array($result))
{
// RETURN DETAILS OF THE COUNTRY CHOSEN
$teams2.='<option value="'.$row[team_name].'">'.$row[team_name].'</option>';
}
$teams2.='</select>';
}

}

?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<head>
<title>test</title>
<SCRIPT language="JavaScript">
function submitform()
{
document.form1.submit();
}
</SCRIPT>
</head>

<body>
<table width="600" border="0" cellspacing="0" cellpadding="0">
<form name="form1" method="post" action="<?php echo $_SERVER[php_self];?>">
<td>Group</td>
<td><select name="dcass_group" onChange="javascript:submitform();">

<option value=''>--- Select your Group ---</option>
<?print $group_options;?>
</select>
</td>
</tr>
<tr>
<td>Team 1</td>
<td><?php echo $teams;?></td>
</tr>
<tr>
<td>Team 2</td>
<td><?php echo $teams2;?></td>
</tr>
<tr>
<td>Tournament</td>
<td><input type="text" name="tournament"></td>
</tr>
<tr>
<td>Venue</td>
<td><input type="text" name="venue"></td>
</tr>
<tr>
<td>Date</td>
<td><input type="text" name="game_date"></td>
</tr>
<tr>
<input type="hidden" name="team1_result" value="tbc">
<input type="hidden" name="team2_result" value="tbc">

</form>

</table>

</body>
</html>

Weedpacket

First of all let's use the handy magic [php] tags this forum comes with, and see if we can't make it a bit more legible. While we're about it, let's also aim for a bit of consistency in our coding style, so that we don't lose track of where we are in which loops or branches. Rough and ready is no excuse for making things difficult for yourself (and everyone who's trying to help).

<?php
//create the sql statement
$sql = "SELECT *
FROM dcass_groups
GROUP BY 'dcass_group'";

What do you mean "Group by dcass_group"? There are no aggregate functions being used, so no reason for grouping. What are you trying to get, a list of the dcass_group values?
SELECT DISTINCT dcass_group from dcass_groups would do that. And if the name of the table means anything,
each dcass_group probably only appears once anyway, so the distinct isn't needed either.

//execute the sql statement
$result = mysql_query($sql, $conn)or die(mysql_error());
//will go through each row in the result set and display data
while($row=mysql_fetch_array($result))
{
	//give a name to the fields
	$team_id = $row['team_id'];
	$dcass_group = $row['dcass_group'];
	$team_name=$row['team_name'];

Studies have shown that two out of three variables are never used. Maybe you're wanting these for something else here.

	if (isset($_POST['dcass_group']))
	{
		$group_options .="<option value=\"$dcass_group\" selected>$dcass_group</option>\n";
	}
	$group_options .="<option value=\"$dcass_group\">$dcass_group</option>\n";

Well, there's a problem right there; without the else the selected item will show up twice - once selected, once not.

}
//to get the teams relevant to the group
//
if (isset($_POST['finalsubmit']))
{
	//do something here
}
else
{
	if (isset($_POST['dcass_group']))
	{
		$sql = "SELECT *
		FROM dcass_groups
		WHERE dcass_group = '$_POST[dcass_group]'";
		//execute the sql statement
		$result = mysql_query($sql, $conn)or die(mysql_error());
		$teams='<select name="team1">';
		while($row=mysql_fetch_array($result))
		{
			// RETURN DETAILS OF THE COUNTRY CHOSEN
			$teams.='<option value="'.$row[team_name].'">'.$row[team_name].'</option>';
		}
		$teams.='</select>';
	}

if (isset($_POST['dcass_group']))

Hang on, didn't we just test this?

	{
		$sql = "SELECT *
		FROM dcass_groups
		WHERE dcass_group = '$_POST[dcass_group]'";
		//execute the sql statement
		$result = mysql_query($sql, $conn)or die(mysql_error());
		$teams2='<select name="team2">';
		while($row=mysql_fetch_array($result))
		{
			// RETURN DETAILS OF THE COUNTRY CHOSEN
			$teams2.='<option value="'.$row[team_name].'">'.$row[team_name].'</option>';
		}
		$teams2.='</select>';
	}
}

?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
...
<form name="form1" method="post" action="<?php echo $_SERVER[php_self];?>">
... Well, that won't work - it needs to be $_SERVER['PHP_SELF'] ....

<select name="dcass_group" onChange="java script:submitform();">
<option value=''>--- Select your Group ---</option>
<?print $group_options;?>
</select>
</td>
</tr>
<tr>
<td>Team 1</td>
<td><?php echo $teams;?></td>
</tr>
<tr>
<td>Team 2</td>
<td><?php echo $teams2;?></td>
</tr>
<tr>
....
</html>

ali_p

Thanks for your time. Perhaps i should explain the area of code that i think is causing my value not to be held in the form.


$sql = "SELECT * 
		FROM dcass_groups
		GROUP BY 'dcass_group'";
//execute the sql statement
$result = mysql_query($sql, $conn)or die(mysql_error());
//will go through each row in the result set and display data
	while($row=mysql_fetch_array($result)) {
	//give a name to the fields
	$team_id = $row['team_id'];
	$dcass_group = $row['dcass_group'];
	$team_name=$row['team_name'];

if (isset($_POST['dcass_group']))
{ 
	$group_options .="
<option value=\"$dcass_group\" selected>$dcass_group</option>\n";
}else{


$group_options .="
<option value=\"$dcass_group\">$dcass_group</option>\n";
	}
}

Now i know that the value is being passed as for examply by selecting 'Group A' from the select box you get all the teams in 'Group A' in my second select box ( which i am not concerning myself with here. ) But for some reason that value 'Group A' is lost in the first select box, it simply reverts back to the last item added to the database, which in this case is 'Group C'.