[Resolved] Cannot display data after a space

kcgame

Hi,

Running into a strange problem...I have a Column named Rname, it contains a value of 'Thunder Fear'.

I want to display this value in a text field upon loading of web page, but i only can get Thunder 🙁 It can't display the Word after the spacing😕

My code is


echo"<input name=rname type=text size=40 maxlength=40 value=$newarray[Rname]>";

NOTE: $newarray is the row returned from previous code (not shown)

Please help, thanks.

laserlight

You should quote your HTML attribute values.

echo '<input name="rname" type="text" size="40" maxlength="40" value="' . $newarray['Rname'] . '">';

ShawnK

It was probally because you didn't quite the attributes, and then you had a quote in your data. Make sure you use the mysql add slashes function or the normal add slashes function for data.

kcgame

Thanks for the help😃

So i'll have to quote the parts where there are spaces..Have changed my code to the following, and it works🙂

echo"<input name=rname type=text size=40 maxlength=40 value='". $newarray['Rname'] ."'>";

Thanks again.

laserlight

ShawnK has a good point though, that quotes in your data might still mess it up.
But ShawnK's solution is not correct - instead you should use [man]htmlspecialchars/man on your data.

Weedpacket

Originally posted by kcgame
So i'll have to quote the parts where there are spaces..Have changed my code to the following, and it works🙂

The recommendation for HTML is that all attribute values should be quoted. (And quotes are required in XHTML). So, if you want to catch up with the twenty-first century.... 🙂

ShawnK

To rid of quotes with mysql all you have to use when you insert data is use add slashes and then when you get the data, stripslashes.

How is that not correct?

Weedpacket

Originally posted by ShawnK
To rid of quotes with mysql all you have to use when you insert data is use add slashes and then when you get the data, stripslashes.

How is that not correct?

Who said anything about MySQL? Or any DBMS for that matter? This is purely an HTML issue.

ShawnK

My apologies, I just read where he said column and assumed it was some DB. I didn't see the part about the text file.

Drakla

There's a popular misconception that you have to stripslashes when removing data from a database. You have to slash non numeric data on the way in in case it has quotes in it, and in php you'll be putting it between quotes normally when creating your insertion string.

When you SELECT it back out it's ready to go.

I see the stripslashes thing so much I wonder if it should be part of a sticky.

ShawnK

You have to use it when you used addslashes beforehand though dont you?

Drakla

Nope.

I use mysql_escape_string for data going in, which is as near as dammit the same as addslashes - but only using if for form data after checking get_magic_quotes_gpc is false. If it's set you can just throw the data straight in without escaping.

So if you weren't checking magic quotes - and it was on and you then did addslashes or mysql_escape_string you would have to use stripslashes - but only because the data would be going in addslashed twice.

The only necessary time to use stripslashes when pulling data from a db is when magic_quotes_runtime is on, is near enough never.

Weedpacket

Urk; too much magic :bemused:🙂
Personally I leave them off: it's easier to remember to add slashes to data that needs it than it is to remove slashes from data that doesn't.