Need Help with Multiple Row Insert

natesdad

Hello.
I have a query and it kinda works.
The last line gets inserted only.

Can someone see if they can figure out why it is not working.

It does not return any php errors. The only problem is Row 3 is the only data that makes it to the database. I would like Row 1, Row2 and Row3 to make it.

Thank you! I have abbreviated the code to just the goof.

<?php
if ($submit):

for ($y=0; $y<count($REQUEST['cid']); $y++)
{
$sql = "INSERT INTO tblData (EID, CID, SID, Date, Time, Description)
VALUES ('$id', '".$REQUEST['cid'][$y]."','".$REQUEST['sid'][$y]."','".$REQUEST['date'][$y]."','".$REQUEST['time'][$y]."','".$REQUEST['desc'][$y]."')";

}

if (@($sql)) {
echo("<p>New Batch Added</p>");
} else {
echo("<p>Error adding new Issue: " .
mysql_error() . "</p>");
}

<?php
else:
?>
<form action="<?=$PHP_SELF?>" method="post" class="infogrid">
<CENTER>
<TABLE WIDTH="600" CELLSPACING=0 CELLPADING=0 BORDER=1>

<TR>
<TD>Employee (Auto Insert)</TD>
<TD>Client</TD>
<TD>Service</TD>
<TD>Date</TD>
<TD>Time</TD>
<TD>Description</TD>
</TR>

<TR>
<TD width= 10></TD>
<TD><input type="text" name="cid[]" ...</TD>
<TD><input type="text" name="sid[]" ...</TD>
<TD><input type="text" name="date[]" ...</TD>
<TD><input type="text" name="time[]" ...</TD>
<TD><input type="text" name="desc[]" ...</TD>
</TR>

<TR>
<TD width= 10></TD>
<TD><input type="text" name="cid[]" ...</TD>
<TD><input type="text" name="sid[]" ...</TD>
<TD><input type="text" name="date[]" ...</TD>
<TD><input type="text" name="time[]" ...</TD>
<TD><input type="text" name="desc[]" ...</TD>
</TR>

<TR>
<TD width= 10></TD>
<TD><input type="text" name="cid[]" ...</TD>
<TD><input type="text" name="sid[]" ...</TD>
<TD><input type="text" name="date[]" ...</TD>
<TD><input type="text" name="time[]" ...</TD>
<TD><input type="text" name="desc[]" ...</TD>
</TR>

</TABLE>
<br>
<input type="submit" name="submit" value="SUBMIT" />
</form>
<?php endif; ?>

devinemke

<?php
if (!isset($_POST['submit']))
{
	echo '
	<form action="' . $_SERVER['PHP_SELF'] . '" method="post" class="infogrid">
	<CENTER>
	<TABLE WIDTH="600" CELLSPACING="0" CELLPADING="0" BORDER="1">
	<TR>
	<TD>Employee (Auto Insert)</TD>
	<TD>Client</TD>
	<TD>Service</TD>
	<TD>Date</TD>
	<TD>Time</TD>
	<TD>Description</TD>
	</TR>
	';

for ($i = 1; $i <= 3; $i++)
{
	echo '
	<TR>
	<TD width= 10></TD>
	<TD><input type="text" name="row[' . $i . '][cid]"></TD>
	<TD><input type="text" name="row[' . $i . '][sid]"></TD>
	<TD><input type="text" name="row[' . $i . '][date]"></TD>
	<TD><input type="text" name="row[' . $i . '][time]"></TD>
	<TD><input type="text" name="row[' . $i . '][desc]"></TD>
	</TR>
	';
}

echo '
</TABLE> 
<br>
<input type="submit" name="submit" value="SUBMIT" />
</form>
';
}
else
{
	// connect to db first!

foreach ($_POST['row'] as $value)
{
	$sql = "INSERT INTO tblData SET 
	CID = '" . $value['cid'] . "',
	SID = '" . $value['sid'] . "',
	Date = '" . $value['date'] . "',
	Time = '" . $value['time'] . "',
	Description = '" . $value['desc'] . "'";

	$result = mysql_query($sql) or exit(mysql_error());
	echo '<p>New Batch Added</p>';		
}
}
?>

natesdad

I will work with this! I really appreciate your help.

Thank you again,
Stephen

jdaggs

Please see my comments below.

Here is the key issue.:

}

Remember, at this point the loop has completed. Although you have assigned some text to $sql several time. Only the last query assigned to $sql gets executed below. @ needs to be placed inside of the loop. So that it is executed after each iteration in the loop. Otherwise all previous assignments to $sql are overwritten before they are executed as queries.

if (@($sql)) {
echo("<p>New Batch Added</p>");
} else {
echo("<p>Error adding new Issue: " .
mysql_error() . "</p>");
}

PHP is doing exactly what you told it to do. Loop n times and execute a SQL query exactly one time only after leaving the loop. This is why no error was issued. It's a semantic error rather than syntactic.