Update help

Jason_Batten

Hey all,

I have just created a edit article page. On my article page in my admin section I can click 'edit' and it loads the selected article into the edit article page, everything works well except that when I update the article it not only up dates the current article but every other article to the content of the article I was updating, in other words it over rides the other articles with the one I was updating.

$update = "UPDATE articles SET title = '$title',summary = '$summary',section = '$section',article = '$article'";

Thats the update code above, I know its the fact that I haven't said edit the certain "ID" of the article. But I don't know how to say edit this article alone. I have tried whacking 'WHERE ID = ".$_GET['ID']' on the end but no go.

Pwease help 🙁

devinemke

unless you specify a WHERE clause in your query, the UPDATE query will update all of the records. your syntax should look like:

UPDATE table SET 
field1 = 'value1'
field2 = 'value2'
field3 = 'value3'
WHERE somefield = 'somevalue'

kburger

You left out the where clause. You'll need to have a hidden field in your form named 'id' with a value of the id of the article being edited. Your update statement would then be:

$update = "UPDATE articles SET title = '$title',summary = '$summary',section = '$section',article = '$article' WHERE id='$id'";

Jason_Batten

Thanks guys for the help, fixed the problem but...

I cant seem to edit the section. The section is in a drop down list.

<select name=section ID=section value=$section>";
$result = $connectto->query('SELECT ID,name FROM sections');
while ($row = $connectto->fetchArray($result))
{echo '<option value="'.$row['ID'].'">'.$row['name'].'</option>';}

I have tried placing the $section in many places, is it because I am using a drop down box?

Cheers

kburger

Looks like you're incorrectly using a <select> form tag. Here's the basic syntax:

<select name="somename">
  <option value="1">1</option>
  <option value="2">2</option>
</select>

The possible values for $somename are, in this case, either "1" or "2". The "value" doesn't go inside the <select> tag. It goes inside an <option> tag.

Jason_Batten

Thanks for the help mate but the $section was in the right place I just couldn't tell what section the article was under. I quickly wrote up a script to display the section and was editing articles. The section changed when I edited the file and I had to slap myself because there is no </option> tag :o

kburger

This is wrong: <select name=section ID=section value=$section>

There is no 'value' attribute that goes inside the <select> tag. Also, the closing </option> tag is optional.

Jason_Batten

Hey all, The other day I got my script to update perfectly using the code below and since I have asked my host to turn off resgister globals but now my script doesn't work. Can anyone tell me why? I added the mysql_affected_rows() code to it and it updates 0 please help if you can. Sorry for the messy code but thats the whole editarticle.php file. I get it to display the article in the fields so it can be edited. Like I said worked fine before I turned off register globals.

if ($_GET['action'] == 'edit')
{
  $_POST['name'];
  $_POST['descrip'];
  $_POST['group'];
  $_POST['article'];

if ($lookat->foundErrors())

{
    echo 'There was a problem with: <br>'.$lookat->listErrors('<br>');

}else{

$edit = "UPDATE articles SET name = '$name',descrip = '$descrip',group = '$group',article = '$article' WHERE ID = '$ID'";

if ($found = $connect->query($edit))

{
echo 'Article edited. <a href="articles.php">Back to articles index</a><br>';
printf ("Updated records: %d\n", mysql_affected_rows());

}else{

exit('There was an error saving to the database');

}

}

}

{

$found = $connect->query("SELECT ID,name,descrip,group,article FROM articles WHERE ID = ".$_GET['ID']);

while ($row = $connect->fetchArray($found))

{
    $ID = $row['ID'];
    $name = $row['name'];
    $descrip = $row['descrip'];
    $group = $row['group'];
    $article = $row['article'];

echo "<form method=post action=editArticles.php?action=update&ID=$ID>";

echo "<table border=0 cellspacing=0 cellpadding=5><tr><td width=110>Article:</td>
<td><input type=text size=25 ID=name name=name value=\"$name\"></td></tr>";

echo "<tr><td>Article:</td><td><input type=text size=50 ID=descrip name=descrip value=\"$descrip\"></td></tr>";

echo "<tr><td>Group:</td><td><select name=group ID=group value=$group>";

$found = $connect->query('SELECT ID,name FROM sections ORDER BY name');
while ($row = $connect->fetchArray($found))
{echo '<option value="'.$row['ID'].'">'.$row['name'].'</option>';}

echo "</td></tr>";

echo "<tr><td valign=top>Article Text:</td>
<td><textarea rows=18 cols=50 ID=article name=article>$article</textarea></td></tr>";

echo "<tr><td></td><td align=right><input type=reset value=Clear Form>&nbsp;
&nbsp;<input name=submit type=Submit value='Update Article'></td></tr></table></form>";

  }
}
?>

I have been trying to sort it out the past 6 hours 🙁

Weedpacket

These lines

$_POST['name'];
$_POST['descrip'];
$_POST['group'];
$_POST['article'];

Aren't doing anything. You're wanting to put their values into variables $name, $descrip, $group, and $article, right?

$name = $_POST['name'];
$descrip = $_POST['descrip'];
$group = $_POST['group'];
$article = $_POST['article'];

Now would also be a good time to use mysql_real_escape_string, and other validation to ensure that only sensible data is being inserted.

Jason_Batten

Alright so I didn't post the exact source, those pieces of code are being checked to see if they are text etc.

if ($_GET['action'] == 'update'){

  $check->checkTextOnly($_POST['name'], 'Article Name');
  $check->checkTextOnly($_POST['descrip'], 'Descrip');
  $check->checkNumber($_POST['group'], 'Group');
  $check->checkGeneral($_POST['article'], 'Article');

  if ($check->foundErrors()){

echo 'There was a problem with: <br>'.$check->listErrors('<br>');

  }else{

$edit = "UPDATE articles SET name = '$name',descrip = '$descrip',group = '$group',article = '$article' WHERE ID = '$ID'";

if ($result = $connectdb->query($edit))

The code still doesn't update with the changes you made. It use to update with the above code added in. But what could have happened to stop it working?

Jason_Batten

Thanks to your help weedpacket and some people at phpfreaks.com I was able to fix my code.

Was missing the above a $ID in UPDATE should have been .$_GET['ID'] 😃