Modify Existing Records

raustin

I have a modify page set-up to make changes to existing records in the db, but for some reason, it does not change anything; it just re-loads the existing data:

<?
$sql = mysql_query("SELECT * FROM openhouse WHERE id = ('$GET[id]')");
while ($row = mysql_fetch_array($sql))
{
$field_one = $row['area'];
$field_two = $row['address'];
$field_three = $row['details'];
}
?>
<table width="714" border="0" cellspacing="0" cellpadding="0">
<tr>
<td width="291"><H1>Modify an Entry</H1></td>
<td width="423"><a href="adminhouse5.php">Add New Listing</a> </td>
</tr>
</table>
<br>
<form name="form1" method="post" action="">
<table width="709" border="0" cellspacing="3" cellpadding="3">
<tr>
<td width="86">Area: </td>
<td width="602"><select name="field_one" size="1" id="field_one">
<option value="<? echo $field_one; ?>"><? echo $field_one; ?></option>
<option>Area 1</option>
<option>Area 2</option>
<option>Area 3</option>
<option>Area 4</option>
<option>Area 5</option>
<option>Area 6</option>
<option>Area 7</option>
<option>Area 8</option>
<option>Area 9</option>
<option>Area 10</option>
<option>Area 11</option>
<option>Area 12</option>
<option>Area 13</option>
<option>Area 14</option>
<option>Area 15</option>
<option>Area 16</option>
<option>Area 17</option>
<option>Area 18</option>
<option>Area 19</option>
<option>Other Area</option>
</select></td>
</tr>
<tr>
<td>Address: </td>
<td><input name="field_two" type="text" id="field_two" value="<? echo $field_two; ?>
" size="100"></td>
</tr>
<tr>
<td>Details: </td>
<td><input name="textfield" type="text" value="<? echo $field_three; ?>" size="100"></td>
</tr>
<tr>
<td colspan="2"><div align="right">
</div>
<div align="right">
<input type="submit" name="Submit" value="Modify Data">
</div></td>
</tr>
</table>
</form>
<?
if ($GET['update'] > 0)
{
mysql_query("UPDATE openhouse SET field_one = ('$POST[field_one]') WHERE id = '$GET[update]'") or die ( mysql_error() );
mysql_query("UPDATE openhouse SET field_two = ('$POST[field_two]') WHERE id = '$GET[update]'") or die ( mysql_error() );
mysql_query("UPDATE openhouse SET field_three = ('$POST[field_three]') WHERE id = '$GET[update]'") or die ( mysql_error() );
mysql_query("UPDATE openhouse SET field_five = now() WHERE id = '$_GET[update]'") or die ( mysql_error() );

echo "Fields Updated";
}
?>
<br>

Any thoughts?

devinemke

2 things:

you don't want/need 3 UPDATE queries. you only need 1 and it should look something like:

mysql_query("UPDATE openhouse SET 
area = '" . $_POST['field_one'] . "', 
address = '" . $_POST['field_two'] . "', 
details = '" . $_POST['field_three'] . "'  

WHERE id = '" . $_GET['id'] . "'") or exit(mysql_error());

you are running the SELECT first then the UPDATE second so when you run this code you will still see the old data.

raustin

SO reverse the select and the update? Shouldn't the fields be populated before they are modified?

devinemke

here's the basic idea in pseudo-code:

<?php
connect to the database

if (the form has been submitted)
{
	run the UPDATE query
}
else
{
	run the SELECT query
	display the form
}
?>

raustin

ok; here's what i got:

<?
if ($POST['Submit'] > 0)
{
mysql_query("UPDATE openhouse SET field_one = ('$POST[field_one]'),
field_two = ('$POST[field_two]'),
field_five = now()
WHERE id = '$GET[update]'") or die ( mysql_error() );

echo "Fields Updated";
}
else
{
$sql = mysql_query("SELECT * FROM openhouse WHERE id = ('$_GET[id]')");
while ($row = mysql_fetch_array($sql))
{
$field_one = $row['area'];
$field_two = $row['address'];
}

?>
<table width="714" border="0" cellspacing="0" cellpadding="0">
<tr>
<td width="291"><H1>Modify an Entry</H1></td>
<td width="423"><a href="adminhouse5.php">Add New Listing</a> </td>
</tr>
</table>
<br>
<form name="form1" method="post" action="">
<table width="709" border="0" cellspacing="3" cellpadding="3">
<tr>
<td width="86">Area: </td>
<td width="602"><select name="field_one" size="1" id="field_one">
<option value="<? echo $field_one; ?>"><? echo $field_one; ?></option>
<option>Area 1</option>
<option>Area 2</option>
<option>Area 3</option>
<option>Area 4</option>
<option>Area 5</option>
<option>Area 6</option>
<option>Area 7</option>
<option>Area 8</option>
<option>Area 9</option>
<option>Area 10</option>
<option>Area 11</option>
<option>Area 12</option>
<option>Area 13</option>
<option>Area 14</option>
<option>Area 15</option>
<option>Area 16</option>
<option>Area 17</option>
<option>Area 18</option>
<option>Area 19</option>
<option>Other Area</option>
</select></td>
</tr>
<tr>
<td>Address/Details: </td>
<td><input name="field_two" type="text" id="field_two" value="<? echo $field_two; ?>
" size="100"></td>
</tr>
<tr>
<td colspan="2"><div align="right">
</div>
<div align="right">
<input type="submit" name="Submit" value="Modify Data">
</div></td>
</tr>
</table>
</form>
<br>
<hr>
<br>
<table width="100%" border="0" cellpadding="5">
<tr>
<td><h2>Current Listings:
</h2>
<br>
<?

// Delete Row
if ($GET['delete'] > 0) {
$sql = mysql_query("DELETE FROM openhouse WHERE id = '$GET[delete]' ") or die ( mysql_error());
echo "Row Deleted";
}
// Start Table
echo ("<table width=100% border=1 cellpadding=1 cellspacing=1 >
<tr>
<td width=2%>id</td>
<td width=5%><b>Area</b></td>
<td width=20%><b>Address</b></td>
<td width=7%>Modify</td>
<td width=5%>Delete</td>
</tr>");

$sql = mysql_query("SELECT * FROM openhouse") or die ( mysql_error() );
while ($row = mysql_fetch_array($sql)) {
echo "<TR>"."<TD>".$row['id']."</TD>"."<TD>".$row['area']."</TD><TD>".$row['address']
."</TD>"; // Display Fields
// Display Commands
// Modify
echo "<TD>"."<A HREF=modify.php?id=".$row['id'].">"."Modify"."</a> </TD>";
// Delete
echo "<TD>"."<A HREF=?delete=".$row['id'].">"."Delete"."</a> </TD>";
echo " </TR>";
}
echo "</TABLE>"; // end table
?>
</td>
</tr>
</table>

I'm getting an error message:
Parse error: parse error, unexpected $ in:
html/openhouse/modify.php on line 125

devinemke

you are missing a closing bracket "}" after your first else clause

raustin

OK thanks.

Now the form is not loading the item to be modified. Am I just retarded?

raustin

apparently so...

liquorvicar

are you seeing the form displayed?
if not, try changing

if ($_POST['Submit'] > 0)

if (isset($_POST['Submit']))