PHP Upload script

cmdr_bond

Hello,

I am trying to make a button on my website that uploads a picture to my website. I have the following code and it's not working:

(the image in the form is 'upimage')

    $tmp = explode ( '.', $_FILES['upimage']['name']);
    $fileext = $tmp[count($tmp)-1];
    $allowedexts = array("gif", "jpg");
$upload_dir = "/images/";
	$temp_name = $_FILES['upimage']['tmp_name'];
	$file_name = $_FILES['upimage']['name']; 
  $file_name = str_replace("\\","",$file_name);
  $file_name = str_replace("'","",$file_name);
	$file_path = $upload_dir.$file_name;

if (in_array($fileext, $allowedexts)) {
copy ($_FILES['upimage']['tmp_name'],$file_path) or die ('Could not upload'); 

	echo "Received {$_FILES['upimage']['name']} - its size is {$_FILES['upimage']['size']} with extension $fileext";

} else {
echo "You must upload a gif or jpg file.";
}

For some reason it's not uploading the picture and is instead just giving me an error message. Can you please tell me what's wrong with this?

Thanks

bpat1434

Well, what is the error? I'm guessing its a Parse Error or T_ENCAPSED_STRING.

I can only see one thing:

$file_name = str_replace("\","",$file_name);

Your best bet right there, is to use:
$file_name = stripslashes($file_name);

Right now, you're escaping from PHP so that your string never really closes:

$file_name = str_replace(
" // Opens String
\" // Still in a string
, " // Closes string
" // Opens string
,$file_name); // String never ends.....

So you see, you're converting the rest of your code to a string (not what you want). Just remove that line, and replace it with what I suggested and it should work.

This is where using a syntax highlighting editor is nice. You can see right away that something is awry, and find it. I would suggest EditPlus if you don't have one. It's lightweight, and you can update the syntax files for PHP 5, or 4 whichever you use. Also works with HTML, Java, JavaScript, C, C#, PERL, you get the picture.

~Brett

cmdr_bond

Thanks for the prompt response. I seem to be getting this error:

Warning: copy([specified location]/[uploaded file name]): failed to open stream: Permission denied in [webpage that i'm in]

What does that mean?

bpat1434

Make sure that you gave permission for everyone to write to the destination folder ("/images/file.gif"). Make sure CHMOD is 777 (or, if doing it from a PHP script: 0777).

Also, copy will just copy it, perhaps move_uploaded_file() would work better in this instance as it won't put two of the same file in two different areas (which what you currently have will).

~Brett

cmdr_bond

Okay, that works great, thanks