help!

[stezz]

Hey everyone... im really stumped on this one. I don't understrand why it won't work.

$offset = $_GET['offset'];

if(!isset($offset)) {

$offset = 0;

}

$limit = 10;

$result = mysql_query("SELECT * FROM newrepublic_mbs WHERE parent_id = 0 AND FID = '$BID' ORDER BY PID DESC LIMIT $offset, $limit;");
$num_rows = mysql_num_rows($result);

if($num_rows) {

if ($offset != 0) {

	$offset = $offset - $limit;
	echo "<a href=\"$PHP_SELF?BID=$BID&offset=$offset\"><< Prev</a> :: ";

}

if (($limit < $num_rows) || ($offset < $num_rows)) {

	$offset = $offset + $limit;
	echo " :: <a href=\"$PHP_SELF?BID=$BID&offset=$offset\">Next >></a>";

}

// rest of code here

}

Ok.. first off.. I want 10 results displayed per page... if there are 3 results in total... the "next" link appears anyway. Why? Also... the value of $offset will increase by $limit when it's first clicked, but when I click it again, the value of $offset stays the same (which would be the increase of $limit). Why is this happening? What am I doing wrong?

[bodzan]

Statement:

if (($limit < $num_rows) || ($offset < $num_rows)) { 

will be true in following cases:
1. $num_rows is bigger than 10
2. $offset is smaller than $num_rows i.e on the first page where $offsset is not set and therefore is 0 it will allways be true (even if there are only 3 results in total)...

I guess that the 2. case is undesired behaviour...

Let's analyze what happens if the $offset is set to 10:
$limit is set to 10
In the if statement:

 if ($offset != 0) {

    $offset = $offset - $limit;
    echo "<a href=\"$PHP_SELF?BID=$BID&offset=$offset\"><< Prev</a> :: ";

} 

$offset is set to 0 again making the previously mentioned if statement true because $offset will again be smaller than $num_rows...

Hope this helps...

[bpat1434]

Please, try and post more informative subjects. Read the sticky for proper "etiquette".

Now, looking at your construction, you have a flaw in your logic:

if the $limit is less than $num_rows OR the offset is less than $num_rows then show the next button.

Perhaps it should be:
$last_row = $offset+$limit;
if( $last_row<$num_rows ){
// Display next button
}

Now, the offset problem. You use the same variable twice, and add and subtract the same amount. You might want to use:

<?php
$offset = $_GET['offset']; 

if(!isset($offset)) { 

$offset = 0; 

} 

$limit = 10; 

$result = mysql_query("SELECT * FROM newrepublic_mbs WHERE parent_id = 0 AND FID = '$BID' ORDER BY PID DESC LIMIT $offset, $limit;"); 
$num_rows = mysql_num_rows($result); 

if($num_rows) { 
    $nxtoffset = $offset + $limit;

if ($offset != 0) { 

    $prevoffset = $offset - $limit; 
    echo "<a href=\"$PHP_SELF?BID=$BID&offset=$prevoffset\"><< Prev</a> :: "; 

} 

if ($nxtoffset<$num_rows){ 
    echo " :: <a href=\"$PHP_SELF?BID=$BID&offset=$nxtoffset\">Next >></a>"; 

} 

// rest of code here 

}
?>

~Brett

[stezz]

Thanks very much both for your help! I've managed to get it working correctly now.

Thanks again.

Stezz.