Newbie Loop Problem!

matt2012

Ok what I need to do is get a load of html which is in a string called $thoriginalhtml
and perform a procedure on it 5 times to strip it of some annoying code that appears between .jpg and " actually ?+14 random numbers. If I use the code below without the loop it performs the procedure for the first instance of a .jpg?6286482364826846832" turning it into .jpg" but leaves all the others. I tried to solve this by creating this loop to do the procedure 5 times, but this is doing exactly the same thing. Can someoe help me with this?

$times = 5;
$x = 0;

$themodifiedhtml1 = $theoriginalhtml;
while ($x < $times) {
$themodifiedhtml = $themodifiedhtml1;
$probs = between('.jpg', '"', $themodifiedhtml);
$themodifiedhtml1 = str_replace($probs, '', $themodifiedhtml);
++$x;
}
echo $themodifiedhtml1;?>

bradgrafelman

EDIT: I now see I was completely incorrect with my first solution, so I've removed it Let me review your code further...

EDIT2: Looks like you want a simple eregi_replace? Get rid of all that code and try this:

$themodifiedhtml1 = eregi_replace('\\.jpg?[0-9]+"', '\\.jpg?"', $theoriginalhtml);

That will take everything that looks like .jpg?34235135234" and turn it into .jpg?". If you dont want the ending question mark, change '.jpg?"', to '.jpg"',. The new HTML was stored in $themodifiedhtml1 in my example. Feel free to tweak the variable names to your liking.

matt2012

Thats great bradgrafelman. Ive got it working. This place is amazing the problem was only up 5 minutes. I had to make a few changes,
the actual change needed was
from ".jpg?0.1123121.." to ".jpg"
strangley I needed to put a dot before the 0 even though there isnt one in the code. I wonder if anyone knows why this is?

$modified = eregi_replace('.jpg?.0.[0-9]+', '.jpg', $original);

anyway thanks again!

Matt.

bradgrafelman

Glad you got it working. I'm new to regular expression, but I'm happy to see it sent you in the right direction 😉

BTW, did you use the "Mark Thread Resolved (thread starter only)" link at the bottom of this page? I'd never seen that there, myself.

jkurrle

Why not use some sort of explode() function, using the question mark as the deliminator?

example:

$picture="xyz123.jpg?8974r9287439287";
$array=explode("?",$picture);
$picture=array_shift($array);

Bada-Bing, Bada-Boom, you have your picture name and everything after the question mark is stripped out...