alot of ||

[lesmith]

Hello Peeps

I want to carry out alot of Or statements. Is there a quick way to do it.

ie.
if ( ($item == "XX") || ($item == "YY") || ($item == "ZZ") (etc) (etc) ){
do this
}else{
dothis
}

Is there a quicker way of doing this because i have alot of Or's to check.

Regards

Lee

[devinemke]

[man]switch[/man]

[lesmith]

I knew you was going to say that.

I was hoping of a quicker and cleaner code than switch. !!

Any other ideas ?

Regards

Lee

[devinemke]

Originally posted by lesmith
I was hoping of a quicker and cleaner code than switch. !!
Any other ideas ?

no

[bradgrafelman]

If you are checking the same variable for different values over and over, definitely use the switch() as devinemike said. (Read the link if you don't know how)

If you read it well enough, you'll be able to easily set up a switch() statement to do sets of commands based on various values, ending in a sort of "catch-all" set of commands that will be executed if the value doesn't match one you've listed.

Otherwise.... have fun writing many if's. :/

[lesmith]

I understand switch Fine

I ws just wondering if there is a quicker way I have alot to check through.

No probs

Regards

Lee

[bradgrafelman]

Hmm 🙁

Would it be easier/shorter to check if the variable is NOT equal to certain values?

[lesmith]

Its ok thanks

You did help. I did check out the switch method again and I did find a quick way with switch ie.

switch ( $lead->state ){
			case "Alabama" :
			case "Arkansas" :
			case "Florida" :
			case "Illinois" :
			case "Massachusettes" :
			case "Mississippi" :
			case "Montana" :
			case "Nebraska" :
			case "North Dakota" :
			case "South Carolina" :
			case "Tennessee" :
			case "Texas" :
			case "Virginia" :
			case "Wisconsin" :
			$template->set_var('STATE', '<span style="color:#FF0000">' . $lead->state . '</span>');  //$lead->state
			break;
			default:
			$template->set_var('STATE', $lead->state);
		}

Thanks for your help

Lee

[Weedpacket]

Y'know, seeing as there are only two branches to take, it can be simplified somewhat:

$states = array(
	"Alabama",
	"Arkansas",
	"Florida",
	"Illinois",
	"Massachusetts",
	"Mississippi",
	"Montana",
	"Nebraska",
	"North Dakota",
	"South Carolina",
	"Tennessee",
	"Texas",
	"Virginia",
	"Wisconsin");

if(in_array($lead->state, $states))
{
	$template->set_var('STATE', '<span style="color:#FF0000">' . $lead->state . '</span>');  //$lead->state
}
else
{
	$template->set_var('STATE', $lead->state);
}

And it's probably possible (depending on your application's architecture) to put the array somewhere that it can be used in other situations as well (presumably there is a reason why you want those particular states highlighted, hence there must be somewhere else where the same list is applicable).

PS: You don't mind if I correct the spelling of "Massachusetts", do you?

[sysera]

Originally posted by Weedpacket


PS: You don't mind if I correct the spelling of "Massachusetts", do you?

I don't mind at all. 😃

[lesmith]

Hey Guys

Thanks for the great response on this.

I knew there was a better way. I dit first try putting it into an array but did not not work out the way you have dont it.

Thank you very much.

Great work

Lee

PS no I dont mind the correction. I only copied paste from somewhere else !!!

Lee

[Drakla]

Take note of that array method for future use - I use it for validating form data, as you can have an array of fields that have to be filled in, ones that have to be numeric, ones that have to have minimum lengths (for which I use an associative array of fields => minLength)

It's the difference between an ugly page full of ifs and a nice foreach.