IF Query

amo

Quick question guys

I am just trying to create a simple login but the IF loop is giving me a bit of trouble.

I have two fields (accountref and pin) I am trying to implement a loop that will say IF accountref and pin are in my database then direct to one page ELSE direct back to login.php. How do I do this??

Many thanks

travelbuff

amo:

IF isn't a loop - it is a conditional. WHILE is a loop.

What you are doing is user authentication, and if you are going to do it right there is more to it than can be put in a single forum post. I strongly suggest that you take one of the user authentication tutorials on hostscripts.

amo

Here is my code:

<?php
   extract($_POST);
   //Extracts values using the post method
   setcookie("accountref",$accountref,time()+1200);
   setcookie("pin",$pin,time()+1200);
   //Set cookie values for 1200 seconds
?>
<html>
	<head>
    	<title>Welcome</title>
   	</head>
   	<body>
		<?php
			//Connect to database
			$location = "localhost";
			$username = "root";
			$password = "";
			$database = "onlinetax";
			$conn=@mysql_connect("$location","$username","$password");
			if (!$conn) die ("Error: Could not connect to database server.");
			@mysql_select_db($database,$conn) or die ("Error: Could not open database.");
			extract($_POST);
			//Check if fields passed from the login screen are valid
			//If not then they are redirected to the login screen
			if (isset($accountref) && isset($pin) && $accountref != "" && $pin != "")
			{
				$query = "SELECT * FROM user WHERE username = '$accountref' AND password = '$pin'";
				$result = mysql_query($query);
				if ($row = @mysql_fetch_array($result))
				{				

			{?>
				<h1>Welcome you are logged in as <?print($accountfef)?><br>Proceed to the Book Store</h1>
				<a href="test.php"></a>
				<form method="post" action="testing.php" target="_self">
					<p>
						<input type="submit" value="Continue"/>
					</p>
				</form>
			?>				

		}

		else
		//If not sucessful redirect back to login screen
  	  	{	<?
				<h1>Incorrect Login Details</h1>
				<form method="post" action="login.php" target="_self">
					<p>
						<input type="submit" value="Re-try?"/>
					</p>
				</form>
			?>

		}
		//Close connection to server
		@$disconn=mysql_close($conn);
		if (!$disconn) die ("Error: Unable to disconnect from database server.");
</body>
</html>

Does this help I know its almost right.

This is the error I am getting:

Parse error: parse error in c:\program files\apache group\apache\htdocs\welcome.php on line 47

thorpe

after your query you have this;

if ($row = @mysql_fetch_array($result)) 
{                 

{?>

see the last {, its around the wrong way. should be }

amo

OK I got the code sorted. I know what the problem is I have got too many "<?" I am getting a bit confused.


<?php
   extract($_POST);
   //Extracts values using the post method
   setcookie("accountref",$accountref,time()+1200);
   setcookie("pin",$pin,time()+1200);
   //Set cookie values for 1200 seconds
?>
<html>
    <head>
        <title>Welcome</title>
       </head>
       <body>
        <?php
            //Connect to database
            $location = "localhost";
            $username = "root";
            $password = "";
            $database = "onlinetax";
            $conn=@mysql_connect("$location","$username","$password");
            if (!$conn) die ("Error: Could not connect to database server.");
            @mysql_select_db($database,$conn) or die ("Error: Could not open database.");
            extract($_POST);

        //Check if fields passed from the login screen are valid
        //If not then they are redirected to the login screen
        if (isset($accountref) && isset($pin) && $accountref != "" && $pin != "")
        {
            $query = "SELECT * FROM user WHERE username = '$accountref' AND password = '$pin'";
            $result = mysql_query($query);
            if ($row = @mysql_fetch_array($result))
            {                

            {<?
                <h1>Welcome you are logged In Proceed to the Personal Details Page</h1>
                <a href="testing.php"></a>
                <form method="post" action="testing.php" target="_self">
                    <p>
                        <input type="submit" value="Continue"/>
                    </p>
                </form>
            ?>                

        }

        else
        //If not sucessful redirect back to login screen
            {    <?
                <h1>Incorrect Login Details</h1>
                <form method="post" action="login.php" target="_self">
                    <p>
                        <input type="submit" value="Re-try?"/>
                    </p>
                </form>
            ?>

        }
        //Close connection to server
        @$disconn=mysql_close($conn);
        if (!$disconn) die ("Error: Unable to disconnect from database server.");
</body>
</html>

Should I add or delete one?

It says my error is on line 33 which is:

                {<?
                    <h1>Welcome you are logged In Proceed to the Personal Details Page</h1>

I know it is the opening <? bracket that is the problem I just dont know what to do about it, if that makes sense!!??

pohopo

Like thorpe said, your bracket is facing the wrong way and in the wrong place. here it is fixed below..

            //Check if fields passed from the login screen are valid
            //If not then they are redirected to the login screen
            if (isset($accountref) && isset($pin) && $accountref != "" && $pin != "")
            {
                $query = "SELECT * FROM user WHERE username = '$accountref' AND password = '$pin'";
                $result = mysql_query($query);
                if ($row = @mysql_fetch_array($result))
                {                

                  <?
                    <h1>Welcome you are logged In Proceed to the Personal Details Page</h1>
                    <a href="testing.php"></a>
                    <form method="post" action="testing.php" target="_self">
                        <p>
                            <input type="submit" value="Continue"/>
                        </p>
                    </form>
                  ?>                

                } // <-<-<- fixed
            }

amo

Thanks pohopo and thorpe

I am still having an error saying that this particular line is a problem. I know that there is an open php bracket before the check connection code. However there is no close php bracket before the next open bracket which is this line of code that is giving the error.

My code is:

<?php
   extract($_POST);
   //Extracts values using the post method
   setcookie("accountref",$accountref,time()+1200);
   setcookie("pin",$pin,time()+1200);
   //Set cookie values for 1200 seconds
?>
<html>
    <head>
        <title>Welcome</title>
       </head>
       <body>
        <?php
            //Connect to database
            $location = "localhost";
            $username = "root";
            $password = "";
            $database = "onlinetax";
            $conn=@mysql_connect("$location","$username","$password");
            if (!$conn) die ("Error: Could not connect to database server.");
            @mysql_select_db($database,$conn) or die ("Error: Could not open database.");
            extract($_POST);

            //Check if fields passed from the login screen are valid
            //If not then they are redirected to the login screen
            if (isset($accountref) && isset($pin) && $accountref != "" && $pin != "")
            {
                $query = "SELECT * FROM user WHERE username = '$accountref' AND password = '$pin'";
                $result = mysql_query($query);
                if ($row = @mysql_fetch_array($result))
                {                
                  <?
                    <h1>Welcome you are logged In Proceed to the Personal Details Page</h1>
                    <a href="testing.php"></a>
                    <form method="post" action="testing.php" target="_self">
                        <p>
                            <input type="submit" value="Continue"/>
                        </p>
                    </form>
                  ?>                
                }
            }


        else
        //If not sucessful redirect back to login screen
            {    <?
                <h1>Incorrect Login Details</h1>
                <form method="post" action="login.php" target="_self">
                    <p>
                        <input type="submit" value="Re-try?"/>
                    </p>
                </form>
            ?>

        }
        //Close connection to server
        @$disconn=mysql_close($conn);
        if (!$disconn) die ("Error: Unable to disconnect from database server.");
</body>
</html>

the line with the error is:

                      <?
                        <h1>Welcome you are logged In Proceed to the Personal Details Page</h1>

the opening bracket is line 32 (the line with the error on)

Any help is much appreciated

thorpe

I know that there is an open php bracket before the check connection code. However there is no close php bracket before the next open bracket

well fix it...

amo

Hi thorpe I think i fixed the problem

<?php
   extract($_POST);
   //Extracts values using the post method
   setcookie("accountref",$accountref,time()+1200);
   setcookie("pin",$pin,time()+1200);
   //Set cookie values for 1200 seconds
?>
<html>
	<head>
    	<title>Welcome</title>
      	<link rel="stylesheet" type="text/css" href="bookshop.css"/>
   	</head>
   	<body>
		<?php
			//Connect to database
			$location = "localhost";
			$username = "root";
			$password = "";
			$database = "onlinetax";
			$conn=@mysql_connect("$location","$username","$password");
			if (!$conn) die ("Error: Could not connect to database server.");
			@mysql_select_db($database,$conn) or die ("Error: Could not open database.");
			extract($_POST);
			//Check if fields passed from the login screen are valid
			//If not then they are redirected to the login screen
			if (isset($accountref) && isset($pin) && $accountref != "" && $pin != "")
			{
				$query = "SELECT * FROM user WHERE accountref = '$accountref' AND pin = '$pin'";
				$result = mysql_query($query);
				if ($row = @mysql_fetch_array($result))
					{?>
						<h1>Welcome you are logged in as <?print($accountref)?><br>Proceed to the Personal Details Page</h1>
						<a href="testing.php"></a>
						<form method="post" action="testing.php" target="_self">
						<p>
							<input type="submit" value="Continue"/>
						</p>
							</form><?
					}
				else
					{?>
						<h1>Incorrect Login Details</h1>
						<form method="post" action="login.php" target="_self">
						<p>
							<input type="submit" value="Re-try?"/>
						</p>
							</form><?
					}
			?>
	</body>
</html>

it is now saying that the error is in my final line of code i.e. </html>

Why would this be??

travelbuff

You have to close enclose every IF or ELSE conditional with { }.
At the end of the script you come back in to PHP and close the else from the
if ($row = @mysql_fetch_array($result))
conditional but the
if (isset($accountref) && isset($pin) && $accountref != "" && $pin != "")
statement is still open.

Since multiple levels of nested conditionals are common, when I write code I comment every single conditional
and go ahead and add the closing } before I even write the code that goes inbetween. Looks a bit newbish,
but saves a lot of debugging for me...

IF ($somecondition) { //check to see if true

} ELSE { //for IF ($somecondition)

} //close IF-ELSE ($somecondition)