newbie question

[natman3]

Cany anyone tell me why this would not work.

// login_user is for the login.php page checks user and pw and calls user set_user() to find access

function login_user($user, $password) {
	if ($user != "" && $password != "") {
		$this->user = $user;
		$this->user_pw = $password;
		// checks to see if user's pw is in the dba
		if ($this->check_user($this->user_pw)) {
			$this->login_saver();
			if ($this->count_visit) {
				$this->reg_visit($user, $password);
			}
			$this->set_user();
		} else {
			// Login and/or password did not match to the database
			$this->the_msg = $this->messages(10);
		}
	} else {
		// Login and/or password is empty!
		$this->the_msg = $this->messages(11);
	}
}

// this function compares the value in the divistionType if its college or highschool it goes to a different page

function set_user() {
		$_SESSION['user'] = $this->user;
		$_SESSION['pw'] = $this->user_pw;
		if (isset($_SESSION['referer']) && $_SESSION['referer'] != "") {
			$next_page = $_SESSION['referer'];
			unset($_SESSION['referer']);
		}
		$sql = sprintf("SELECT `divisionType` FROM %s WHERE BINARY login = '%s' AND pw = '%s' AND active = 'y'", $this->table_name, $this->user, $this->pass);
		$value  = mysql_query($sql); 
		if (isset($_SESSION['highschool'] == $value) { 
				header("Location: high_page.php");     

		} 
		else if (isset($_SESSION['college'] == $value) { 
				header("Location: college_page.php");     

		} 
		else {
			$next_page = $this->main_page;
		}
		header("Location: ".$next_page);
	}

[mtmosier]

Cany anyone tell me why this would not work.

I'm fairly certain someone can. It'd probably be easier to do if you'd share a little more information though. Like what errors you're receiving, if any. Expected behavior vs actual behavior.

[natman3]

i am not getting any errors i just get a blank page. So there is no real way i know how to start debugging I think it has to do with how i am selecting the field "divisionType" if i comment it out the code bellow the page loads fine.

		$sql = sprintf("SELECT `divisionType` FROM %s WHERE BINARY login = '%s' AND pw = '%s' AND active = 'y'", $this->table_name, $this->user, $this->pass);
		$value  = mysql_query($sql); 
		else if (isset($_SESSION['highschool'] == $value) { 
				header("Location: high_page.php");     

		} 
		else if (isset($_SESSION['college'] == $value) { 
				header("Location: college_page.php");     

		} 

[mtmosier]

For someone who doesn't know where to start debugging, you certainly did a good job of narrowing it down.

So, yeah, in those lines you're attempting to access the mysql result incorrectly. You should read the manual page for mysql_query. To help, here's an extract from the second example on that page. Pay attention to the comments.

// Perform Query
$result = mysql_query($query);

// Check result
// This shows the actual query sent to MySQL, and the error. Useful for debugging.
if (!$result) {
   $message  = 'Invalid query: ' . mysql_error() . "\n";
   $message .= 'Whole query: ' . $query;
   die($message);
}

// Use result
// Attempting to print $result won't allow access to information in the resource
// One of the mysql result functions must be used
// See also mysql_result(), mysql_fetch_array(), mysql_fetch_row(), etc.
while ($row = mysql_fetch_assoc($result)) {
   echo $row['firstname'];
   echo $row['lastname'];
   echo $row['address'];
   echo $row['age'];
}

[natman3]

I read the manual and understand i think how its to work but when i made the changes to my page. I still had a blank page and no errors displayed? Any suggestions? here is the modified code

function set_user() {
		$_SESSION['user'] = $this->user;
		$_SESSION['pw'] = $this->user_pw;
		if (isset($_SESSION['referer']) && $_SESSION['referer'] != "") {
			$next_page = $_SESSION['referer'];
			unset($_SESSION['referer']);
		}
		$query = sprintf("SELECT divisionType FROM users WHERE login = '%s' AND pw = '%s'", $this->table_name, $this->user, $this->pass);
		// Perform Query 
		$result = mysql_query($query); 

	// Check result 
	// This shows the actual query sent to MySQL, and the error. Useful for debugging. 
	if (!$result) { 
	   $message  = 'Invalid query: ' . mysql_error() . "\n"; 
	   $message .= 'Whole query: ' . $query; 
	   die($message); 
	} 

	// Use result 
	// Attempting to print $result won't allow access to information in the resource 
	// One of the mysql result functions must be used 
	// See also mysql_result(), mysql_fetch_array(), mysql_fetch_row(), etc. 
	while ($row = mysql_fetch_assoc($result)) { 
	   echo $row['divisionType']; 

	}

	else if (isset($_SESSION['highschool'] == $value) { 
			header("Location: high_page.php");     
	} 
	else if (isset($_SESSION['college'] == $value) { 
			header("Location: college_page.php");     
	} 
	else {
		$next_page = $this->main_page;
	}
	header("Location: ".$next_page);
}

[mtmosier]

echo $row['divisionType'];

I think you want to change that to this

$value = $row['divisionType'];

At least I imagine you don't really want to print that to the browser. You want to compare it in the if statements which follow.

Also, you seem to have an extra "else" in this line. (You shouldn't have an "else" starting this line unless it's in relation to an "if" statement before it.)

else if (isset($_SESSION['highschool'] == $value) {

That should have give you a parse error by the way. Perhaps you have error display turned off in your php.ini file?

[natman3]

Thank you for your suggestions. I am still though unable to resolve the issue. I am still getting a blank page with no errors to be displayed. In my php.ini i have errors turned on. Here is the modified code. My only though at this point is that I am somehow stating the

 if 

or

 else 

incorrectly or something with the query is incorrect.

function set_user() {
		$_SESSION['user'] = $this->user;
		$_SESSION['pw'] = $this->user_pw;
		if (isset($_SESSION['referer']) && $_SESSION['referer'] != "") {
			$next_page = $_SESSION['referer'];
			unset($_SESSION['referer']);
		}
		$query = sprintf("SELECT divisionType FROM users WHERE login = '%s' AND pw = '%s'", $this->table_name, $this->user, $this->pass);
		// Perform Query 
		$result = mysql_query($query); 

	// Check result 
	// This shows the actual query sent to MySQL, and the error. Useful for debugging. 
	if (!$result) { 
	   $message  = 'Invalid query: ' . mysql_error() . "\n"; 
	   $message .= 'Whole query: ' . $query; 
	   die($message); 
	} 

	// Use result 
	// Attempting to print $result won't allow access to information in the resource 
	// One of the mysql result functions must be used 
	// See also mysql_result(), mysql_fetch_array(), mysql_fetch_row(), etc. 
	while ($row = mysql_fetch_assoc($result)) { 
	 $value = $row['divisionType'];

	}

	if (isset($_SESSION['highschool'] == $value) { 
			header("Location: high_page.php");     
	} 
	else if (isset($_SESSION['college'] == $value) { 
			header("Location: college_page.php");     
	} 
	else {
		$next_page = $this->main_page;
	}
	header("Location: ".$next_page);
}

this though works fine and the page login will come up. with this code

function set_user() {
		$_SESSION['user'] = $this->user;
		$_SESSION['pw'] = $this->user_pw;
		if (isset($_SESSION['referer']) && $_SESSION['referer'] != "") {
			$next_page = $_SESSION['referer'];
			unset($_SESSION['referer']);
		} else {
			$next_page = $this->main_page;
		}
		header("Location: ".$next_page);
	}

but then i am not able to copare the divisionType to direct the user to the appropriate page

[mtmosier]

Okay, noticed a few more issues.

if (isset($_SESSION['highschool'] == $value) {

Your isset is out of place here. I imagine you want it to look like this

if (isset($_SESSION['highschool']) && $_SESSION['highschool'] == $value) {

The same goes for the next if statement you have.

You do also have an error in your query statement. I'm not sure if you're familiar with the workings of sprintf, but your query should only take two variables, user and password. You're giving it three (table name).

One bit of advice I also have. Whenever I do a header("Location: ..."), I always do an "exit();" immediately afterwards. This makes it so that the remainder of the page doesn't have to execute, possibly displaying html, which is just going to ignored with the redirect anyway. I mention it because when $value is either highschool or college, you'll end up doing two separate header calls (the second being "$next_page", when you only need the first one.

Oh, and I mentioned php.ini, but I wasn't specific about variables to look at. In specific you should have "error_reporting" set to "E_ALL", and "display_errors" set to "On".