Classes and MySQL help

Hexx

Hey all,
Well I got my other problem fixed (some include issues). It all works...but this is a NEW problem.

This is my first time writing up a class in php (never really had a use before).

Right now its a bit messy but check it out.

class News{

var $news;
var $rows;
var $id;
//DisplayNews shows just the table and news
//Can only be called when MySQL connection is called, which happens before this
function DisplayNews($news){
	echo" <table cellpadding=\"4\" cellspacing=\"1\" bgcolor=\"#000000\" style='width:100%;font-family:Verdana;font-size:12px;'>\n
				<tr>\n
		  			<td class=\"tablehead\" height=\"20\">\n
					<p><font color=\"#FFFFFF\"><strong>".$this->$rows[title]."</strong></font><br>\n
					<font color=\"#CCCCCC\">Posted By ".$rows[author]." on ". date("l dS of F Y @ h:i A", $rows[date])."</font></p></td>\n
				</tr>\n
				<tr>\n
		  		<td bgcolor=\"#FFFFFF\"><font color=\"#000000\">".$this->body[0]."</tr>\n
	     		<tr><td bgcolor=\"#FFFFFF\"><font color=\"#000000\">".$total_comments." Comments [<a href=\"?comments=view&id=".$rows[id]." \" class=toplink>View</a> | Post]</font></td></tr>\n
	  		</table><p></p>\n";
}

//CleanNews cleans body text and displays only x amount of characters
//on main page until user clicks [more] which displays the WHOLE article
function CleanNews($data, $length){
	if(empty($data) || empty($length)){
		return "Missing Input Dummy!";
	}else{
		return GetRecortarTexto(ReplaceText($data), $length); //ReplaceText and GetRecortarTexto is from functions.php
	}
}

function DisplayComments(){

}
}


//the main part

if(isset($_GET['id'])){
	$obj = new News; //calling the News class

while($rows = mysql_fetch_array($result)){
	$obj->DisplayNews($obj->CleanNews($rows[body], $max_length));
}
}

The issue I am having is, I want to pass variables from the while loop into the class so they are displayed, but I can not figure it out for the life of me. I have two books here I have been looking through along with php.net, nothing seems to help me out. I've searched here and havent found anything.

Im sure it is a simple solution (or rather I am hoping).

Im out of ideas...please help ^_

some of the exsisting variables in this were from old code, and just need to be converted 🙁

dewen

needs to be clear on what you plan for News class: is this a class that will hold all news in it, and could display each news in a formatted way, OR is this a class used to process news one by one, by trim and format?

You need to give a definiation on Class News

Hexx

I redid it all. It goes like this:

<?php

$max_length = 450; //how many characters to display

class News{

var $id;
var $result;
var $rows = array();

function SetResult($string){
	$this->result = $string;
}

function DisplayNews($clean){
	while($rows = mysql_fetch_array($this->result)){
		$this->id = $rows[id];
		if($clean == 1){
			$rows[body] = $this->CleanNews($rows[body], $GLOBALS[max_length]);
		}
	echo" <table cellpadding=\"4\" cellspacing=\"1\" bgcolor=\"#000000\" style='width:100%;font-family:Verdana;font-size:12px;'>\n
				<tr>\n
		  			<td class=\"tablehead\" height=\"20\">\n
					<p><font color=\"#FFFFFF\"><strong>".$rows[title]."</strong></font><br>\n
					<font color=\"#CCCCCC\">Posted By ".$rows[author]." on ". date("l dS of F Y @ h:i A", $rows[date])."</font></p></td>\n
				</tr>\n
				<tr>\n
		  		<td bgcolor=\"#FFFFFF\"><font color=\"#000000\">".$rows[body]."</tr>\n
	     		<tr><td bgcolor=\"#FFFFFF\"><font color=\"#000000\">".$total_comments." Comments [<a href=\"?comments=view&id=".$rows[id]." \" class=toplink>View</a> | Post]</font></td></tr>\n
	  		</table><p></p>\n";
	}
}

function GetRecortarTexto ($vTxt, $Car) {
	if (strlen($vTxt) > $Car) {
  	return substr($vTxt, 0, $Car) . "... <a href=\"?id=".$this->id."\" class=toplink>[more]</a>";
}else 
	return $vTxt;
}

function CleanNews($data, $length){
	$id = $this->id;
	if(empty($data) || empty($length)){
		return "Missing Input Dummy!";
	}else{
		return $this->GetRecortarTexto(ReplaceText($data), $length); //ReplaceText and GetRecortarTexto is from functions.php
	}
}

function Comments($op){
	if($op == "view"){
		while($rows = mysql_fetch_array($this->result)){
			echo "<p>".$rows[comment]."</p>\n";
		}
	}
}
}

//Begin showing stuff on the page
$obj = new News; //get the class News

if(isset($_GET['id']) && isset($_GET['op'])){
	$obj->SetResult(mysql_query("SELECT * FROM news WHERE id = {$_GET['id']}"));
	$obj->DisplayNews(0);
	$obj->SetResult(mysql_query("SELECT * FROM news_comments WHERE newsid = {$_GET['id']} ORDER BY `id` DESC"));
	$obj->Comments($_GET[op]);
}
elseif(isset($_GET['id'])){
	$obj->SetResult(mysql_query("SELECT * FROM news WHERE id = {$_GET['id']}")); //show specific news
	$obj->DisplayNews(0);
}else{
	$obj->SetResult(mysql_query("SELECT * FROM news WHERE newid = 0 ORDER BY `id` DESC")); //show all news
	$obj->DisplayNews(1); //1 indicates we want to strip/shorten and put in some UBB code - I need to recode
	}
?>

Of course I still need to clean some stuff up, but thats the jist of it. Or rather, how I wanted/needed it to work. Took me all day for that....gotta love being a class n00b.

Hexx

dewen, now that you mention that, I think a lightbulb just clicked in my head lol.

A friend and I are working on a project right now, and we need to sit down to talk about things and HOW they will be setup still. But for the moment its just a matter of getting some things to work, and then finding the best way to change it later (i know this sounds backwards...).

dewen

below is my understanding of OOP in this case, just for your reference, I'm sure you can find better way. Also read something about PHP design pattern, that helps a lot. And read the PEAR at
pear.php.net

 

<?php 

/**
 * News CLASS
 * 
 */
class News
{ 
	/**
	 * news id
	 * 
	 * @var integer
	 * @access private
	 */
	var $id = 0; 

/**
 * news body
 * 
 * @var string
 * @access private
 */
var $body = 0;

/**
 * news body
 * 
 * @var string
 * @access private
 */
var $title = 0;

// ... and other properties of one news
// no need for $result
// it's in the constructor when init a new
// object

/**
 * news comments
 * 
 * @var array
 * @access private
 */
var $comments = array();

var $max_length = 0;

/**
 * constructor
 */
function News($newsid)
{
	/*
		query to get one news recorder with id
		...
		$DataSet fetch rows from the mysql result

		query to get one news comments with news id
	*/

	$this->body = $DataSet['body'];
	$this->title = $DataSet['title'];
	// ...
	$this->comments = $CommentsSet;
}


function DisplayNews()
{ 
	$this->body = $this->CleanNews($this->body, $this->max_length); 

	// it's not good to output from class,
	// so return the string to caller
	return  " <table cellpadding=\"4\" cellspacing=\"1\" bgcolor=\"#000000\" style='width:100%;font-family:Verdana;font-size:12px;'>\n 
		    <tr>\n 
			  <td class=\"tablehead\" height=\"20\">\n 
			<p><font color=\"#FFFFFF\"><strong>".$rows[title]."</strong></font><br>\n 
			<font color=\"#CCCCCC\">Posted By ".$rows[author]." on ". date("l dS of F Y @ h:i A", $rows[date])."</font></p></td>\n 
		    </tr>\n 
		    <tr>\n 
		      <td bgcolor=\"#FFFFFF\"><font color=\"#000000\">".$rows[body]."</tr>\n 
		     <tr><td bgcolor=\"#FFFFFF\"><font color=\"#000000\">".$total_comments." Comments [<a href=\"?comments=view&id=".$rows[id]." \" class=toplink>View</a> | Post]</font></td></tr>\n 
		  </table><p></p>\n"; 
} 

function GetRecortarTexto ($vTxt, $Car) { 
  if (strlen($vTxt) > $Car) { 
  return substr($vTxt, 0, $Car) . "... <a href=\"?id=".$this->id."\" class=toplink>[more]</a>"; 
}else  
  return $vTxt; 
} 

function CleanNews($data, $length){ 
	$id = $this->id; // ??? why put it here?
	if(empty($data) || empty($length)){ 
	    return "Missing Input Dummy!"; 
	}else{ 
	    return $this->GetRecortarTexto(ReplaceText($data), $length); //ReplaceText and GetRecortarTexto is from functions.php 
	} 
} 

function GetComments(){ 
	    while($rows = mysql_fetch_array($this->result)){ 
		$comm .=  "<p>".$rows[comment]."</p>\n"; 
	    } 
	    return $comm;
} 

function SetMaxLen($iLen)
{
	$max_length = $iLen;
}
} 

//Begin showing stuff on the page 


if(isset($_GET['id']) && isset($_GET['op'])){ 

$obj = new News(id); // init a news
$obj->SetMaxLen(450);
echo $obj->DisplayNews(); 
if ($_GET['op'] == "view") {
	echo $obj->GetComments(); 
}
} 
elseif(isset($_GET['id'])){ 
	// same idea
}else{ 
	// same idea
}
?>

Shrike

If you want to take the object oriented approach I would first recommend that you remove all the HTML from your class. Not doing so limits the extensibility of your code and goes against one of the principles of OO design - code reuse. What happens when you want to add news articles to your site? You will end up writing duplicate code which does things slightly differently. Careful design will allow you to reuse elements of code.

class Article
{
  // Declare member variables
  var $body, $title, $comments;
  // Define constructor
  function article($dataset)
  {
    Set member variables
    $this->body = $dataset['body'];
    // etc
  }
  // Define accessors
  function getBody()
  {
    return $this->body;
  }
  function setBody($body)
  {
    $this->body = $body;
  }
  // etc for all member variables
}

// Container for articles
// Contains factory method and manipulation methods
class ArticleList
{
  var $articlelist; // A recordset
  // Constructor - expects a database recordset
  function articlelist($articlelist)
  {
    $this->articlelist = $articlelist;  

  }
  // Factory method
  function newArticle
  {
    return &new Article(mysql_fetch_assoc($this->articlelist));
  }
  function rewind()
  {
    mysql_data_seek($this->articlelist, 0);
  }
  function size()
  {
    return mysql_num_rows($this->articlelist);
  }
}

// We put all specific code outside of the class to promote code reuse
$qry = "SELECT stuff FROM articles";
$result = mysql_query($qry);
$articlelist = new ArticleList($result);
if($articlelist->size() > 0)
{
  // Iterate over the recordset
  while($article =& $articlelist->newArticle())
  {
    echo "<p>" . $article->getBody() . "</p>";
  }
}

rkolbe

dewen, I'll def read those articles. I think that would be a decent start right now for OOP stuff. Seeing how I have not had any real experience with OOP programming (but have done php coding itself on and off these past few years).

Both of you, thanx for your input....I will be working on this stuff for a while 😉

Hexx

wow, I just realized I have two accounts here.....Hexx and rkolbe......

Hexx

Ok, I get this all now. BUT, there is an issue somewhere. The code appears to keep looping or something. My page sits there and keeps "Loading" and sometimes locks up my browser (Im using 1.x Firefox along with Fedora Core 3 (linux)).

Here is what the code looks like:

class Article
{
  // Declare member variables
  var $body, $title, $comments;
  // Define constructor
  function article($dataset)
  {
    //Set member variables
    $this->body = $dataset['body'];
    $this->title = $dataset['title'];
    $this->comments = $dataset['comments'];
  }
  // Define accessors
  function getBody()
  {
    return $this->body;
  }
  function setBody($body)
  {
    $this->body = $body;
    $this->title = $body;
    $this->comments = $body;
  }
  // etc for all member variables
}

// Container for articles
// Contains factory method and manipulation methods
class ArticleList
{
  var $articlelist; // A recordset
  // Constructor - expects a database recordset
  function articlelist($articlelist)
  {
    $this->articlelist = $articlelist;  

  }
  // Factory method
  function newArticle()
  {
    return new Article(mysql_fetch_array($this->articlelist));
  }
  function rewind()
  {
    mysql_data_seek($this->articlelist, 0);
  }
  function size()
  {
    return mysql_num_rows($this->articlelist);
  }
}


//the actualy calling and displaying

$qry = "SELECT * FROM news WHERE newid = 0 ORDER BY `id` DESC";
$result = mysql_query($qry);
$articlelist = new ArticleList($result);
if($articlelist->size() > 0)
{
  // Iterate over the recordset
  while($article =& $articlelist->newArticle())
  {
    echo "<p>" . $article->getBody() . "</p>";
  }
}

Ok, so the & you had in the previous code, for some reason I get an error with it, so I took it out except for the 2nd one.

What is the signifigence (sp?) of the &?

Shrike

Yeah that's my bad, caffeine. Lack of. etc.

function &newArticle 
{
  if($article = mysql_fetch_assoc($this->articlelist))
  {
    return new Article($article);
  }
  return false;
}

Ampersand is used to create references to variables. Useful if you want to work on an actual object rather than a copy.

Shrike

By the way I meant that you should define accessors for each member variable, not put them all in the one method 😉

Hexx

lol ok, I wasn't sure how that was "suppose" to work. Im working on getting an OOP book now....to help with some of this.

You def helped me out a LOT though. Just from the code you posted, I think I can mold something really good out of it (e.g. other classes that will be used on the site).

Thanks a ton 🙂