help with this error?

[natman3]

i am running this script but i get this error "You have an error in your SQL syntax near ' 'asd', 'qasdg', 'senior', '23', , NOW())' at line 1" does anyone know why?

function save_profile_date($ident = "", $first = "", $last = "", $year = "", $age = "", $gender = "") {
		if ($_SESSION['is_rec']){
			$sql = sprintf("INSERT INTO %s (id, user_id, first, last, year, age, gender, last_change) VALUES (NULL, %s, %s, %s, %s, %s, $s, NOW())",
				PROFILE_TABLE, $_SESSION['user_id'], $this->ins_string($first), $this->ins_string($last),
				$this->ins_string($year), $this->ins_string($age), $this->ins_string($gender));
		}
		if (mysql_query($sql) or die (mysql_error())) {
			$this->profile_id = (!$_SESSION['is_rec']) ? mysql_insert_id() : $ident;
			$this->the_msg = $this->extra_text(2);
		} else {
			$this->the_msg = $this->extra_text(3);
		}
	}

[mrhappiness]

Thank you for echoing $sql... ;-)

[mtmosier]

$sql = sprintf("INSERT INTO %s (id, user_id, first, last, year, age, gender, last_change) VALUES (NULL, %s, %s, %s, %s, %s, $s, NOW())", 

The last placeholder should have been a %s, but you have it as $s.

[natman3]

I fixed the $s to %s and still i get this error:

You have an error in your SQL syntax near ' 'brad', 'mill, 'senior', '23', , NOW())' at line 1

[mrhappiness]

Originally posted by mrhappiness
Thank you for echoing $sql... ;-)

[mtmosier]

Please post your corrected code, and your $this->ins_string() method. If your sprintf is correct then it must be a problem in ins_string.

Oh, and also echo your $sql before executing it, and post that output too. I imagine the only issue is gender missing, but you never know.

[natman3]

this is the is ins_string() function:

function ins_string($value, $type = "") {
		$value = (!get_magic_quotes_gpc()) ? addslashes($value) : $value;
		switch ($type) {
			case "int":
			$value = ($value != "") ? intval($value) : NULL;
			break;
			default:
			$value = ($value != "") ? "'" . $value . "'" : "''";
		}
		return $value;
	}

I think this is the function that is causing the error:

function get_profile_data() {
		$this->get_user_info();
		$_SESSION['user_id'] = $this->id;
		$sql = sprintf("SELECT id, first, last, year, age, gender FROM %s WHERE user_id = %s", PROFILE_TABLE, $this->id);
		echo "$sql";
		$result = mysql_query($sql) or die (mysql_error());
		if (mysql_num_rows($result) == 0) {
			$_SESSION['is_rec'] = false;			
			$this->the_msg = $this->extra_text(1);
		} else {
			$_SESSION['is_rec'] = true; // this session acts like an extra controle
			while ($obj = mysql_fetch_object($result)) {
				$this->profile_id = $obj->id;
				$this->first = $obj->first;
				$this->last = $obj->last;
				$this->year = $obj->year;
				$this->age = $obj->age;
				$this->gender = $obj->gender;				

		}
	}
}

when i tried to echo out the $sql i got this: SELECT id, first, last, year, age, gender FROM collegiate WHERE user_id = 2Query was empty

[natman3]

i found the problem: this is the collegiate table i had to change the user_id to 2 it was one thus showing the query as empty

id user_id first last year age gender last_change
1 1 John Erickson sophmore 22 m 2005-04-03 22:57:39

2 2 billy boy junior 19 m 0000-00-00 00:00:00