Drop down menu and switch statement

Boro1986

Having problems with this, I want to do a search on the band by band name or genre but all I'm getting is all of the bands every time no matter what I enter into the search box.



if(isset($_POST))

{

               switch ($_POST['action']) 
{ 

//If genre is selected look for the genre entered into the search box.

case "genre": 
                                        $sql="SELECT * FROM band where genre='$search'"; 
                                        $result=mysql_query($query) or die(mysql_error());

// Display the band names                  

while ($row = mysql_fetch_assoc($result))      

	{

		echo '<p><a href="bandview.php?bandname='.$row['band_name'].'">'.$row['band_name'].'</a></p>';             

	}


                                    break; 

// Same again only look for the band name                                        

case "band": 
                                               $sql="SELECT * FROM band where band_name='$search'"; 
$result=mysql_query($query) or die(mysql_error());

              while ($row = mysql_fetch_assoc($result))      

	{

		echo '<p><a href="bandview.php?bandname='.$row['band_name'].'">'.$row['band_name'].'</a></p>';             

	}


                                    break; 

}

//If no search term is submitted display all bands.

	$query="SELECT * FROM band";
	$result=mysql_query($query) or die(mysql_error());
	while ($row = mysql_fetch_assoc($result))      

	{

		echo '<p><a href="bandview.php?bandname='.$row['band_name'].'">'.$row['band_name'].'</a></p>';             

	}


}

thorpe

i dont see anywhere where you set your $search variable used in your query.

Boro1986

Sorry I missed it off, it's set directly above the code I posted, I've read up on this and modifyed the code to this:


<html>
<title>DIYMusic :: Non Band</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body bgcolor="#000000" text="#CCCCCC" link="#0000FF" vlink="#FFFFFF">
<table width="96%" height="433" border="0">
  <tr>
    <td width="41%" valign="top"><img src="file:///C|/Documents%20and%20Settings/Ste%20Wilson/My%20Documents/Uni%20Work/Site/Side%20Bar%20copy.jpg" width="290" height="500"></td>
    <td width="59%" valign="top"> <p align="center"><strong>Here are the bands:</strong></p>
      <p>Search by: </p>
      <p> 
<form action="<?=$_SERVER['PHP_SELF']?>" method="post">
        <select name="select">
          <option value="genre">Genre</option>
          <option value="name">Band Name</option>
        </select>
        <input type="text" name="search">
        <input type="submit" name="Submit" value="Search">
</form>
      </p>
      <p>
        <?php 

	include('connect.inc');

$search=$_POST['search'];


switch ($_POST['Submit']) 
{ 
                                        case "genre": 
                                        $sql="SELECT * FROM band where genre='$search'"; 
                                        $result=mysql_query($query) or die(mysql_error());

              while ($row = mysql_fetch_assoc($result))      

	{

		echo '<p><a href="bandview.php?bandname='.$row['band_name'].'">'.$row['band_name'].'</a></p>';             

	}


                                    break; 

                                    case "band": 
                                           $sql="SELECT * FROM band where band_name='$search'"; 
$result=mysql_query($query) or die(mysql_error());

              while ($row = mysql_fetch_assoc($result))      

	{

		echo '<p><a href="bandview.php?bandname='.$row['band_name'].'">'.$row['band_name'].'</a></p>';             

	}


                                    break; 


                default:

$query="SELECT * FROM band";
	$result=mysql_query($query) or die(mysql_error());
	while ($row = mysql_fetch_assoc($result))      

	{

		echo '<p><a href="bandview.php?bandname='.$row['band_name'].'">'.$row['band_name'].'</a></p>';             

	}

}








?>
  </p>
  <p>&nbsp;</p>
  <p>&nbsp;</p></td>
  </tr>
</table>
</body>
</html>