[Resolved] [Resolved] Question.. About displaying db entry on webpage

badgoat

Hi!

With plenty of forum help, I have gotten to the point where I want to view an entry in my db.. An example link of where I get to view one is this:

http://localhost/details.php?id=35

My table structure id displayed, but nothing from my db entry is displayed.. If I had to guess, I would say it is because of my query, because the query doesn't mention anything about matching the id passed to this page. Currently my query line is:

$sqlquery = "SELECT * FROM table_a";

When I view the page source, nothing is passed to the page. When I enter the query at the MySQL command line, I get data (all of the rows) So I think the problem is that the query hasn't targeted the id passed from the previous page.. Does that sound right? and if it is, how can I rectify this?

Drakla

How are you trying to get at the id value?

You get it from $GET['id'], so it would be as simple as

$id = (int)$_GET['id'];  // I do the int thing to kill errors where somebody has typed a string, or is trying an injection

$q = 'SELECT * FROM mytable WHERE id = '. $id;

$res = mysql_query($q);.... etc etc

badgoat

Hi Drakla,

Apparently, I am not getting the values for $id.. I figured that was the problem, but I haven't seen a full working model of that, so I am unsure how to proceed with it. I see from your example that I do need to reference the id in my query.. when you say etc etc, what else is there? I am unfamiliar with this, it's new to me!

Thank you kindly!

Drakla

With the etc... I was basically saying you'll have your code for displaying the returned data in a table, or something after the query.

At the top of your page put in the line

echo '<pre>'; print_r($_REQUEST); echo '</pre>';

And see what variables are being passed to the page. I put all three statements on one line as I use that for debugging all the time and I can quickly comment out the line in one go.

badgoat

Aah! That makes snese 🙂 I put the line at the top as you recommended, and what is displayed:

Array
(
[id] => 35
)

Title

(Title being the beginning of the table structure to display the variables)

Code so far is:

	 echo '<pre>'; print_r($_REQUEST); echo '</pre>'; 

 $id = (int)$_GET['id'];

$sqlquery = "SELECT * FROM mktime WHERE id =  '$id'";


$queryresult = mysql_query($sqlquery) or die(" Could not execute mysql query !");
echo '<table>
<tr>
<td>DIW Title</td>
<td>'.$diwtitle.'</td>
</tr>	
(code continues with the rest of the variables as above)

do you see what I am doing wrong? I still do not see anything being passed..

EDIT: The only variable being passed is the $id variable, which for the above example is 35. The other variables which are associated with db entry 35 are not passed.

Drakla

Are you using something like $row = mysql_fetch_assoc($queryresult); to pull each row from the result set in the code that would be just under the bit you've posted?

badgoat

I hadn't included that in my script, although I did have that on the page which sets the variables.
With the lines entered, which looks like this:

$connect= mysql_connect("localhost","root") 
   or die("Could not connect to database in localhost !");
$queryresult=mysql_select_db("testdiw") 
   or die("Could not select that database !");

$sqlquery = "SELECT * FROM mktime WHERE id =  '$id'";
$queryresult = mysql_query($sqlquery) or die(" Could not execute mysql query !");

 $row = mysql_fetch_row($queryresult);
  $id = (int)$_GET['id'];
$date_string = $row[0];
$diwtitle = $row[1];
$id = $row[2];

 echo '<pre>'; print_r($_REQUEST); echo '</pre>'; 




echo '<table>
<tr>
<td>Date</td>
<td>'.$row['date_string'].'</td>
</tr>

No variables display, not even the ID anymore... Do I have the order of the query wrong?

Drakla

$connect= mysql_connect("localhost","root") 
   or die("Could not connect to database in localhost !");

$queryresult=mysql_select_db("testdiw") 
   or die("Could not select that database !");

$id = (int)$_GET['id'];		// have to fetch $_GET['id'] into $id BEFORE the query is created

$sqlquery = "SELECT * FROM mktime WHERE id =  '$id'";

$queryresult = mysql_query($sqlquery) or die(" Could not execute mysql query !");

// to show your results in a table you fetch the rows one at a time, then output a table row

echo '<table>';

while ( $row = mysql_fetch_assoc($queryresult) )
{
	echo '<tr><td>', $row['date_string'], '</td></tr>';
}

echo '</table>';

If you have 3 rows in your result, then you can also use something like this, but I prefer using the associative result for clarity

while ($row = mysql_fetch_row($queryresult) )
{
	echo '<tr><td>', $row[0], '</td><td>', $row[1], '</td><td>', $row[2], '</td></tr>';
}

That should get you going. Won't be around for a while but I'm sure somebody else will help if you need it.

Well done Parappa - that's eeet for today!

badgoat

That definitely helps me along! Thank you very much Drakla!

badgoat

OK, a followup question to the solution provided above:

How would I make the variables editable? I figure that creating a text box next to the current output, which I have put into the code, but I am unsure how to insert the updated vaiables.. For example, what if I only change one? Or what f I change all of them? Is there a way to make the query insert only what has changed?