[Resolved] Code goes for infinity

Kudose

Hello all.

I've noticed recently that even though I add line breaks and format my code, when I view the source in the browser, it is just one massive line.

Anyone know why this would be happening?

Should I be FTPing files in stricly Binary or ASCII?

edit
I use notepad, ultra edit and WS_FTP Pro.
/edit

planetsim

And this is the HTML source right? Has it used PHP to dynamically create the code? Have you viewed the source files on the server using an editor that is made available?

Kudose

Correct, it is the HTML source that is out of wack. When I view the file via FTP (with notepad), everything looks fine.

Yes, most of the conent is generated by PHP.

Kudose

For example, this code below:

//--------------------start picks listings----------------------\\
										$class_row = "row_D";
										$row_inv_cnt = 0;
										$hr_counter = 0;
										foreach($picks as $vehicle){

										if($class_row == "row_D"){
													$class_row = "row_L";
												} else {
													$class_row = "row_D";
												}

										echo "<table border=\"0\" cellspacing=\"0\" cellpadding=\"10\" width=\"100%\">";		
										echo "<tr style=\"font-weight:bold; font-size:75%;\">"; //class=\"".$class_row."\"

												$get_make_no = $myDb->dbFetch("SELECT maker FROM ".$prefix."manufacturers WHERE make_id='".$vehicle['make']."'");
												$make = $get_make_no[0]['maker'];
												$images = $vehicle['img1'];
												$images = explode(",", $images);
												if(!file_exists($tb_config[0]['dir']."imgs/thumb_".$images[0])){
													$thumb = new image;
													@copy($tb_config[0]['dir']."imgs/".$images[0], $tb_config[0]['dir']."imgs/thumb_".$images[0]);
													$thumb->thumbnails($tb_config[0]['dir']."imgs/thumb_".$images[0], 100, "Y");
												}

												echo "<td align=\"center\" width=\"15%\"><a href=\"".$tb_config[0]['url']."index.php?mod=sii&id=".$vehicle['uid']."\">";
												echo "<img src=\"".$tb_config[0]['url']."imgs/";
												if($images[0] != "nophoto.jpg"){
													echo "thumb_";
												}
												echo $images[0]."\" width='100'";
												echo "height='80' style=\"border: 1px solid #000000;\"></a><br>";
												echo $vehicle['year']." ".$make." ".$vehicle['model']."<br>";
												/*if($vehicle['trim'] != "NA"){ echo $vehicle['trim']." Edition<br>"; }
												if($vehicle['miles'] != "0"){ echo "<b>Miles: </b>".number_format($vehicle['miles'])."<br>"; }
												if($vehicle['cond'] == "N"){ 
													echo "<b>New Stock</b><br>"; 
												} else {
													echo "<b>Pre-Owned Stock</b>";
												}*/
												echo "</div></td>";

												//<!-- Column 2 -->

												/*echo "<td width=\"25%\"><div align=\"left\">";
												if($vehicle['trans'] != "NA"){ echo "Trans. :: ".$vehicle['trans']."<br>"; }
												if($vehicle['engine'] != "NA"){ echo "Engine :: ".$vehicle['engine']."<br>"; }
												if($vehicle['drivetrain'] != "NA"){ echo "Drivetrain :: ".$vehicle['drivetrain']."<br>"; }
												echo "</div></td>";

												//<!-- Column 3 -->

												echo "<td align=\"left\" width=\"30%\">";
												if($vehicle['price'] == 0){
													echo "<div align=\"right\" style=\"font-size:125%; color:".$link_c.";\">Call for details!<br><br><a href=\"index.php?mod=sii&id=".$vehicle['uid']."\" style=\"text-decoration:none;\"><img src=\"".$tb_config[0]['url']."imgs/camera_icon.gif\" border=\"0\">&nbsp;&nbsp;&nbsp;<span style=\"font-size:75%; color:".$link_c.";\">View In Inventory</span></a></div>";
												} else {
													echo "<div align=\"right\" style=\"font-size:125%; color:".$link_c.";\">Only $".number_format($vehicle['price'])."!<br><br><a href=\"index.php?mod=sii&id=".$vehicle['uid']."\" style=\"text-decoration:none;\"><img src=\"".$tb_config[0]['url']."imgs/camera_icon.gif\" border=\"0\">&nbsp;&nbsp;&nbsp;<span style=\"font-size:75%; color:".$link_c.";\">View In Inventory</span></a></div>";
												}*/
												echo "</td>";

											echo "</tr>";
										echo "</table>";		
										if($hr_counter !== count($picks)-1){ echo '<hr>'; }
										$hr_counter++;
									}
									//-----------------------------end picks listings-------------------\\

Generates:

*removed to be nice*

One long ass line. 😉

Kudose

Could it be beaucse I don't use line breaks? \n?

when I use them, they show up on screen.

bradgrafelman

Dang @ your extra-wide post....

Anyway, yes, just because you use a separate call to echo() doesn't mean PHP will go to a new line. You need to specify a new line '\n' when you want one.

echo "hi";

echo "there";

echo " - ";

echo "hithere";

outputs "hithere - hithere".

If you use "\n" and it shows up on the actual HTML page as breaks like '<br>'... that's probably an HTML formatting issue and I can't help you. shrug Make sure you're within <p> </p> tags?

BTW: Get rid of that extra wide post or condense it down a bit, can you? 🙁

Drakla

Mothering hell - anybody using firefox to add a post in this thread? You have to scroll over for ten yards to find the leetle box.

Anyway, is there any reason't you're concerned about the appearance of your generated HTML? I only bother throwing in line breaks when I'm checking up on tables, as it's such a pain when you're trying to be good by using single quotes because it's quicker (by about 1 second in your whole lifetime) then you have to bust out and in again because \n only works in double quotes. Yeah yeah - you can do

define ('CRLF', "\r\n"); and use that instead. But I'm too stupid for that.

bradgrafelman

Lol @ Drakla. What do ya say we head on over to Feedback and suggest+demand a wordwrap() mod? :p

I too got my daily exercise scrolling.

Add in those linebreaks ('\n' is probably all you need, not a full-blown CRLF) and let me know what happens. (A link would be helpfull too.)

Kudose

I check it out later tonight and post back. With a link.
Thanks guys.

Drakla

Add in those linebreaks ('\n' is probably all you need, not a full-blown CRLF

No no, "\n" is what you need, if you use single quotes you just get literally that in your page.

Wahhh - I wish you hadn't said "wordwrap" as my girlfriend has been playing my copy of Parappa the Rappa all weekend and I'd just about kicked the habit of talking like Chop Chop Onion.

bradgrafelman

LOL @ the 2nd part of your post. Care to share with us in the echo lounge? :d

And as to the first part... I meant literally "\n", i used the '\n' because I was too lazy to reach for Shift, and I was only distinguishing between \n vs. \r\n.... excluding the type of quotes used.

Confusing, but it makes sense in my muddled mind. So leave your comments behind. Hey I think I just made a rhyme.... please do you have the time?

This is lame...
it ain't no game...

I'm out.

-- B-dawg