Display image, getting garbage

ts10

I've done this before...and it worked. Now when I try to display the image I get garbage on the screen.

I am pulling the location of the image from a database query. That all checks out fine and it knows the image is there.

I then run this to dynamically resize the image and then I want to display it on the screen:

// The file
			$filename = $getAppsArray[location];
			$filetype = substr(basename($getAppsArray[location]), -3);

		// Set a maximum height and width
		$width = 400;
		$height = 600;

		// Content type
		//header('Content-type: image/jpeg');


		// Get new dimensions
		list($width_orig, $height_orig) = getimagesize($filename);

		if ($width && ($width_orig < $height_orig)) {
		   $width = ($height / $height_orig) * $width_orig;
		} else {
		   $height = ($width / $width_orig) * $height_orig;
		}

	//FILE TYPE	JPG
	if ($filetype == "jpg" || $filetype == "JPG") {
		// Resample
		$image_p = imagecreatetruecolor($width, $height);
		$image = imagecreatefromjpeg($filename);
		imagecopyresampled($image_p, $image, 0, 0, 0, 0, $width, $height, $width_orig, $height_orig);

		// Output
		imagejpeg($image_p, null, 100);
	}

I get:

ÿØÿàJFIFÿþ"‹QÓ5HÙî¶”\Gk¨Mnn#·€Å!Ó…+éºˆ'x[I½ðeûÜ†âÌµõœÆ77}å”*ÐÏo¹®ø{í1Höv·0›}"„¼·Â ®Õ„?Æþ‹Ä6“iw $7k#É¢jIùâ0gÈ‚âGg- Œyh²œÝÛ´È‚T-/Áÿ>Ms Ï>ž-u»0È–Ê.æqHs#Z\æF~îL®|ÕWëÆ± Ãw+Â@EuËb!ÕYÚ71ì0Ê¹SnÁ÷)“TñŸ€—^³»“ÊÖà%íïdR²j0Â¬Ïö…Ž8×Íaó\F€©ŒGs"ü€Ò5ýGÂ:“[]Îí“ òŸ1£G ï–ü»F>©ðw‹ôMJ8¼×€Èè±‰·ž2‡1”“q‘[çW*ëÇŒù÷Å†³Â²ÜÅi,SYHê)³…Ì†7bW-„•‘H+‘†eáf×K¾KmJÔGËåHŽÉ–D†FdÞ)`Ý·#£ýqÁà¤OðCÅ|ø“¬5ÏÃ¿\ÛÛùîûÓL¹m°ÚköQ†ÂIháÔí¡BÓÚ¨²Ižöse{i©YÚê}Ô¶ÖÐ^{Y^{ÚÊ“[]ÚÜÆ³[Ü[Í4RÁo}}

ETC

What am I doing wrong? I DO have the content header for JPG at the top of the file even though I know it's not necessary to work.

Thanks!

planetsim

The header is required. Why is it commented out?

ts10

It's commented there - it's active at the top of my file:

<? 
session_start(); 
header('Content-type: image/jpeg');
require_once("db.inc.php");
?>

Even though I've had this work without the header before - I just can't find what's going on!

MikeSnead

For some reason or another the header is not being sent. I know you say you have it sent earlier, but the output you describe is what happens when I comment out the header on any of my image scripts.

ts10

Here's my entire file if anyone can see what's going on - I'd so appreciate it!

<? 
session_start(); 
header('Content-type: image/jpeg');
require_once("db.inc.php");
?>

<?
if ($id) {
	$getClientData = mysql_query("SELECT * FROM clients WHERE id = '$id'") or die(mysql_error());			
}
?>


<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title>Agent Filer</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link href="style.css" rel="stylesheet" type="text/css">
</head>

<body>
<?php if (session_is_registered('verified')) { ?>

<?php
$clientData = mysql_fetch_array($getClientData);
?>

<div align="center">
  <table width="700" border="0" cellspacing="0" cellpadding="0">
    <tr>
      <td><?php include("header.inc.php"); ?></td>
    </tr>
	<tr>
	  <td><div class="viewClientTop">
	      <b><?=$clientData[lastName]?>, 
	      <?=$clientData[firstName]?></b>
		  &nbsp;&nbsp;&nbsp; - &nbsp;&nbsp;&nbsp;
		  <?=$clientData[underwriter]?>
		  &nbsp;&nbsp;&nbsp; - &nbsp;&nbsp;&nbsp; POLICY EFFECTIVE
		  <?php echo(date("M d Y", $clientData[startdate])); ?>
		  to
		  <?php echo(date("M d Y", $clientData[expiredate])); ?>
	  </div>
	  </td>
	</tr>
    <tr>
      <td valign="top" class="login"><p><a href="<?=$PHP_SELF?>?id=<?=$id?>&go=app" class="viewClientLinks">APPLICATIONS</a> <a href="<?=$PHP_SELF?>?id=<?=$id?>&go=dec" class="viewClientLinks">DECLARATIONS</a> <a href="<?=$PHP_SELF?>?id=<?=$id?>&go=notes" class="viewClientLinks">CLIENT NOTES</a></p>
      <?php if ($go == "app") { 
	  if (!$_GET['dataid']) {
	  	$getApps = mysql_query("SELECT id, location FROM data WHERE type = 'Application' AND clients_id = '$_GET[id]' ORDER BY uploadDate DESC LIMIT 1") or die(mysql_error());
	  } else {
	  	$getApps = mysql_query("SELECT id, location FROM data WHERE type = 'Application' AND clients_id = '$id' AND id < $dataid ORDER BY uploadDate DESC LIMIT 1") or die(mysql_error());
	  }
	  //echo mysql_num_rows($getApps);
	  $getAppsArray = mysql_fetch_array($getApps);
	  //echo($getAppsArray[location]);

  // The file
		$filename = $getAppsArray[location];
		$filetype = substr(basename($getAppsArray[location]), -3);

		// Set a maximum height and width
		$width = 400;
		$height = 600;

		// Content type
		//header('Content-type: image/jpeg');


		// Get new dimensions
		list($width_orig, $height_orig) = getimagesize($filename);

		if ($width && ($width_orig < $height_orig)) {
		   $width = ($height / $height_orig) * $width_orig;
		} else {
		   $height = ($width / $width_orig) * $height_orig;
		}

	//FILE TYPE	JPG
	if ($filetype == "jpg" || $filetype == "JPG") {
		// Resample
		$image_p = imagecreatetruecolor($width, $height);
		$image = imagecreatefromjpeg($filename);
		imagecopyresampled($image_p, $image, 0, 0, 0, 0, $width, $height, $width_orig, $height_orig);

		// Output
		imagejpeg($image_p, null, 100);

	}	

	//FILE TYPE	GIF
	if ($filetype == "gif" || $filetype == "GIF") {
		// Resample
		$image_p = imagecreatetruecolor($width, $height);
		$image = imagecreatefromgif($filename);
		imagecopyresampled($image_p, $image, 0, 0, 0, 0, $width, $height, $width_orig, $height_orig);

		// Output
		imagegif($image_p, $uploadfile);
	}	

	//FILE TYPE	PNG
	if ($filetype == "png" || $filetype == "PNG") {
		// Resample
		$image_p = imagecreatetruecolor($width, $height);
		$image = imagecreatefrompng($filename);
		imagecopyresampled($image_p, $image, 0, 0, 0, 0, $width, $height, $width_orig, $height_orig);

		// Output
		imagepng($image_p, $uploadfile);
	}

  ?>
  <p>&nbsp;</p>
  <?php } ?>

  <?php if ($go == "dec") { ?>
  <p>&nbsp;</p>
  <?php } ?>

  <?php if ($go == "notes") { ?>
  <p>&nbsp;</p>
  <?php } ?>
  </td>
</tr>
<tr>
  <td>&nbsp;</td>
</tr>
  </table>
</div>

<?
} else {
	echo "<META HTTP-EQUIV='Refresh' CONTENT='0;URL=index.php'>";
}
?>
</body>
</html>

MikeSnead

You're sending both HTML and an image to the browser... it has to be one or the other.

Move the image scripting to a separate file and call it as the source of an HTML image tag.

<img src="resize_image.php?blah" />

ts10

Hmm, ok - not too familiar. Can you explain that a bit further?

Thanks!

MikeSnead

In the very begining of your script you call the header function and tell the browser to expect an "image/jpeg". This means that anything you send to the browser from this point on MUST be JPEG image (nothing else). However, you then begin sending HTML to the browser when it is expecting an image... thus the crazy stuff you see on screen.

What you need to do is to remove that first header call and move all your image scripting (basically that middle part) and place it into it's own PHP file. From there you can call that new PHP file as the source (src) attribute of an image (img) tag.

Also note that this script also has problems in that you initially set the header to "image/jpeg" but there is the possibility of you working with other image formats... which would also cause problems since the browser expects one thing but gets another.

ts10

Ok, I got some of it. I still think I'm confused about it (by the way, thanks for the help!). Here's what I've done but it still doesn't work:

this is viewclient.php

<? 
session_start(); 
require_once("db.inc.php");
?>

<?
if ($id) {
	$getClientData = mysql_query("SELECT * FROM clients WHERE id = '$id'") or die(mysql_error());			
}
?>


<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title>Agent Filer</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link href="style.css" rel="stylesheet" type="text/css">
</head>

<body>
<?php if (session_is_registered('verified')) { ?>

<?php
$clientData = mysql_fetch_array($getClientData);
?>

<div align="center">
  <table width="700" border="0" cellspacing="0" cellpadding="0">
    <tr>
      <td><?php include("header.inc.php"); ?></td>
    </tr>
	<tr>
	  <td><div class="viewClientTop">
	      <b><?=$clientData[lastName]?>, 
	      <?=$clientData[firstName]?></b>
		  &nbsp;&nbsp;&nbsp; - &nbsp;&nbsp;&nbsp;
		  <?=$clientData[underwriter]?>
		  &nbsp;&nbsp;&nbsp; - &nbsp;&nbsp;&nbsp; POLICY EFFECTIVE
		  <?php echo(date("M d Y", $clientData[startdate])); ?>
		  to
		  <?php echo(date("M d Y", $clientData[expiredate])); ?>
	  </div>
	  </td>
	</tr>
    <tr>
      <td valign="top" class="login"><p><a href="<?=$PHP_SELF?>?id=<?=$id?>&go=app" class="viewClientLinks">APPLICATIONS</a> <a href="<?=$PHP_SELF?>?id=<?=$id?>&go=dec" class="viewClientLinks">DECLARATIONS</a> <a href="<?=$PHP_SELF?>?id=<?=$id?>&go=notes" class="viewClientLinks">CLIENT NOTES</a></p>
      <?php if ($go == "app") { ?>
	  <img src="resizeimage.php">
	  <p>&nbsp;</p>
	  <?php } ?>

  <?php if ($go == "dec") { ?>
  <p>&nbsp;</p>
  <?php } ?>

  <?php if ($go == "notes") { ?>
  <p>&nbsp;</p>
  <?php } ?>
  </td>
</tr>
<tr>
  <td>&nbsp;</td>
</tr>
  </table>
</div>

<?
} else {
	echo "<META HTTP-EQUIV='Refresh' CONTENT='0;URL=index.php'>";
}
?>
</body>
</html>

this is resizeimage.php

<? 
	  if (!$_GET['dataid']) {
	  	$getApps = mysql_query("SELECT id, location FROM data WHERE type = 'Application' AND clients_id = '$_GET[id]' ORDER BY uploadDate DESC LIMIT 1") or die(mysql_error());
	  } else {
	  	$getApps = mysql_query("SELECT id, location FROM data WHERE type = 'Application' AND clients_id = '$id' AND id < $dataid ORDER BY uploadDate DESC LIMIT 1") or die(mysql_error());
	  }
	  //echo mysql_num_rows($getApps);
	  $getAppsArray = mysql_fetch_array($getApps);
	  //echo($getAppsArray[location]);

  // The file
		$filename = $getAppsArray[location];
		$filetype = substr(basename($getAppsArray[location]), -3);

		// Set a maximum height and width
		$width = 400;
		$height = 600;

		// Content type
		//header('Content-type: image/jpeg');


		// Get new dimensions
		list($width_orig, $height_orig) = getimagesize($filename);

		if ($width && ($width_orig < $height_orig)) {
		   $width = ($height / $height_orig) * $width_orig;
		} else {
		   $height = ($width / $width_orig) * $height_orig;
		}

	//FILE TYPE	JPG
	if ($filetype == "jpg" || $filetype == "JPG") {
		// Resample
		$image_p = imagecreatetruecolor($width, $height);
		$image = imagecreatefromjpeg($filename);
		imagecopyresampled($image_p, $image, 0, 0, 0, 0, $width, $height, $width_orig, $height_orig);

		// Output
		imagejpeg($image_p, null, 100);

	}	

	//FILE TYPE	GIF
	if ($filetype == "gif" || $filetype == "GIF") {
		// Resample
		$image_p = imagecreatetruecolor($width, $height);
		$image = imagecreatefromgif($filename);
		imagecopyresampled($image_p, $image, 0, 0, 0, 0, $width, $height, $width_orig, $height_orig);

		// Output
		imagegif($image_p, $uploadfile);
	}	

	//FILE TYPE	PNG
	if ($filetype == "png" || $filetype == "PNG") {
		// Resample
		$image_p = imagecreatetruecolor($width, $height);
		$image = imagecreatefrompng($filename);
		imagecopyresampled($image_p, $image, 0, 0, 0, 0, $width, $height, $width_orig, $height_orig);

		// Output
		imagepng($image_p, $uploadfile);
	}

  ?>

MikeSnead

Try putting that "require_once" statement at the top of the resize image script... since the database calls are in that script it'll need the db connection.

Also I think there is some other data that needs to be passed to or reaquired by the imageresize.php script.... things like $id and the $_GET array.