[Resolved] populating a from with php?

[natman3]

I am having trouble populating a form. I have writen a function that is inside a class that gets the runners data this funciton is: get_runner_data() another function within the html page is a save_profiled_data() this function saves the form to the apropate table, while the get_runner_data() is to populate the form. However I get a sql error of 'Query was empty' when i view the page. I am trying to get the session cid that correspods the right bit of information. I think this is where i am having a bit of trouble.

If i place this code: in my php page and not in my class function i can populate the form. But my goal is to have the function inside the class populte the form.

if(isset($_GET['cid']))
		{
		   $query  = "SELECT cid, first, last, year, age, gender ".
					 "FROM collegiate ".
					 "WHERE cid = '{$_GET['cid']}'";
		   $result = mysql_query($query) or die('Error : ' . mysql_error());
		   list($cid, $first, $last, $year, $age, $gender) = mysql_fetch_array($result,                                                    MYSQL_NUM);

	   $content = htmlspecialchars($content);
	}

the code for the class function is: i call it within the php page by using this: $update_profile->get_runner_data();

function get_runner_data() {
		$this->get_user_CID();
		$sql = sprintf("SELECT cid, user_id, first, last, year, age, gender FROM collegiate WHERE cid = %s");
		$result = mysql_query($sql) or die (mysql_error());
		if (mysql_num_rows($result) == 0) {
			$_SESSION['is_rec'] = false;			
			$this->the_msg = $this->extra_text(1);			
		} else {
			$_SESSION['is_rec'] = true; // this session acts like an extra controle
		while ($obj = mysql_fetch_object($result)) {
			$this->profile_id = $obj->cid;
			$this->first = $obj->first;
			$this->last = $obj->last;
			$this->year = $obj->year;
			$this->age = $obj->age;
			$this->gender = $obj->gender;				

		}
	}
}

I believe my problem lies within getting the cid from the browsers http. And i am not sure how to get it once i am inside the class funciton, if that makes any sense. because the cid indicates which data is going to be updated. If anyone can help me in how to get a class to $_GET['cid'] that would be great. Because i think thats where my problem lies.

here is what the get_user_CID() looks like: i probly dont need this in the get_runner_data() function

function get_user_CID() {
		$sql_info = sprintf("SELECT cid FROM %s WHERE first = '%s' AND last = '%s'", $this->collegiate_table, $this->first, $this->last);
		$res_info = mysql_query($sql_info);
		$this->cid = mysql_result($res_info, 0, "cid");
		$_SESSION['cid'] = $this->cid;		
	}

[bradgrafelman]

In get_runner_data() you have this:

$sql = sprintf("SELECT cid, user_id, first, last, year, age, gender FROM collegiate WHERE cid = %s"); 

You're missing a parameter for sprintf() to fill the %s...

[natman3]

I corrected it by adding this:

// Function gets the runner of the user
	function get_runner_data() {
		$this->get_user_CID();
		$uid = $_GET['cid'];
		$sql = sprintf("SELECT cid, user_id, first, last, year, age, gender FROM %s WHERE cid = $uid", PROFILE_TABLE, $this->uid);
		$result = mysql_query($sql) or die (mysql_error());
		if (mysql_num_rows($result) == 0) {
			$_SESSION['is_rec'] = false;			
			$this->the_msg = $this->extra_text(1);			
		} else {
			$_SESSION['is_rec'] = true; // this session acts like an extra controle			
		while ($obj = mysql_fetch_object($result)) {
			$this->profile_id = $obj->cid;
			$this->first = $obj->first;
			$this->last = $obj->last;
			$this->year = $obj->year;
			$this->age = $obj->age;
			$this->gender = $obj->gender;				
			}
		}
	}

this allows for my page to finaly display but nothing is populated in the form. I still cannont figure out why.

<?php
include($_SERVER['DOCUMENT_ROOT']."/user/ext_user_profile.php"); 
error_reporting (E_ALL); // I use this only for testing
$update_profile = new Users_profile;

$update_profile->access_page($_SERVER['PHP_SELF'], $_SERVER['QUERY_STRING']); // protect this page too.
/*
if(isset($_GET['cid']))
		{
		   $query  = "SELECT cid, first, last, year, age, gender ".
					 "FROM collegiate ".
					 "WHERE cid = '{$_GET['cid']}'";
		   $result = mysql_query($query) or die('Error : ' . mysql_error());
		   list($cid, $first, $last, $year, $age, $gender) = mysql_fetch_array($result,                                                    MYSQL_NUM);

	   $content = htmlspecialchars($content);
	}

*/
$update_profile->get_runner_data();

if (isset($_POST['profile_data'])) {

$update_profile->save_profile_date($_POST['id'], $_POST['first'], $_POST['last'], $_POST['year'], $_POST['age'], $_POST['gender']); 
} 
$error = $update_profile->the_msg; // error message


?>

<html>
<head>
<title>Admin Page For Add Management System</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
</head>
<body>
<form name="form1" method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
		<!--<input type="hidden" name="cid" value="<=$cid;?>"> -->
	   <table width="500" border="0" cellpadding="2" cellspacing="1" class="box" align="center">
		<tr> 
		  <td width="100">first</td>
		  <td><input name="first" type="text" class="box" id="first" value="<?=$first;?>"></td>
		</tr>
		<tr> 
		  <td width="100">last</td>
		  <td><input name="last" type="text" class="box" id="last" value="<?=$last;?>"></td>
		</tr>
		<tr> 
		  <td width="100">year</td>
		  <td><input name="year" type="text" class="box" id="year" value="<?=$year;?>"></td>
		</tr>
		<tr> 
		  <td width="100">age</td>
		  <td><input name="age" type="text" class="box" id="age" value="<?=$age;?>"></td>
		</tr>
		<tr> 
		  <td width="100">gender</td>
		  <td><input name="gender" type="text" class="box" id="gender" value="<?=$gender;?>"></td>
		</tr>
		<tr> 
		  <td width="100">&nbsp;</td>
		  <td>&nbsp;</td>
		</tr>
		<tr> 
		  <td colspan="2" align="center"><input type="hidden" name="id" value="<?php echo  $update_profile->profile_id; ?>">
		  <input name="profile_data" type="submit" class="box" id="profile_data" value="Update Runner"></td>
		</tr>
	  </table>
	 <p align="center"><a href="add_manage_coll.php">Back to admin page</a></p>
	</form>
</body>
</html>

[bradgrafelman]

sql = sprintf("SELECT cid, user_id, first, last, year, age, gender FROM %s WHERE cid = $uid", PROFILE_TABLE, $this->uid); 

Where you have $uid, I think you meant to put %s, to insert the string. Otherwise, you have one too many parameters.

[natman3]

yes you right. However the form does not populate with the SELECT information it does show up but with nothing in it.

in my form am i calling the echo correctly by using <? =$first?>

[bradgrafelman]

After that SQL statement, add this:

printf("SELECT cid, user_id, first, last, year, age, gender FROM %s WHERE cid = $uid", PROFILE_TABLE, $this->uid); // DEBUG LINE

and then after:

if (mysql_num_rows($result) == 0) { 

add this:

echo "<br>Result set was 0 rows"; // DEBUG LINE

Paste both of the output lines here.

[natman3]

It looks like my SELECT is not selecting the right row. Because when i used this code:

$sql = sprintf("SELECT cid, user_id, first, last, year, age, gender FROM %s WHERE cid = $uid", PROFILE_TABLE, $this->uid);

	$result = mysql_query($sql) or die (mysql_error());
	// DEBUG LINE
	if (mysql_num_rows($result) == 0) {
	echo "<br>Result set was 0 rows"; // DEBUG LINE
	}

my out put was: just a blank screen

[bradgrafelman]

printf("SELECT cid, user_id, first, last, year, age, gender FROM %s WHERE cid = $uid", PROFILE_TABLE, $this->uid); // DEBUG LINE

You didn't add that line to your code. That will output the query it is running on the SQL database.

Please add that line and let me know what it outputs.

[natman3]

ok i see ok let me fix that

[natman3]

i used this code:

$sql = sprintf("SELECT cid, user_id, first, last, year, age, gender FROM %s WHERE cid = $uid", PROFILE_TABLE, $this->uid);		
		$result = mysql_query($sql) or die (mysql_error());
		printf("SELECT cid, user_id, first, last, year, age, gender FROM %s WHERE cid = $uid", PROFILE_TABLE, $this->uid); 
		// DEBUG LINE
		if (mysql_num_rows($result) == 0) {
		echo "<br>Result set was 0 rows"; // DEBUG LINE
}

ok this is what printed out : SELECT cid, user_id, first, last, year, age, gender FROM collegiate WHERE cid = 56

[bradgrafelman]

Alright, change this:

        while ($obj = mysql_fetch_object($result)) { 
            $this->profile_id = $obj->cid; 
            $this->first = $obj->first; 
            $this->last = $obj->last; 
            $this->year = $obj->year; 
            $this->age = $obj->age; 
            $this->gender = $obj->gender;                 

            } 

to this:

        while ($obj = mysql_fetch_object($result)) { 
            $this->profile_id = $obj->cid; 
            $this->first = $obj->first; 
            $this->last = $obj->last; 
            $this->year = $obj->year; 
            $this->age = $obj->age; 
            $this->gender = $obj->gender;
            echo $this->profile_id . "<br>" . $this->first . "<br>" . $this->last . "<br>" . $this->year . "<br>" . $this->age . "<br>" . $this->gender;   // DEBUG LINE   

            } 

And let me know what it outputs.

[natman3]

nothing outputted to the screen.

[natman3]

never mind i got hte values i had imporperly placed the code sorry
this is what i got:

56
jenny
brown
senior
12
f

[bradgrafelman]

I'm not any good with classes, so I don't know what's wrong at this point. You can try changing this:

<td colspan="2" align="center"><input type="hidden" name="id" value="<?php echo  $update_profile->profile_id; ?>"> 

to this:

<td colspan="2" align="center"><input type="hidden" name="id" value="<?=$update_profile->profile_id;?>"> 

but I doubt that will change anything. Sorry!

[natman3]

interesting.. it worked that fiex it. If you would like to take alook you can go to http://www.chilepepperfestival.org/user/login.php

user: millerp
pw: 1234

click on the link to add/manager to view if you like

Thank you for your help. Now on to see if there are any other errrors else where i need to fix.

[bradgrafelman]

ROFL. You're joking.

😃 bows

Don't forget to mark this thread resolved!

EDIT: Also, remove all lones that are appended with ' // DEBUG LINE' 🙂

[natman3]

great... I get an error when i try to submit the edited information

error is: You have an error in your SQL syntax near '' at line 1

i think it has to do with this function:

function save_profile_date($ident = "", $first = "", $last = "", $year = "", $age = "", $gender = "") {
		if ($_SESSION['is_rec']) {
			$sql = sprintf("UPDATE %s SET first=%s, last=%s, year=%s, age=%s, gender=%s, last_change=NOW() WHERE cid = %s AND user_id = %s", 
				PROFILE_TABLE, $this->ins_string($first), $this->ins_string($last), $this->ins_string($year),
				$this->ins_string($age), $this->ins_string($gender), $this->ins_string($ident, "int"), $_SESSION['user_id']);
		} else {
			$sql = sprintf("INSERT INTO %s (cid, user_id, first, last, year, age, gender, last_change) VALUES (NULL, %s, %s, %s, %s, %s, %s, NOW())",
				PROFILE_TABLE, $_SESSION['user_id'], $this->ins_string($first), $this->ins_string($last), 
				$this->ins_string($year), $this->ins_string($age), $this->ins_string($gender));
		}	
		if (mysql_query($sql) or die (mysql_error())) {
			$this->profile_id = (!$_SESSION['is_rec']) ? mysql_insert_id() : $ident;
			$this->the_msg = $this->extra_text(2);
		} else {			
			$this->the_msg = $this->extra_text(3);
		}
	}

[bradgrafelman]

After every sprintf() statement, copy and paste it to the next line, and change sprintf() to printf() so that the query is outputted.

Then paste the queries in here.

[natman3]

i used this code:

function save_profile_date($ident = "", $first = "", $last = "", $year = "", $age = "", $gender = "") {
		if ($_SESSION['is_rec']) {
			$sql = sprintf("UPDATE %s SET first=%s, last=%s, year=%s, age=%s, gender=%s, last_change=NOW() WHERE cid = %s AND user_id = %s", 
				PROFILE_TABLE, $this->ins_string($first), $this->ins_string($last), $this->ins_string($year),
				$this->ins_string($age), $this->ins_string($gender), $this->ins_string($ident, "int"), $_SESSION['user_id']);
		 	printf("UPDATE %s SET first=%s, last=%s, year=%s, age=%s, gender=%s, last_change=NOW() WHERE cid = %s AND user_id = %s", 
				PROFILE_TABLE, $this->ins_string($first), $this->ins_string($last), $this->ins_string($year),
				$this->ins_string($age), $this->ins_string($gender), $this->ins_string($ident, "int"), $_SESSION['user_id']);

	} else {
		$sql = sprintf("INSERT INTO %s (cid, user_id, first, last, year, age, gender, last_change) VALUES (NULL, %s, %s, %s, %s, %s, %s, NOW())",
			PROFILE_TABLE, $_SESSION['user_id'], $this->ins_string($first), $this->ins_string($last), 
			$this->ins_string($year), $this->ins_string($age), $this->ins_string($gender));

		printf("INSERT INTO %s (cid, user_id, first, last, year, age, gender, last_change) VALUES (NULL, %s, %s, %s, %s, %s, %s, NOW())",
			PROFILE_TABLE, $_SESSION['user_id'], $this->ins_string($first), $this->ins_string($last), 
			$this->ins_string($year), $this->ins_string($age), $this->ins_string($gender));

	}	
	if (mysql_query($sql) or die (mysql_error())) {
		$this->profile_id = (!$_SESSION['is_rec']) ? mysql_insert_id() : $ident;
		$this->the_msg = $this->extra_text(2);
	} else {			
		$this->the_msg = $this->extra_text(3);
	}
}	

and this is what printed to the scree: You have an error in your SQL syntax near '' at line 1

[bradgrafelman]

Alrighty. Get rid of all of the printf()'s I had you put in, and change:

if (mysql_query($sql) or die (mysql_error())) { 

to:

if (mysql_query($sql) or die (mysql_error() . '<br>' . $sql)) { 

Also, if the query doesn't successfully run, the die() command will be executed and nothing in your else statement will ever be run...