mysql_numrows(): supplied argument is not a valid MySQL result resource in

nawal

This is my prog... i dont know what is prob. anyone pls tell me..

<?
include("dbinfo.inc.php");
mysql_connect($dbhost,$username,$password);
mysql_select_db($database) or die( "Unable to select database");
$query="SELECT * FROM contacts";
$result=mysql_query($query);

$num=mysql_numrows($result); //THIS IS LINE 8

mysql_close();

echo "<center>Database Output</center> ";

?>

<table width="2120border="0" cellspacing="2" cellpadding="2">
<tr bgcolor="#99CCFF">
<td width="20">ID</td>
<td width="300">Library Name</td>
<td width="100">Code</td>
<td width="100">Category</td>
<td width="100">Address</td>
<td width="100">Postcode</td>
<td width="100">District</td>
<td width="100">DUN</td>
<td width="100">Parliament</td>
<td width="100">Contact Num</td>
<td width="100">E-Mail</td>
<td width="100">Website</td>
<td width="100">Employee Name</td>
<td width="100">Employee Post</td>
<td width="100">Day 1</td>
<td width="100">Time 1</td>
<td width="100">Day 2</td>
<td width="100">Time 2</td>
<td width="100">Day 3</td>
<td width="100">Time 3</td>
</tr>

<?
$i=0;
while ($i < $num) {
$libName =mysql_result($result,$i,"libName");
$libCode =mysql_result($result,$i,"libCode");
$libCat =mysql_result($result,$i,"libCat");
$address =mysql_result($result,$i,"address");
$postcode =mysql_result($result,$i,"postcode");
$district =mysql_result($result,$i,"district");
$dun =mysql_result($result,$i,"dun");
$par =mysql_result($result,$i,"par");
$phone =mysql_result($result,$i,"phone");
$email =mysql_result($result,$i,"email");
$web =mysql_result($result,$i,"web");
$empName =mysql_result($result,$i,"empName");
$empPost =mysql_result($result,$i,"empPost");
$day1 =mysql_result($result,$i,"day1");
$time1 =mysql_result($result,$i,"time1");
$day2 =mysql_result($result,$i,"day2");
$time2 =mysql_result($result,$i,"time2");
$day3 =mysql_result($result,$i,"day3");
$time3 =mysql_result($result,$i,"time3");

<tr>
<td><? echo "$libName"; ?></td>
<td><? echo "$libCode"; ?></td>
<td><? echo "$libCat"; ?></td>
<td><? echo "$address"; ?></td>
<td><? echo "$postcode"; ?></td>
<td><? echo "$district"; ?></td>
<td><? echo "$dun"; ?></td>
<td><? echo "$par"; ?></td>
<td><? echo "$phone"; ?></td>
<td><a href="mailto:<? echo "$email"; ?>">E-mail</a></td>
<td><a href="<? echo "$web"; ?>">Website</a></td>
<td><? echo "$empName"; ?></td>
<td><? echo "$empPost"; ?></td>
<td><? echo "$day1"; ?></td>
<td><? echo "$time1"; ?></td>
<td><? echo "$day2"; ?></td>
<td><? echo "$time2"; ?></td>
<td><? echo "$day3"; ?></td>
<td><? echo "$time3"; ?></td>

</tr>
<?
++$i;
}
echo "</table>";

//THIS IS LINE 8 //THIS IS LINE 8

bradgrafelman

Isn't it [man]mysql_num_rows/man ?

Also, try changing:

$result=mysql_query($query);

to:

$result=mysql_query($query) or die('Query could not be run:' . mysql_error());

kkobashi

You need a database $link.... and its mysql_num_rows, not mysql_numrows

Errors marked in italics.

$link = mysql_connect($dbhost,$username,$password);
mysql_select_db($database, $link ) or die( "Unable to select database");
$query="SELECT * FROM contacts";
$result=mysql_query($query, $link );

$num=mysql_num_rows/I; //THIS IS LINE 8

mysql_close($link );

bradgrafelman

The DB link is not required.

If you have only one connection to MySQL opened in the script, it is assumed you are using that connection.

kkobashi

And you consider that good programming? Remember, these are newbs. If they don't learn to do it right now, it will carry over to bad programming later.

He'll open up another database connection and then it will be a nightmare to troubleshoot this problem.

Not a good programming practice, IMHO.

bradgrafelman

Too true.

Hey, nawal. Add a DB link identifier and fix the noted MySQL function and let us know :p

nawal

it works.. tq....

but i hav prob.. i make update page but it not work. here the warning:

Notice: Undefined index: id in D:\LITRAS\emot\update.php on line 6

and below the code:

<?
include("dbinfo.inc.php");

$link = mysql_connect($dbhost,$username,$password);
mysql_select_db($database, $link) or die( "Unable to select database");
$id = $_POST['id']; // THIS IS LINE 6

$query="SELECT * FROM library WHERE id='$id' ";
$result=mysql_query($query, $link);
$num=mysql_num_rows($result);
mysql_close($link);

$i=0;
while ($i < $num) {

$id =mysql_result($result,$i,"id");
....

$zone =mysql_result($result,$i,"zone");

    <table width="684" border="0" bordercolor="#003399" bgcolor="#99CCFF">
      <tr>
        <td colspan="3" class="style58"><u>LIBRARY INFORMATION</u> </td>
        </tr>
      <tr>
        <td width="188">&nbsp;</td>
        <td width="8">&nbsp;</td>
        <td width="466">&nbsp;</td>
      </tr>
      <tr>
        <td><p class="style55"><strong>**</strong> Library Name </p>

            <input name="libName" type="text" id="libName" size="70" value="<? echo "$libName"?>">

            <p>&nbsp;</p></td>
      </tr>
      <tr>
        <td><p class="style55"><strong>**</strong> Library Code</p>
            <p class="style55">&nbsp;</p></td>
        <td><p class="style42">:</p>
            <p class="style42">&nbsp;</p></td>
        <td>
            <select name="<? echo "$libCode"?>" id="libCode">
				<OPTION value="-" >-</OPTION>
				<option value="EP">EP</option>
            </select>

            <p>&nbsp;</p></td>
      </tr>
      <tr>
        <td><p class="style55"><strong>**</strong>Library Category</p>
            <p class="style55">&nbsp;</p></td>
        <td><p class="style42">:</p>
            <p class="style42">&nbsp;</p></td>
        <td>
          <select name="<? echo "$libCat"?>" id="libCat">
            <option value="PUSAT">PUSAT</option>
            <option value="E-PUSTAKA">E-PUSTAKA</option>
          </select>

            <p>&nbsp;</p></td>
      </tr>
                  <td colspan="3"><span class="style58"><U>LIBRARY ADDRESS / CONTACT</U></span></td>
        </tr>
      <tr>
                  </tr>
      <tr>
        <td><p class="style55"><strong>**</strong> Address</p>
            <p class="style55">&nbsp;</p></td>
        <td><p class="style42">:</p>
            <p class="style42">&nbsp;</p></td>
        <td>
            <input name="address" type="text" id="address" size="70" value="<? echo "$address"?>">

            <p>&nbsp;</p></td>
      </tr>
      <tr>
        <td><p class="style55"><strong>**</strong> Postcode</p>
            <p class="style55">&nbsp;</p></td>
        <td><p class="style42">:</p>
            <p class="style42">&nbsp;</p></td>
        <td>
            <input name="postcode" type="text" id="postcode" size="15" value="<? echo "$postcode"?>">

            <p>&nbsp;</p></td>
      </tr>
      <tr>
        <td><p class="style55"><strong>**</strong> District</p>
            <p class="style55">&nbsp;</p></td>
        <td><p class="style42">:</p>
            <p class="style42">&nbsp;</p></td>
        <td>
            <select name="<? echo "$district"?>"  id="district">
			<OPTION value="-" >-</OPTION>
              <option value="Pusat">PU</option>

...
...

              <option value="E-Pustaka">EP</option>
            </select>

            <p>&nbsp;</p></td>
      </tr>
                <tr>
        <td><p class="style55"><strong>**</strong> Parliament</p>
            <p class="style55">&nbsp;</p></td>
        <td><p class="style42">:</p>
            <p class="style42">&nbsp;</p></td>
        <td>
            <select name="<? echo "$par"?>"  id="par">
			  <OPTION value="-" >-</OPTION>
              <option value="Pusat">PU</option>

..
..
..

              <option value="E-Pustaka">EP</option>
            </select>

            <p>&nbsp;</p></td>
      </tr>
      <tr>
        <td><p class="style55"><strong>**</strong> Contact Number </p>
            <p class="style55">&nbsp;</p></td>
        <td><p class="style42">:</p>
            <p class="style42">&nbsp;</p></td>
        <td>
            <input name="phone" type="text" id="phone" size="20" value="<? echo "$phone"?>">

            <p>&nbsp;</p></td>
      </tr>
      <tr>
        <td><p class="style55">Email <strong>(optional) </strong></p>
            <p class="style55">&nbsp;</p></td>
        <td><p class="style42">:</p>
            <p class="style42">&nbsp;</p></td>
        <td>
            <input name="email" type="text" id="email" size="50" value="<? echo "$email"?>">

            <p>&nbsp;</p></td>
      </tr>
      <tr>
        <td><p class="style55">Website<strong>(optional) </strong></p>
            <p class="style55">&nbsp;</p></td>
        <td><p class="style42">:</p>
            <p class="style42">&nbsp;</p></td>
        <td>
            <input name="web" type="text" id="web" size="50" value="<? echo "$web"?>">

            <p>&nbsp;</p></td>
      </tr>
      <tr>
        <td><span class="style56"></span></td>
        <td>&nbsp;</td>
        <td>&nbsp;</td>
      </tr>
      <tr>
        <td><span class="style58"><U>EMPLOYEE INFO</U></span></td>
        <td>&nbsp;</td>
        <td>&nbsp;</td>
      </tr>
      <tr>
        <td><span class="style56"></span></td>
        <td>&nbsp;</td>
        <td>&nbsp;</td>
      </tr>
      <tr>
        <td><p class="style55">Employee Name</p>
            <p class="style55">&nbsp;</p></td>
        <td><p class="style42">:</p>
            <p class="style42">&nbsp;</p></td>
        <td>
            <input name="empName" type="text" id="empName" size="70" value="<? echo "$empName"; ?>">

            <p>&nbsp;</p></td>
      </tr>
      <tr>
        <td><p class="style55">Employee Post </p>
            <p class="style55">&nbsp;</p></td>
        <td><p class="style42">:</p>
            <p class="style42">&nbsp;</p></td>
        <td>
            <input name="empPost" type="text" id="empPost" size="70" value="<? echo "$empPost"?>">

            <p>&nbsp;</p></td>
      </tr>
      <tr>
        <td><span class="style56"></span></td>
        <td>&nbsp;</td>
        <td>&nbsp;</td>
      </tr>
      <tr>
        <td><span class="style58"><U>LIBRARY TIMETABLE</U> </span></td>
        <td>&nbsp;</td>
        <td>&nbsp;</td>
      </tr>
      <tr>
        <td><span class="style56"></span></td>
        <td>&nbsp;</td>
        <td>&nbsp;</td>
      </tr>
      <tr>
        <td><p class="style55 style64 style56"><strong>**</strong>Category</p>
            <p class="style55">&nbsp;</p></td>
        <td><p class="style65">:</p>
            <p class="style65">&nbsp;</p></td>
        <td><span class="style55">

<select name="<? echo "$idTime"; ?>"id="idTime">
<option value="None">-</option>
<option value="PPAK">PPAK</option>
<option value="Others">Others</option>
</select>

 </td>
</tr>
<tr>
<td>** Consolation Hour / Day 
 </td>
<td>:
 </td>
<td>

<select name="<? echo "$zone"?>" id="zone">
<option value="None">-</option>
<option value="A">Monday, Friday, Saturday - Thursday : 12pm-6pm / 9am-12pm / 9am-6pm</option>
<option value="B">Thursday, Saturday-Wednesday : 10am-2.25pm / 10am-6.15pm</option>
</select>

                </span> 
            <span class="style55">

            </span>

            <p>&nbsp;</p></td>
      </tr>
      <tr>
        <td><span class="style56"></span></td>
        <td>&nbsp;</td>
        <td>&nbsp;</td>
      </tr>
      <tr>
        <td><span class="style56"></span></td>
        <td>&nbsp;</td>
        <td>&nbsp;</td>
      </tr>
      <tr>
        <td height="28" ><span class="style56">
          <input type="submit" name="Submit" value="Submit">
        </span></td>
        <td>&nbsp;</td>
        <td>&nbsp;</td>
      </tr>
    </table>

</form>

<?
++$i;
}
?>

kkobashi

Check out isset()...

Your POST variable may not be set at the time of the call.

Here's a code snippet. Notice how this is setup:

File: Login.php

<?php

// Is this a HTTP_POST?
if $isset($POST["username"])) && $isset($POST["password"]))
{
// validate the data
// do database stuff

return;

}
else // No, its a request to GET the file
{
// show the form
$strForm <<<LOGINFORM
<form>
blah blah blah
</form>
LOGINFORM;

 echo $strForm;
}

In most cases, i don't code like the above and break it up using OOP. But this should get the point across.