Php Navigation

Mr_Chew

I currently am facing a problem I have asked a knowledgable PHP user who is stumped as well, regarding a simple PHP navigation...

if(!is_null($_GET['id'])) {
    $filename = $_GET['id'].".php";
    if(file_exists($filename)) {
        require_once("$filename");
    } else {
        echo "<p>The page <strong>\"".$_GET['id']."\"</strong> that you requested does not exist on this server!</p>";
    }
} else {
    require_once("main.php");
}

-The above code is implemented in the 'content' section of my website. When I tested to see if the navigation worked typing this into the browser: http://www.mysite.com/index.php?id=main, it worked. However and more importantly, my issue is that I cannot implement a floodbox php file into my site when I link text on my left navigation menu to the 'content' area.

-I created a shoutbox.php file which only contains:

include("shoutbox/floodbox.php");

-When I created a link to open up the floodbox in the 'content' section, I put http://www.mysite.com/index.php?id=shoutbox , which of course would 'include' the floodbox file... I receive an error that says "can't open file"

If anyone can help me out I would appreciate it, and if you need more information that I may have left out, please let me know. Thanks

bpat1434

Including files is better if you use a direct path from the root of the server.

You would be better to use this in your shoutbox.php page:

include($_SERVER['DOCUMENT_ROOT'].'/shoutbox/floodbox.php');

~Brett

Mr_Chew

I've been using the include() for my entire index.php file...I don't think you're understanding what I mean -

In the 'content' area of my layout, I have this code implemented:

<?php
if(!is_null($_GET['id'])) { //if the get variable "id" exists in the url....
    $filename = $_GET['id'].".php"; //set the potential include URL to the filename of the url + the extension ".php"
    if(file_exists($filename)) { //if the file exists on the filesystem
        require_once("$filename"); //include the code from the file.php into this code
    } else { //if the file of that name does not exist....
        echo "<p>The page <strong>\"".$_GET['id']."\"</strong> that you requested does not exist on this server!</p>";
    }
} else { //if the file isn't set (blank url...load home page)
    require_once("main.php"); //load the home page content (assumed to be main.php)
}
?>

by default, it includes the file main.php... so if I type www.mysite.com/index.php?id=main ,it works... HOWEVER...

On my left navigation box, when I make a link to include a floodbox php file to open in the content section, it says 'can't open file'

bpat1434

I got what you meant. I'm saying that it's better to be safe. When you use the relative location, you have to be careful. Is there a directory shoutbox with the file floodbox.php in it? And is that contained in the same place as the index.php file? If so, then you should prepend the location with "./" so that php knows to look in the current directory.

Check the path of the file. Also, check permissions that you can read it.

~Brett

Mr_Chew

I think I just found the answer to my problem after talking with a buddy of mine...The reason why the floodbox.php file wouldn't load/display in the content box when calling to retreive it is because it is required to be in an iframe to display, which I didn't do... that's why I didn't even have any php error messages, and it simply said "can't open file" -- does this sound logical?

however.. should I still consider using your code as you say it is secure? how is it secure too, can you explain clearer?

bpat1434

It's not that it's more secure, but you won't have as many "unknown" errors and you can save yourself some time in finding it. I always use the includes as inclue($_SERVER['DOCUMENT_ROOT'] so that I know exactly where I'm coming from, and I know exaclty where the file is.

~Brett

Mr_Chew

Can you explain what that include does (break down each part) and why it's better than doing it that way?

inclue($_SERVER['DOCUMENT_ROOT']

bpat1434

The global variable $_SERVER['DOCUMENT_ROOT'] refers to the root of your website. Normally it's /public_html (notice there's no trailing slash). By doing it this way, you KNOW for a FACT of where exactly the include is going to look for the file. Using relative includes like include("../somefile.php") is a little more confusing. Especially if you get a small error, and you don't know where/why.

It's not more secure, but it is definately better for finding errors, and knowing exactly where php is looking for the script.

Then, after you use the global variable, you provide a route to the script (remember to use a begining slash):
/some/other/directory/file.php

So, to include a file that is located at:
http://www.domain.com/includes/functions/error_handler.php
You could use the include statement of:
include($_SERVER['DOCUMENT_ROOT'].'/includes/functions/error_handler.php');

That will make sure you include the right script.

~Brett

Mr_Chew

Now that I have my floodbox working in an iframe, how do I add a CSS style in the PHP coding to change the colors of my floodbox to match my layout? I tried looking up tutorials, but it's now working for me.