[Resolved] Session Problems

[spriensr]

I am making a shopping basket but I think there is something wrong with the way I do SESSIONS could someone tell me what I am doing wrong

session_start();
function add_item($product_ID,$product_qty)
{

if(session_is_registered("sess_prod_id")){
$valid=FALSE;
$howmany=count($sess_prod_id)-1;

for($counter=0;$counter<=$howmany;$counter++){
if($SESSION["sess_prod_id"][$counter]==$product_ID){
$SESSION["sess_prod_qty"][$counter]=$SESSION["sess_prod_qty"][$counter]+$product_qty;
$valid=TRUE;
}
}
if($valid=FALSE){
$new_entry=count($SESSION["sess_prod_id"]);
$SESSION["sess_prod_id"][$new_entry]=$product_ID;
$SESSION["sess_prod_qty"][$new_entry]=$proeduct_qty;
}
}

else{
$sess_prod_id[0]=$product_ID;
$sess_prod_qty[0]=$product_qty;
session_register("sess_prod_id");
session_register("sess_prod_qty");
}
require("connector.php");
$global_dbh;
$global;
// if not array then print statement
if(session_is_registered("sess_prod_id" )){
print("<CENTER>");
print("<TABLE cellspacing=0 cellpadding=2 border=1>");
print("<TR>");
print("<TD><b>Shopping Basket</b></TD>\n");
print("</TR>\n");
print("<TR>");
print("<TD>");
print("<TABLE border=0>");
print("<TR><TD colspan=2><b>Items</b></TD></TR>\n");
print("<TR>\n");
print("<TD><b><font size=-1>Name</font></b></TD>\n");
print("<TD><b><font size=-1>Size</font></b></TD>\n");
print("<TD><b><font size=-1>Qty.</font></b></TD>\n");
print("<TD><b><font size=-1>Price</font></b></TD>\n");
print("<TD><b><font size=-1>Total</font></b></TD>\n");
print("<TD><b><font size=-1>Remove</font></b></TD>\n");
print("</TR>\n");

//variables for getting the price totals to view in the basket
$Total=0;
$GTotal=0;
$howmany=count($_SESSION["sess_prod_id"])-1;

//this will loop through the array and do a query and post information in the basket
for($counter=0;$counter<=$howmany;$counter++)
{
$theid=$_SESSION["sess_prod_id"][$counter];
$query="SELECT* FROM Product WHERE prd_ID='$theid'";

$result=mysql_query($query);
$row=my_sql_fetch_array($result);

print("<TR>");
print("<TD valign=top><b>$row[prd_Name]</b></td>\n");
print("<TD valign=top><b>$row[prd_Size]</b></td>\n");
print("<TD valign=top><input type=text size=2 value=\"{$_SESSION['sess_prod_qty'][$counter]}\"></TD>\n");
print("<TD valign=top>$row[prd_Price]</TD>\n");
$Total=($row[prd_Price] * $_SESSION["sess_prod_qty"][$counter]);
$GTotal=($GTotal + $Total);
print("<form action=\"viewbasket.php\" action=\"POST\">\n");
print("<TD valign=top><input type=checkbox name=\"productID\" value=\"{$_SESSION['sess_prod_id'][$counter]}\"></TD>\n");
print("</TR>\n");

}

//printing results
print("<TR>\n");
print("<TD colspan=2>&nbsp;</TD>\n");
print("<TD valign=top><b>Total:</b></TD>\n");
print("<TD valign=top>\$$GTotal</TD>\n");
print("<TD valign=top><input type=\"submit\" value=\"DELETE\"></TD>\n");
print("</TR>\n");
print("</TABLE>\n");
print("</TABLE>\n");

print("</Center>");
}

else
{
print("<H1><Center>There is nothing in the basket yet.</center></H1>");

}

}
?>session session_start(); $SESSION sess

[spriensr]

OH I forgot to mention, the shopping basket appears but nothing is in it. So I don't think that the SESSION works right or could it be my mySQL query

[zbee]

From what I see the session and the query look fine, but if you wanted to make sure, just echo the session variables, and the query. If they return values, you're code is probably right. Now, try not to use so many print's. Anyway, I did find several errors on your code:

 
$theid=$_SESSION["sess_prod_id"][$counter];
$query="SELECT* FROM Product WHERE prd_ID='$theid'";

$result=mysql_query($query);
$row=my_sql_fetch_array($result);

print("<TR>"); 
print("<TR>");
//Error Below
print("<TD valign=top><b>$row[prd_Name]</b></td>\n");
print("<TD valign=top><b>$row[prd_Size]</b></td>\n");
print("<TD valign=top><input type=text size=2 value=\"{$_SESSION['sess_prod_qty'][$counter]}\"></TD>\n");
print("<TD valign=top>$row[prd_Price]</TD>\n");
$Total=($row[prd_Price] * $_SESSION["sess_prod_qty"][$counter]);
$GTotal=($GTotal + $Total);
print("<form action=\"viewbasket.php\" action=\"POST\">\n");
print("<TD valign=top><input type=checkbox name=\"productID\" value=\"{$_SESSION['sess_prod_id'][$counter]}\"></TD>\n");
print("</TR>\n"); 

Use

$row=mysql_fetch_array($result);

not

$row=my_sql_fetch_array($result);

and your array will be like this:
$row['field1'], $row['field2'], etc.
If you need to print it inside the column do it like this:

print("<TD valign=top><b>".$row['prd_Name']."</b></td>\n");

[spriensr]

thx for the help zbee. I made the changes and the code still works the same. I tried echoing the session array sess_prod_id but nothing showed up so I still think the session is the problem

[zbee]

Ok, I've been checking the code on the session part, and there several things I'd recommend.
First, using session_register is considered obsolete. Instead, use $_SESSION['variable_name'] to register your session variables.
Second, turn errors on in the php.ini to see the error messages, (unless of course it's your produccion server) 'cause I'm pretty sure there's an "Undefined variable" error somewhere.

Also, I'm not sure what your intention was on this line of code:

require("connector.php"); 
$global_dbh; 
$global; 

And last but not least, I'm not sure how you are invoking the function add_item ('cause it's not enough with declaring it). Are you sure the parameters that you are inputting on it are correct?

[spriensr]

THX again

the code

require("connector.php");

$global_dbh;

$global;

is just info to connect to the database.

as for the function i'm calling the function from another file to display the basket. the parameters are correct. I use $_POST to get the parameters and had the page print the results of the post so i know they are passing the correct code.

I call the function with the code

add_item($product_ID,$product_qty);

I use the require command to put in the web page.
do you think I should be using the include command instead???

the site that I'm working on is www.minotaurshoes.com
Take a look if you think that would help

[zbee]

Sorry I couldn't answer you yesterday but I had some things to do. Anyway, let's try and see if the session variables are properly set up.

echo "<pre>";
print_r(array_change_key_case($_SESSION)); 
echo "<pre>";

This will return all the session variables that you have set up. I'd advise you to do this on a restricted directory, otherwise anyone could see your session varible names, which is not a major security breach, but a security breach nonetheless.

[spriensr]

What I got using your last code was

Warning: array_change_key_case(): The argument should be an array

So for some reason, it doesn't see the SESSION as an array which would explain why nothing shows up on my loops and an empty basket shows up.

Any ideas on why this isn't consider an array???

[zbee]

It could be several things. Either the session variables aren't being registered, or the session wasn't started. Are you sure that before anything in your code, there's a

session_start();

?
Check that.

[spriensr]

yep,
the session_start();

starts right at the top of my code.

Oh yeah,

that last warning I showed you was for $_SESSION['sess_prod_id']

For just using that command $_SESSION I got

Array
(
)

Oh yeah, the other thing is that I got the files doing session_start(); on the page then it calls the function that has session_start(); at the top of that page. should one of these be removed???

[zbee]

yes it should but I don't think this should be a problem. Ok, instead of doing a session_register, why don't you try registering your session variable like this

$_SESSION['variable_name'] = "variable value";

[spriensr]

here is update on code

session_start();
function add_item($product_ID,$product_qty)
{

if(session_is_registered("sess_prod_id")){
$valid=FALSE;	
$howmany=count($sess_prod_id)-1;

for($counter=0;$counter<=$howmany;$counter++){
 	if($_SESSION["sess_prod_id"][$counter]==$product_ID){
	 	$_SESSION["sess_prod_qty"][$counter]=$_SESSION["sess_prod_qty"][$counter]+$product_qty;
		$valid=TRUE;
}	 	
}	 		 	
	 if($valid=FALSE){
		$new_entry=count($_SESSION["sess_prod_id"]);
		$_SESSION["sess_prod_id"][$new_entry]=$product_ID;
		$_SESSION["sess_prod_qty"][$new_entry]=$proeduct_qty;
}
}

else{
	$sess_prod_id[0]=$product_ID;
	$sess_prod_qty[0]=$product_qty;	
	$_SESSION["sess_prod_id"];
	$_SESSION["sess_prod_qty"];
}	
require("connector.php");
$global_dbh;
$global;
// if not array then print statement
if(session_is_registered("sess_prod_id" )){
	print("<CENTER>");
	print("<TABLE cellspacing=0 cellpadding=2 border=1>");
	print("<TR>");
	print("<TD><b>Shopping Basket</b></TD>\n");
	print("</TR>\n");
	print("<TR>");
	print("<TD>");
	print("<TABLE border=0>");
	print("<TR><TD colspan=2><b>Items</b></TD></TR>\n");
	print("<TR>\n");
	print("<TD><b><font size=-1>Name</font></b></TD>\n");
	print("<TD><b><font size=-1>Size</font></b></TD>\n");
	print("<TD><b><font size=-1>Qty.</font></b></TD>\n");
	print("<TD><b><font size=-1>Price</font></b></TD>\n");
	print("<TD><b><font size=-1>Total</font></b></TD>\n");
	print("<TD><b><font size=-1>Remove</font></b></TD>\n");
	print("</TR>\n");

//variables for getting the price totals to view in the basket
$Total=0;
$GTotal=0;
$howmany=count($_SESSION["sess_prod_id"])-1;


//this will loop through the array and do a query and post information in the basket
for($counter=0;$counter<=$howmany;$counter++)
{
$theid=$_SESSION["sess_prod_id"][$counter];
$query="SELECT* FROM Product WHERE prd_ID='$theid'";

$result=mysql_query($query);
$row=my_sql_fetch_array($result);	

print("<TR>");
print("<TD valign=top><b>".$row['prd_Name']."</b></td>\n");
print("<TD valign=top><b>".$row['prd_Size']."</b></td>\n");
print("<TD valign=top><input type=text size=2 value=".$_SESSION["sess_prod_qty"][$counter]."></TD>\n");
print("<TD valign=top>".$row['prd_Price']."</TD>\n");
$Total=($row[prd_Price] * $_SESSION["sess_prod_qty"][$counter]);
$GTotal=($GTotal + $Total);
print("<form action=\"viewbasket.php\" action=\"POST\">\n");
print("<TD valign=top><input type=checkbox name=\"productID\" value=".$_SESSION["sess_prod_id"][$counter]."></TD>\n");
print("</TR>\n");


}


//printing results 
	print("<TR>\n");
	print("<TD colspan=2>&nbsp;</TD>\n");
	print("<TD valign=top><b>Total:</b></TD>\n");
	print("<TD valign=top>\$$GTotal</TD>\n");
	print("<TD valign=top><input type=\"submit\" value=\"DELETE\"></TD>\n");
	print("</TR>\n");
	print("</TABLE>\n");
	print("</TABLE>\n");

print("</Center>");
}




else
{
	print("<H1><Center>There is nothing in the basket yet.</center></H1>");


}

}

[zbee]

could you post the code where you are calling the function?

[spriensr]

The session is now working, the only thing I need to work on is displaying the data in the basket.

Thank you very much for your help.

[zbee]

No problem. Check out the Macromedia page. They have some shopping carts, and the code is pretty clean. Just to get some ideas.

[neerav]

I know you marked the thread resolved, but this might help you in displaying the basket

if($valid=FALSE){ 

should be

if($valid==FALSE){ 

Otherwise you are setting $valid to false every single time.