[Resolved] loop problem

[jamesbush]

i am having a problem writing a simple loop.

the code i have is:

<?
$news_array = getimages($clientid,$projectid);
$result=count($news_array);
?>

<?
foreach ($news_array as $item){
$image=$item[image];
$number = $result;
$x = 0;
if ($x < $number) {
$namenumber = $x + 1;
echo "image$namenumber=../images/clients/projects/$image&";
}
++$x;
}
?>

the problem is that it if there are 2 records it write both records, twice. as in:

image1=../images/clients/projects/img1.jpg&image1=../images/clients/projects/img2.jpg&image2=../images/clients/projects/img1.jpg&image2=../images/clients/projects/img2.jpg&

obviously i only want it to write:

image1=../images/clients/projects/img1.jpg&image2=../images/clients/projects/img2.jpg&

any ideas?
thanks,
james

[dewen]

did you check how many items in the image array?

try print_r($news_array)

[jamesbush]

thanks for the reply.

yes i did check. i know there are only 2 in the array.

i can get it to write the correct number of results back, just not get it to write the array numbers correctly.

the problem really lies with my array code, not actually returning the records from the db.

it writes: image1=img1.jpg&image1=img2.jpg

what i need is: image1=img1.jpg&image2=img2.jpg

if that makes sense.

[dewen]

can you post your print_r($news_array)?

[laserlight]

You're initialising $x to 0 and increasing it by 1 on every iteration.
You could initialise $x outside of the loop, and increment it on every iteration.

[jamesbush]

sure, here you go:

Array ( [0] => Array ( [id] => 1 [clientid] => 1 [projectid] => 1 [title] => virgin test [image] => img1.jpg ) [1] => Array ( [id] => 2 [clientid] => 1 [projectid] => 1 [title] => test2 [image] => img2.jpg ) )

[jamesbush]

hi laserlight, thanks for the reply.

i understand what you are saying, but how would i do that?

[dewen]

I can't see why you need:

------- if ($x < $number) {

But try this format:

<?php
$x = 1; 
foreach ($news_array as $item){ 
	$image=$item['image']; 
	echo "image{$x}=../images/clients/projects/$image&"; 
	$x++; 
} 
?> 

[jamesbush]

thankyou both for your help.
i have it working.
seems i was over complicating things...

final code is:

<?
$x = 1;
foreach ($news_array as $item){
$image=$item[image];
echo "image{$x}=../images/clients/projects/$image&";
$x++;
}
?>

thanks again.
james