Search

[zzz]

I need to search for an item name in my db. Here's the code that I'm trying to use. I keep getting errors, what am I doing wrong?

if($_POST) { 
	$sql  = "SELECT * FROM myTable WHERE 1 = 1"; 
	$sql .= empty($_POST['itemName']) ? NULL : " AND itemName LIKE '%".$_POST['itemName']."%'"; 
	if($items  = $db->get_results($sql)) 
	{
		foreach ( $items as $item )
		{
			echo $item->item_name;
		}
}
else{
	echo "No item found.";
}
						}

[bpat1434]

Well, first off:

What errors?

Second off:

What have you tried to do to alleviate this problem?

Third:

Please don't just say "What am I doing wrong?". Makes people want to help you less.

---

First thing I see is a huge security issue. Try to never use $_POST[] directly in an SQL statement. Rather, assign them to variables, then check that they're what they should be, then run the query.

Next: I think you might be misinterpreting the ternary operator. Perhaps "NULL" is not what you want. I think this might better suit you:
(empty($_POST['itemName'])) ? '' : "itemName LIKE '%".$itemName."%'";

[Drakla]

Have you tried echoing the query before running it?

Is it definitely an SQL error, or something else?

I find that if ($POST) a bit dodgy, too, because if its vagueness - try

if (!empty($_POST['itemName']))

[spriensr]

Here is what I use to do a search Result page

//query to be used
$ProductSearch=$_POST['txtProd'];
$query="SELECT * From Product WHERE prd_Comment Like '%$ProductSearch%'";
$result = mysql_query($query);



//find out how many rows
$num = mysql_num_rows($result);
if( $num < 1)
{
print("<h1><center>There are no results, please try again.</center></h1>");
}
else
{
//print the body

//TABLE form being created
Print("<Center>");
Print("<TABLE $table_params>\n");

while($row = mysql_fetch_array($result))
{ 

FROM there you design your own table of infoto display

Hope that helps