Image Display "IF"

[dayzeday]

I am needing to write a simple script to!

If the photo is "not null" I need to display it as a image if it is "null" I wish for nothing at all to display.

Here is what I came up with but it does not work. I have tried this a few ways and nothing.

<?php if ($row_Recordset2['photo']=='Not Null') echo '<img src=$row_Recordset2['photo']/>

Help I now I am missing something small here.

[bpat1434]

Well, perhaps you should do this instead:

<?php 
if ($row_Recordset2['photo'] != NULL)
{
    echo '<img src="'.$row_Recordset2['photo'].'" />';
}

~Brett

[dayzeday]

YEAH! It worked I love you! Sometimes it seems like the simple things are what I miss the most. You saved me alot of time!

[bpat1434]

Do you understand what the problem was? That's the most important thing.

Your code looked to see if the request variable was equivalent to "Not Null", which won't account for any of the options PHP will throw back. So in every case, the statement would be false.

Now, my code checks to see if the value is not null as well. I say:

if the request variable is not equivalent to (!=) any of the PHP NULL values (0, Null, empty (I think that's one)) then there is an image, so we should show it.

It's great to get help, but you have to understand where you went wrong, so you hopefully won't make it again.

~Brett

[dayzeday]

Yes! I understand what I was doing wrong and with your explanation I get it even better now.

I am very greatful for the help and the lesson. I learn better with examples.

Matter of fact now I have to learn to resize an image on upload. Got any words of wisdom on that one. 🙂

Thanks Again!

[bpat1434]

Well, I'd point you to ImageMagik again.

I'll give you some code that will resize any user-uploaded photo. This code uses the built in GD library, but you can adapt it to be the ImageMagik if you need to.

<?php
$tempname = $_FILES[$i]['tmp_name'];
$orig_dimensions = getimagesize($tempname);
		if($orig_dimensions == false || $orig_dimensions[2] != 2){
			die(Error_Image_Type);
		}
		$orig_width = $orig_dimensions[0];
		$orig_height = $orig_dimensions[1];
		$image_is_tall = ($orig_height>=$orig_width);
		$orig_image = imagecreatefromjpeg($tempname);
		$sheight = 75;
		$swidth = ceil($orig_width*$sheight/$orig_height);
		$lwidth = 500;
		$lheight = ceil($orig_height*$lwidth/$orig_width);
		if($image_is_tall){
			$t = $sheight;
			$sheight = $swidth;
			$swidth = $t;

		$t = $lwidth;
		$lwidth = $lheight;
		$lheight = $t;
	}
	$small_image = imagecreatetruecolor($swidth, $sheight);
	$large_image = imagecreatetruecolor($lwidth, $lheight);

if(imagecopyresampled($small_image, $orig_image, 0, 0, 0, 0, $swidth, $sheight, $orig_width, $orig_height) === FALSE){
			echo Error_Create_Thumb;
		}
		else{
			$new_small = "/home/ridgeswi/".Thumbs_Path."/".$nxtfile.".jpg";
			if(@imagejpeg($small_image, $new_small, 100) === false){
				$small_created = "<font style=\"color: #f00;\"><b>Missing.</b>  Failed to create.</font>";
				$small_create = false;
				echo Error_Create_New_Thumb;
			}
			else{
				$thumb = "http://www.ridgeswimclub.org/photographs/".$_dir['Year'].'/'.$category.'/'.$evt."/thumbs/".$nxtfile.".jpg";
				$small_created = "<font style=\"color: #090;\">Created successfully.</font>";
				$small_create = true;
				echo New_Thumb_Success;
			}
		}

	if(imagecopyresampled($large_image, $orig_image, 0, 0, 0, 0, $lwidth, $lheight, $orig_width, $orig_height) === FALSE){
		echo Error_Create_Large;
	}
	else{
		$new_large = "/home/ridgeswi/".Event_Path."/".$nxtfile.".jpg";
		if(@imagejpeg($large_image, $new_large, 100) === false){
			$large_created = "<font style=\"color: #f00;\"><b>Missing.</b>  Failed to create.</font>";
			$large_create = false;
			echo Error_Create_New_Image;
		}
		else{
			$photo = "http://www.ridgeswimclub.org/photographs/".$_dir['Year'].'/'.$category.'/'.$evt."/".$nxtfile.".jpg";
			$large_created = "<font style=\"color: #090;\">Created successfully.</font>";
			$large_create = true;
			echo New_Image_Success;
		}
	}
	if($small_create === true && $large_create === true){
	$q1 = "INSERT INTO `Photos` (pyid, pcid, peid, Thumbnail, Photograph) VALUES ('$year', '$cat', '$event', '$thumb', '$photo')";
		$r1 = mysql_query($q1);
		if(!$r1 || $r1 === FALSE){
			echo Error_Database;
		}
		else{
			echo "<br /><font style='color: #090;'><b><i>Success!!</i></b></font>";
		}
	}
	else{
		echo "<br /><font style='color: #000;'><i>Query not run.  One of the images wasn't created:</i><br /><b>Thumbnail:</b> "
		.$small_created."<br /><b>Large Photo:</b> ".$large_created."</font>";
	}
?>

Each of the functions I use you can look up on php.net for their use and syntax.

~Brett

[dayzeday]

Does this create a keep the original image and create a thumbnail also?

[bpat1434]

The function I posted will do the following:

• Get the image from posted form

• Get the image dimensions

• Calculate scaled image dimensions for thumbnail & large image

• Create a thumbnail, and place it in the proper folder

• Create a larger image, and place it in the proper folder

Now, I set my large image to be a width of 500 pixels so that it fits in my site, and doesn't break it. I do the same to my thumbnails.

You can view the thumbnails & large images here: Ridge Swim Club Photographs

They were all done via the upload script that I posted.

~Brett

[dayzeday]

Can I remove the large image from the script and just keep the thumbnail?

Looking at the script is does store the path in the database and the image in a file? RIGHT?!

Sorry .for the stupid question.. I am not real with it today.. today I am working on little sleep.. because the java thang gave me a hard time last night and I still am still not getting it to work.

[bpat1434]

You can remove all the large image code and use the thumbnail code if you want. And the full path (including http host) is stored in the database. So, in the database you would have a column filled with: http://www.domain.com/sub/directory/images/image.jpg

~Brett

[dayzeday]

okay ... here is what I ended up with on modify the script. I got a parse error. I am not sure if I made the changes correly. I am not quite understanding real well today. My filed name is 'photo'

 if ((isset($HTTP_POST_VARS["MM_insert"])) && ($HTTP_POST_VARS["MM_insert"] == "form1")) {
 $tempname = $_FILES[$i]['tmp_name']; 
$orig_dimensions = getimagesize($tempname); 
        if($orig_dimensions == false || $orig_dimensions[2] != 2){ 
            die(Error_Image_Type); 
        } 
        $orig_width = $orig_dimensions[0]; 
        $orig_height = $orig_dimensions[1]; 
        $image_is_tall = ($orig_height>=$orig_width); 
        $orig_image = imagecreatefromjpeg($tempname); 
        $sheight = 75; 
        $swidth = ceil($orig_width*$sheight/$orig_height); 
        if($image_is_tall){ 
            $t = $sheight; 
            $sheight = $swidth; 
            $swidth = $t; 
        } 
        $photo = imagecreatetruecolor($swidth, $sheight); 
if(imagecopyresampled($photo, $orig_image, 0, 0, 0, 0, $swidth, $sheight, $orig_width, $orig_height) === FALSE){ 
            echo Error_Create_Thumb; 
        } 
        else{ 
            $new_small = "/hsphere/local/home/chulamik/granbylionsclub.com/uploads".Thumbs_Path."/".$nxtfile.".jpg"; 
            if(@imagejpeg($photo, $new_small, 100) === false){ 
                $small_created = "<font style=\"color: #f00;\"><b>Missing.</b>  Failed to create.</font>"; 
                $small_create = false; 
                echo Error_Create_New_Thumb; 
            } 
            else{ 
                $thumb = "http://www.granbylionsclub.com/uploads".$_dir['Year'].'/'.$category.'/'.$evt."/thumbs/".$nxtfile.".jpg"; 
                $small_created = "<font style=\"color: #090;\">Created successfully.</font>"; 
                $small_create = true; 
                echo New_Thumb_Success; 
            } 

  $insertSQL = sprintf("INSERT INTO photos (photosID, photo_title, photo, photo_description, photo_display, eventsID, articlesID, main_pagesID, gallery) VALUES (%s, %s, %s, %s, %s, %s, %s, %s, %s)",
                       GetSQLValueString($HTTP_POST_VARS['photosID'], "int"),
                       GetSQLValueString($HTTP_POST_VARS['photo_title'], "text"),
                       GetSQLValueString($photo_url, "text"),
                       GetSQLValueString($HTTP_POST_VARS['photo_description'], "text"),
                       GetSQLValueString($HTTP_POST_VARS['photo_display'], "text"),
                       GetSQLValueString($HTTP_POST_VARS['eventsID'], "text"),
                       GetSQLValueString($HTTP_POST_VARS['articlesID'], "text"),
                       GetSQLValueString($HTTP_POST_VARS['main_pagesID'], "text"),
                       GetSQLValueString($HTTP_POST_VARS['gallery'], "text"));

  mysql_select_db($database_localhost, $localhost);
  $Result1 = mysql_query($insertSQL, $localhost) or die(mysql_error());
} 

[bpat1434]

Parse error? Where? What line?

Doh!

You may have to modify the script with all the $i variables. I used it to do multiple photo uploads.

~Brett

[dayzeday]

I am not sure on the line .. because it gave me the generic statement line 291 which is the last line on the page. Nothing wrong with that. It is something with the my changes I am sure.

[bpat1434]

Normally I find that to be a missing "}" somewhere.

Try adding a closing curly brace just before the closing php tag (?>).

~Brett

[dayzeday]

HEre is the error message that I am getting

Parse error: parse error, unexpected $ in /hsphere/local/home/chulamik/granbylionsclub.com/members/photo-add.php on line 292

ooh... also tried the php tag

[bpat1434]

I think the problem is that you're trying to adapt my code to yours, rather than using it as a basis to grab the functions and basic ideas from. A simple copy paste won't work with this code, as i have a whole other 300 lines that go with it to define error codes, loop through items, and have it customized to what I want.

I would suggest you start fresh, and use the functions I use:
imagecreatefromjpeg()
imagecreatetruecolor()
imagecopyresampled()
imagejpeg()

Then, make your code do as you need: upload 1 photo, add it to the database accordingly.

WHen you've done that, give me some feedback as to how it's working.

I really didn't give you my code to just have you use it. I took it from working code in a website, and gave it to you as a guide. Use it as that, and if you get snagged, ask. I thought orignally that a copy/paste might work, but alas, it doesn't. So on to step two: Put you to work on creating your own script. Plus, this way you'll learn how to do it for next time.

~Brett

[dayzeday]

I am working on rewriting it using your script as a template. Like you suggested I just was not with it well enough yestarday to understand it. I get it this morning and am going to try to do that from scratch.

I will let you know the result.

[bpat1434]

Great. It took me about 45 minutes to write all of it, so it shouldn't take you too long. And it's fairly straight-forward.

I look forward to your reply.

~Brett

[dayzeday]

Okay I was trying to simplify this so that I understand better what you did with your script here is what I got after.. not sure if I am close or not.. but I am getting an unexplaned T error on line 46. Do you see what needs to be changed? or Am I on the right track?

$photo_dir="/hsphere/local/home/chulamik/granbylionsclub.com/uploads";
$photo_url="http://www.granbylionsclub.com/uploads";
$image_diminsions = getimagesize($image);
if($image_diminsions == false || $image_diminsions[2] != 2){
die(Error_Image_Type);
}
$image_width = $image_diminsions[0];
$image_height = $image_diminsions[1];
$image = ($orig_height>=$orig_width);
$image = imagecreatefromjpeg($photo);
$height = 75;
$width = ceil($orig_width*$height/$orig_height
$photo_path = "$photo_dir/$photo_name";
$photo_url = "$photo_url/$photo_name";
copy ($photo, $photo_path)or die ("couldn't copy $photo_name!");
print "<img src='$photo_url'>";
{

[bpat1434]

Originally posted by dayzeday
Okay I was trying to simplify this so that I understand better what you did with your script here is what I got after.. not sure if I am close or not.. but I am getting an unexplaned T error on line 46. Do you see what needs to be changed? or Am I on the right track?

$photo_dir="/hsphere/local/home/chulamik/granbylionsclub.com/uploads";
$photo_url="http://www.granbylionsclub.com/uploads";
$image_diminsions = getimagesize($image);
if($image_diminsions == false || $image_diminsions[2] != 2){
die(Error_Image_Type);
}
$image_width = $image_diminsions[0];
$image_height = $image_diminsions[1];
$image = ($orig_height>=$orig_width);
$image = imagecreatefromjpeg($photo);
$height = 75;
$width = ceil($orig_width*$height/$orig_height
$photo_path = "$photo_dir/$photo_name";
$photo_url = "$photo_url/$photo_name";
copy ($photo, $photo_path)or die ("couldn't copy $photo_name!");
print "<img src='$photo_url'>";
{

If that's a copy & paste, you forgot a closing ");" on the $width = ceil(... line.

Where I have Error_Some_Thing, I defined error messages. So I had something like this:

define('Error_Some_Thing', 'Some Error Message', true);

You can use it, or you can choose to do something different.

Also, are you defining $photo? Not sure cuz this looks like a code snippet, but just want to make sure.

~