Using a function to repeat similar code w/ variables that refer to queries

[oh_maestro]

Here is a snippet of code I am using on a page to put a team's results for a season into an array. I have to repeat this code 9 more times (19 more for basketball) on the page. The only difference in these examples are VW (to be replaced by others like SM, CE, etc.)

do {
if ($row_VW['Team1']=='VW') {
$Pts[1] = $Pts[1] + $row_VW['Pts_Team1'];
$OppPts[1] = $OppPts[1] + $row_VW['Pts_Team2'];
if (($row_VW['Pts_Team1'] - $row_VW['Pts_Team2']) > 0) {
$Won[1]++; }
elseif ($row_VW['Pts_Team1'] - $row_VW['Pts_Team2'] < 0) {
$Lost[1]++; } }
if ($row_VW['Team2']=='VW') {
$Pts[1] = $Pts[1] + $row_VW['Pts_Team2'];
$OppPts[1] = $OppPts[1] + $row_VW['Pts_Team1'];
if ($row_VW['Pts_Team2'] - $row_VW['Pts_Team1'] > 0) {
$Won[1]++; }
elseif ($row_VW['Pts_Team2'] - $row_VW['Pts_Team1'] < 0) {
$Lost[1]++; } }
} while ($row_VW = mysql_fetch_assoc($VW));

$row_VW refers to queried info. I have used Dreamweaver to help me create the queries. Here is the query it creates.

mysql_select_db($database_WBL_0506, $WBL_0506);
$query_VW = "SELECT * FROM wbl_football0506 WHERE Team1 = 'VW' OR Team2 = 'VW' ORDER BY Date ASC";
$VW = mysql_query($query_VW, $WBL_0506) or die(mysql_error());
$row_VW = mysql_fetch_assoc($VW);
$totalRows_VW = mysql_num_rows($VW);

I have tried to use functions before, but can never get them to work when a query is involved. It would really help to streamline my code to have a function that accepts parameter variable (VW, SM, CE, etc.)

i.e.
function results_array ($team_abb) {
all the crap above }

and call it with

results_array ($team_abb="VW"); // or whatever team I would need.

Is there a trick to this using a query in a function that is variable dependent? Is Dreamweaver screwing things up with the way it organizes the query? Am I just way off even trying this and should just suck it up and repeat this code?!?!?!

[devinemke]

why not do everything in the function, including the query itself:

function get_team_results($team)
{
	$array['wins'] = 0;
	$array['loses'] = 0;

$sql = "SELECT * FROM wbl_football0506 WHERE Team1 = '$team' OR Team2 = '$team' ORDER BY Date";
$result = mysql_query($sql) or die(mysql_error());
while ($row = mysql_fetch_assoc($result))
{
	if ($row['Team1'] == $team) {$side = 1;}
	else {$side = 2;}

	if ($row['Pts_Team1'] > $row['Pts_Team2']) {$winner = 1;}
	else {$winner = 2;}

	if ($winner == $side) {$array['wins']++;}
	else {$array['loses']++;}
}

return $array;
}

this will return an array with wins and loses. you can call it like so:

$vw = get_team_results('VW');
print_r($vw);

[oh_maestro]

Thank you very much! I actually did get it to work! These leads me to another problem, one I actually figured out (w/ the help of this forum) in a less complicated array environment.

I have two variables in the function I want to use to be able to sort in order to determine who is in 1st place, 2nd, etc.
$Pct and $Team

I am calling the function with this:

$team = $School[0]; // Where school[0] is from an earlier array to indentify the school
$results[0] = get_team_results($team);
and
$team = $School[1]; // Where school[1] is from an earlier array to indentify the school
$results[1] = get_team_results($team);

etc.

When I didn't use a function, I used this to sort these variables:
array_multisort(&$Pct, SORT_DESC, &$School);

//and...for the hell of it...this is how I got it to display

echo "<tr><th>Team</th><th>Won</th><th>Lost</th><th>Pct</th><th>Pts.</th><th>Opp. Pts.</th></tr>";
$count = 0;
do {
echo "<tr><td>".$School[$count]." ".$Nickname[$count]."</td><td align='center'>".$Won[$count]."</td><td align='center'>".$Lost[$count]."</td><td align='center'>".$Pct[$count]."</td><td align='center'>".$Pts[$count]."</td><td align='center'>".$OppPts[$count]."</td></tr>";
$count++;
}

I want to sort the $Pct DESC and $Team ASC from the arrays $Results[0-9]. Can array_multisort save the day for me w/ this?

If you need me to post the function itself so you can see the code, I will.