problems with __get() function printing my result..

[masood131]

Hi

<?php

class Human
{
  var $attribute;

  function __construct() {
    $this->attribute = array();
  }

  function __set($key, $value) {
    $this->attribute [$key] = $value;
  }

  function __get() {
    foreach($this->attribute as $key => $value)
    echo $key. '=>' .$value;
  }
}

$leslie = new Human();

$leslie->__set('Hair', 'blond');
$leslie->__set('Eyes', 'green');
$leslie->__set('Height', '5 10');
$leslie->__set('Weight', '120');

?>

here is the error message I get

[Fri Apr 15 09:47:08 2005] [error] PHP Fatal error: Method Human::__get() must take exactly 1 argument in c:\program files\apache group\Apache\htdocs\06\leslie.php on line 18

Can someone help me print my results from the get() function. I really would like to keep printing from my get function and not outside the get function if at all possible. I wonder if that is a good idea or is it better to print the result from outside the get() function by returning the result as a string?

Well, any feedback would be greatly appreciated.

Thank you

[bpat1434]

I may be missing something, but what is the point of this?

function __get($somepointer) {
    foreach($this->attribute as $key => $value)
    echo $key. '=>' .$value;
  } 

Think about your code. Why are you requiring the $somepointer variable, but not using it in that function? But that's not as important as what is next:

It has something to do with each of these lines:

$leslie->('Hair', 'blond');
$leslie->('Eyes', 'green');
$leslie->('Height', '5 10');
$leslie->('Weight', '120');

/*
Perhaps it should look a little something like:
*/
$leslie['Eyes'] = 'green';
$leslie['Height'] = '5 10';
$leslie['Weight'] = '120';

/*
OR
*/
$leslie->__set('Eyes', 'green');'
$leslie->__set('Height', '5 10');
$leslie->__set('Weight', '120');

You need to define what that is. Is it an array, a variable, is it being sent to a function?

That's the error. How did i figure that out? I counted to line 23, and then looked at it. Hopefully this is just a Doh! moment for you; however, if not, it's a learning experience.

~Brett

[masood131]

Brett,
All valid point you made. Thank you very much for pointing out my misteakes.

The $somepointer parameter was sugested to me at another forum, and I blindly placed it in there.

This is a very new environment for me, and I am trying to learn how class an arrays work.
Believe me, I am learning to also think beyound my usual surface thinking and ask Q, and you are helping

Back to the program. I am trying to send the attributes of leslie (my instance of class Human) to an array and then print it out, but I don't know the syntax very well. I placed as much code as I knew in here, and I am hoping someone can help me figure out the rest of the syntax.

I have made some changes based on your suggestions to the original code I posted on top.

Thank you very much for your help

p.s. I thought __set() function is calles implicitly and I don't have to actually call the function by including it's name. Am I wrong?

[bpat1434]

You have to explicitly call the functions, unless you call it in another function.

I think this would better suit you:

<?php

class Human
{
  var $attribute;

  function __construct() {
    $this->attribute = array();
  }

  function __set($key, $value) {
    $this->attribute [$key] = $value;
  }

  function __get() {
    foreach($this->attribute as $key => $value)
    echo $key. '=>' .$value;
  }
}

$leslie =& new Human();

// Make $leslie an array
$leslie->__construct();

// Set the array values
$leslie->__set('Hair', 'blond');
$leslie->__set('Eyes', 'green');
$leslie->__set('Height', '5 10');
$leslie->__set('Weight', '120');

// Get the values, echo them out
$leslie->__get();

?> 

~Brett