[Resolved] Passing Varibales to popup window troubles

[facets]

Hi all..

I'm having some troubles passing the stockId to the pop up window. Also the main page code is appearing in the popup.
Does anyone have any suggestions.

tks, Wil.

<?php

include "includes/functions.inc";
include "includes/common_db.inc";

$link_id = db_connect($db);

form();

if ($_POST['submit']) {  

   echo '<pre>';
   print_r($_POST);
   echo "<h1>Submitted to DB</h1><br>"; 
   echo '<a href="'. $_SERVER['PHP_SELF'] .'">Please try again</a>';
   echo "</pre>";

} elseif ($_POST['stockId']) {

//Do whatever for second submit
    view($stockId);
 }
?>

<?
function form() {
?>
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">

<? $sql_query = mysql_query("SELECT description, stockId FROM austock");
echo "<select name=\"stockId\">";
	while(list($stockId)=mysql_fetch_array($sql_query)) {
	echo "<option value=\"$stockId\">$stockId</option>";
}
echo "</select>";
mysql_free_result($sql_query);
?>
<br><br><input type="submit" name="submit" value="submit me!">
<br><br><input type="submit" name="viewDetails" value="View Details">
</form>
    <?  

}

function view($stockId) {
    echo "<script language=\"javascript\">var newWindow = window.open('".$_SERVER['PHP_SELF']."?action=view_record&stockId=".$stockId."')</script>";
    }

function view_record() {
    print "hello world <br>";
    echo $stockId ;
    print "<br>";
    print_r($_SESSION);
    print_r($_POST);
    }
?

[BuzFortuna]

Work with this (taken from a site of mine I made a few months ago):

in the head tag:

<script language="javascript" type="text/javascript">
function view (rowID) {
    if (rowID) {
        detailsWindow = window.open("view.php?id="+ rowID,"details", "width=500,height=430,top=0,left=0,toolbar=no,location=no,status=no,directories=no,scrollbar=no");
        detailsWindow.focus();
    }
}
</script>

In the body:

<a href='javascript:view($id)'>Details</a>

Then in details.php I have a MySQL query selecting where id = $_GET[id]

Hope this sample helped 🙂

[bradgrafelman]

BuzFortuna's code is not needed since you've already got the stockID passed through the URL.

When you pass a variable through the URL, you can retrieve it using the $_GET[] superglobal.

Try replacing:

echo $stockId ;

with:

echo $_GET['stockId'];

Also, I'm assuming you have some IF statement later, that checks the value of 'action=' and calls the view_record() function, right?

Also, at the end of your code snippet, the '?' should have been '?>'. This may just be a typo, I'm not sure.

Also, you are not staying consistent in your PHP tags. Some servers do not use '<?' as a PHP opening tag. To make your script fully compatible, always use '<?PHP' to open a block of PHP code, especially if you can actually see the code on the HTML page.

[facets]

Also, I'm assuming you have some IF statement later, that checks the value of 'action=' and calls the view_record() function, right?

No. Could you show me this?

tks, Will

[bradgrafelman]

...Oh! That's your entire code??

You need to tell PHP what to do! It can't assume "action=" means "do this".

You would do something like:

if($_GET['action'] == 'view_record' && isset($_GET['stockId'])) view_record();

I'm assuming register_globals is set to "Off", as on all good servers it should be. I'm also assuming you noted my change about using $_GET['stockId'] instead of $stockId.

[facets]

so I would put that in the view_record function?

tks, Will.

[BuzFortuna]

Just put the code that was posted before:

if($_GET['action'] == 'view_record' && isset($_GET['stockId'])) view_record();

Put that where you want the stock related stuff to show up. That will say "If the action is to view the record and the stockId has a value, then act on view_record). view_record says to echo the stockId. Change the bottom part of your code to this:

function view_record() {
    print "hello world <br>";
    $stockId = $_GET['stockId'];
    echo $stockId ;
    print "<br>";
    print_r($_SESSION);
    print_r($_POST);
    }
?>

$stockId = $_GET['stockId']; lets it know that $stockId is whatever is in the get value (URL), and the > is just to close your PHP. All this has been posted already I'm just reiterating it for you...

[bradgrafelman]

No!

You would put that OUTSIDE of all the functions. Just out in the script somewhere.

EDIT: My post was submitted before I saw BuzzFortuna's post. My 'No!' was not directed at you, Buzz. :p

[facets]

thanks for the replies..
We are very close.
The popup is working now (ie, the print statement is displaying) but still not stockId. Any ideas?

tia, will.

<?php

include "includes/functions.inc";
include "includes/common_db.inc";

$link_id = db_connect($db);

form();

if ($_POST['submit']) {  

   echo '<pre>';
   print_r($_POST);
   echo "<h1>Submitted to DB</h1><br>"; 
   echo '<a href="'. $_SERVER['PHP_SELF'] .'">Please try again</a>';
   echo "</pre>";

} elseif ($_POST['stockId']) {

//Do whatever for second submit
    view($stockId);
 }

if($_GET['action'] == 'view_record' && isset($_GET['stockId'])) view_record()

?>

<?
function form() {
?>
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">

<? $sql_query = mysql_query("SELECT description, stockId FROM austock");
echo "<select name=\"stockId\">";
	while(list($stockId)=mysql_fetch_array($sql_query)) {
	echo "<option value=\"$stockId\">$stockId</option>";
}
echo "</select>";
mysql_free_result($sql_query);
?>
<br><br><input type="submit" name="submit" value="submit me!">
<br><br><input type="submit" name="viewDetails" value="View Details">
</form>
    <?  

}

function view($stockId) {
    echo "<script language=\"javascript\">var newWindow = window.open('".$_SERVER['PHP_SELF']."?action=view_record&stockId=".$stockId."')</script>";
    }

function view_record() {
    print "hello world <br>";
    $stockId = $_GET['stockId'];
    echo $stockId ;
    print "<br>";
    print_r($_SESSION);
    print_r($_POST);
    } 

?>

[BuzFortuna]

:o

[BuzFortuna]

I could be totally wrong with this and I haven't tried it, but give it a shot (make sure to backup your old one):

<?php

include "includes/functions.inc";
include "includes/common_db.inc";

$link_id = db_connect($db);
?>
<?php

function view($stockId) {
    echo "<script language=\"javascript\">var newWindow = window.open('".$_SERVER['PHP_SELF']."?action=view_record&stockId=".$stockId."')</script>";
}

function view_record() {
    print "hello world <br>";
    $stockId = $_GET['stockId'];
    echo $stockId ;
    print "<br>";
    print_r($_SESSION);
    print_r($_POST);
} 

#BEGINNING OF FORM
function form() {
?>
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
    <?php $sql_query = mysql_query("SELECT description, stockId FROM austock");
    echo "<select name=\"stockId\">";
         while(list($stockId)=mysql_fetch_array($sql_query)) {
        echo "<option value=\"$stockId\">$stockId</option>";
    }
    echo "</select>";
    mysql_free_result($sql_query);
?>
<br><br><input type="submit" name="submit" value="submit me!">
<br><br><input type="submit" name="viewDetails" value="View Details">
</form>
    <?php
}
#END OF FORM
?>
<?php
#PAGE HANDLES
if (!isset($_POST['submit']) && $_GET['stockId'] == FALSE) { //this is assuming you don't want the form displayed on the stockId page
	form(); //display form
}
if (isset($_POST['submit'])) {
   echo '<pre>';
   print_r($_POST);
   echo "<h1>Submitted to DB</h1><br>"; 
   echo '<a href="'. $_SERVER['PHP_SELF'] .'">Please try again</a>';
   echo "</pre>";
}
if($_GET['action'] == 'view_record' && $_GET['stockId'] == TRUE) {
	view_record();
}
#END PAGE HANDLES
?>

[bradgrafelman]

Buz, yes it did; I used a one-liner!

There was a mistake in the other code, however:

if($_GET['action'] == 'view_record' && isset($_GET['stockId'])) view_record() 

should be:

if($_GET['action'] == 'view_record' && isset($_GET['stockId'])) view_record();

Note the missing semicolon after view_record().

EDIT: For statements such as while(), for(), foreach(), if(), etc. that use brackets, you may omit the brackets if you are only executing one function/etc. (as in the above code).

[facets]

please excuse my ignorance buz.. but what should be there?

I thought it was executing the view_record function??

tks, Wil.

[BuzFortuna]

Could part of the problem be that they define view_record after it's called? I changed that in my version of it; not sure it matters though... I'm still a newb.

edit; like bradgrafelman said, it was just missing a ; 🙂

[facets]

I fixed the typo. oops.. but it still didn't pass the variable.
Would it appear in the URL? ie,
http://127.0.0.1/materials_register/testSubmit.php?action=view_record&stockId=

tks, Will

[BuzFortuna]

Yes. Your problem is that it opens the window and stockid=$stockId, but it doesn't look like you have $stockId defined before the javascript. The javascript link goes to the page and uses $stockId in the variable, but it's not showing up in your URL because it isn't defined! the url should be http://127.0.0.1/materials_register/testSubmit.php?action=view_record&stockId=5 or something where stockId is defined. Just try putting a number in there and it should work. All you have to do now is define $stockId before you use it in the javascript link. You can get it from a database, define it, whatever. But that's your problem. 🙂

It doesn't sound like you're too brushed up on GET methods either if you didn't know it should have a value... try reading here http://us2.php.net/variables.predefined and here http://us2.php.net/manual/en/reserved.variables.php#reserved.variables.get for a little bit and see if you get a hold on it.

[facets]

OK.. Almost there.. MANY Thanks for your assistance!
adding the stockId=2 worked a treat!

Now defining that variable.
When I use

<?php

include "includes/functions.inc";
include "includes/common_db.inc";

$link_id = db_connect($db);

$stockId=0

It passes the stockId as 0. So it's not being set.

tks, Wil

[BuzFortuna]

If you have $stockId=0, and it passes as 0... it IS being set (you set it as 0)

[bradgrafelman]

It should appear in the URL, yes.

At this point, can you give us a link to see what's being done?

If your URL is missing the ID like you posted, the variable probably isn't set correctly. Give us a link and let's see.

[facets]

sure.. so how should I set it correctly?

$stockId = $_GET['stockId']