Redirect problem

Jon12345

I have a form that submits data and it stays on the same page using isset. See code below.

After it gets to the echo statement saying "Update successful", I want it to auto redirect to itself again so that I can enter another value straight away.

How can I do this? Currently, it gives me the error:

Warning: Cannot modify header information - headers already

 <?php 
if (!$submit)
{
// code to display form goes here
?>

<form name="form1" method="post" action="<? echo $PHP_SELF; ?>"
  <p>&nbsp;</p>
  <table width="200" border="0" cellspacing="0" cellpadding="5">
    <tr> 
      <td>TopicName1</td>
      <td><input name="TopicName" type="text" id="TopicName"></td>
    </tr>
    <tr> 
      <td>MetaTitle</td>
      <td><input name="MetaTitle" type="text" id="MetaTitle"></td>
    </tr>
    <tr> 
      <td>&nbsp;</td>
      <td>&nbsp;</td>
    </tr>
    <tr> 
      <td>&nbsp;</td>
      <td>&nbsp;</td>
    </tr>
    <tr> 
      <td>&nbsp;</td>
      <td>&nbsp;</td>
    </tr>
    <tr>
      <td>&nbsp;</td>
      <td><input type="submit" name="submit" value="Submit"></td>
    </tr>
  </table>
  <p>&nbsp;</p>
  <p>&nbsp;</p>
</form>

<?
}
else
{	
 //form processor code goes here

$dbh=mysql_connect ("localhost", "alwaysac", "xxx") or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ("alwaysac_MyArticles"); 
mysql_query("insert into Articles(TopicName, MetaTitle) values('$TopicName', '$MetaTitle')"); 
//mysql_query("insert into Articles(TopicName) values('$TopicName')");
echo "Update successful.";

mysql_close($dbh);
header("Location: " . "peaadd.php1"); 
}
?>

mrhappiness

Originally posted by Jon12345
After it gets to the echo statement saying "Update successful",

you have sent output to the browser and because of this the headers have been sent too

no output to the browser is allowed before using header() and echo is output

Jon12345

What is the best solution? Basically, I want to enter a value into the form, submit it and then immediately enter another value in there.

Is it best to just put it over 2 pages? e.g. Form.php and Submitted.php and then have the redirect on the Submitted.php page?

thorpe

just remove this line and it should work.

echo "Update successful.";

of course, you will no longer have a 'success message'.

Jon12345

I have commented out that line but it still says:

Warning: Cannot modify header information - headers already sent by (output started at /home/alwaysac/public_html/peaadd1.php:1) in /home/alwaysac/public_html/peaadd1.php on line 52

Line 52 in my code is:

header("Location: " . "peaadd1.php");

Any ideas?

thorpe

well.... you cant send anything to the browser before calling the header() function. so remove anything that is sent to the browser.

this includes all echo()'s and any white space that might be before your php delimiters.

LordShryku

That also includes any html being output beforehand, including your basic <html> tag.

bradgrafelman

It also includes any deadspace before or after the <?PHP ?> tags!

It's not the most RFC-compliant idea, but you could do this:

echo "Update successfull!\n<meta http-equiv=\"Refresh\" content=\"3; URL=" . $_SERVER['PHP_SELF'] . "\">";